mirror of
https://github.com/capstone-engine/llvm-capstone.git
synced 2025-05-14 01:46:41 +00:00
5aeaabf35e
The standard requires[0] member function constraints to be checked when explicitly instantiating classes. This patch adds this constraints check. This issue is tracked as #46029 [1]. Note that there's an related open CWG issue (2421[2]) about what to do when multiple candidates have satisfied constraints. This is particularly an issue because mangling doesn't contain function constraints, and so the following code still ICEs with definition with same mangled name '_ZN1BIiE1fEv' as another definition: template<class T> struct B { int f() requires std::same_as<T, int> { return 0; } int f() requires (std::same_as<T, int> && !std::same_as<T, char>) { return 1; } }; template struct B<int>; Also note that the constraints checking while instantiating *functions* is still not implemented. I started looking at it but It's a bit more complicated. I believe in such a case we have to consider the partial constraints order and potentially choose the best candidate out of the set of multiple valid ones. [0]: https://eel.is/c++draft/temp.explicit#10 [1]: https://github.com/llvm/llvm-project/issues/46029 [2]: https://cplusplus.github.io/CWG/issues/2421.html Differential Revision: https://reviews.llvm.org/D120255
39 lines
903 B
C++
39 lines
903 B
C++
// RUN: %clang_cc1 -std=c++20 -ast-dump %s | FileCheck %s
|
|
|
|
namespace PR46029 {
|
|
|
|
template <int N>
|
|
void canary1();
|
|
template <int N>
|
|
void canary2();
|
|
|
|
template <int N>
|
|
struct A {
|
|
void f() requires(N == 1) {
|
|
static_assert(N == 1);
|
|
canary1<N>();
|
|
}
|
|
void f() requires(N == 2) {
|
|
static_assert(N == 2);
|
|
canary2<N>();
|
|
}
|
|
};
|
|
|
|
// This checks that `canary1<1>` and `canaray2<2>` are instantiated, thus
|
|
// indirectly validating that the correct candidates of `A::f` were really
|
|
// instantiated each time.
|
|
// The `static_assert`s validate we don't instantiate wrong candidates.
|
|
|
|
// CHECK:{{.*}}FunctionTemplateDecl {{.*}} canary1
|
|
// CHECK: {{.*}}TemplateArgument integral
|
|
// CHECK-SAME: {{1$}}
|
|
template struct A<1>;
|
|
|
|
// CHECK: {{.*}}FunctionTemplateDecl {{.*}} canary2
|
|
// CHECK: {{.*}}TemplateArgument integral
|
|
// CHECK-SAME: {{2$}}
|
|
template struct A<2>;
|
|
|
|
template struct A<3>;
|
|
}
|