mirror of
https://github.com/capstone-engine/llvm-capstone.git
synced 2025-05-14 01:46:41 +00:00

We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
213 lines
3.4 KiB
C
213 lines
3.4 KiB
C
// RUN: %clang_cc1 -triple i386-unknown-unknown -O3 %s -emit-llvm -o - | FileCheck %s
|
|
|
|
int foo(int i) {
|
|
int j = 0;
|
|
switch (i) {
|
|
case -1:
|
|
j = 1; break;
|
|
case 1 :
|
|
j = 2; break;
|
|
case 2:
|
|
j = 3; break;
|
|
default:
|
|
j = 42; break;
|
|
}
|
|
j = j + 1;
|
|
return j;
|
|
}
|
|
|
|
int foo2(int i) {
|
|
int j = 0;
|
|
switch (i) {
|
|
case 1 :
|
|
j = 2; break;
|
|
case 2 ... 10:
|
|
j = 3; break;
|
|
default:
|
|
j = 42; break;
|
|
}
|
|
j = j + 1;
|
|
return j;
|
|
}
|
|
|
|
int foo3(int i) {
|
|
int j = 0;
|
|
switch (i) {
|
|
default:
|
|
j = 42; break;
|
|
case 111:
|
|
j = 111; break;
|
|
case 0 ... 100:
|
|
j = 1; break;
|
|
case 222:
|
|
j = 222; break;
|
|
}
|
|
return j;
|
|
}
|
|
|
|
|
|
static int foo4(int i) {
|
|
int j = 0;
|
|
switch (i) {
|
|
case 111:
|
|
j = 111; break;
|
|
case 0 ... 100:
|
|
j = 1; break;
|
|
case 222:
|
|
j = 222; break;
|
|
default:
|
|
j = 42; break;
|
|
case 501 ... 600:
|
|
j = 5; break;
|
|
}
|
|
return j;
|
|
}
|
|
|
|
// CHECK-LABEL: define{{.*}} i32 @foo4t()
|
|
// CHECK: ret i32 376
|
|
// CHECK: }
|
|
int foo4t(void) {
|
|
// 111 + 1 + 222 + 42 = 376
|
|
return foo4(111) + foo4(99) + foo4(222) + foo4(601);
|
|
}
|
|
|
|
// CHECK-LABEL: define{{.*}} void @foo5()
|
|
// CHECK-NOT: switch
|
|
// CHECK: }
|
|
void foo5(void){
|
|
switch(0){
|
|
default:
|
|
if (0) {
|
|
|
|
}
|
|
}
|
|
}
|
|
|
|
// CHECK-LABEL: define{{.*}} void @foo6()
|
|
// CHECK-NOT: switch
|
|
// CHECK: }
|
|
void foo6(void){
|
|
switch(0){
|
|
}
|
|
}
|
|
|
|
// CHECK-LABEL: define{{.*}} void @foo7()
|
|
// CHECK-NOT: switch
|
|
// CHECK: }
|
|
void foo7(void){
|
|
switch(0){
|
|
foo7();
|
|
}
|
|
}
|
|
|
|
|
|
// CHECK-LABEL: define{{.*}} i32 @f8(
|
|
// CHECK: ret i32 3
|
|
// CHECK: }
|
|
int f8(unsigned x) {
|
|
switch(x) {
|
|
default:
|
|
return 3;
|
|
case 0xFFFFFFFF ... 1: // This range should be empty because x is unsigned.
|
|
return 0;
|
|
}
|
|
}
|
|
|
|
// Ensure that default after a case range is not ignored.
|
|
//
|
|
// CHECK-LABEL: define{{.*}} i32 @f9()
|
|
// CHECK: ret i32 10
|
|
// CHECK: }
|
|
static int f9_0(unsigned x) {
|
|
switch(x) {
|
|
case 10 ... 0xFFFFFFFF:
|
|
return 0;
|
|
default:
|
|
return 10;
|
|
}
|
|
}
|
|
int f9(void) {
|
|
return f9_0(2);
|
|
}
|
|
|
|
// Ensure that this doesn't compile to infinite loop in g() due to
|
|
// miscompilation of fallthrough from default to a (tested) case
|
|
// range.
|
|
//
|
|
// CHECK-LABEL: define{{.*}} i32 @f10()
|
|
// CHECK: ret i32 10
|
|
// CHECK: }
|
|
static int f10_0(unsigned x) {
|
|
switch(x) {
|
|
default:
|
|
x += 1;
|
|
case 10 ... 0xFFFFFFFF:
|
|
return 0;
|
|
}
|
|
}
|
|
|
|
int f10(void) {
|
|
f10_0(1);
|
|
return 10;
|
|
}
|
|
|
|
// This generated incorrect code because of poor switch chaining.
|
|
//
|
|
// CHECK-LABEL: define{{.*}} i32 @f11(
|
|
// CHECK: ret i32 3
|
|
// CHECK: }
|
|
int f11(int x) {
|
|
switch(x) {
|
|
default:
|
|
return 3;
|
|
case 10 ... 0xFFFFFFFF:
|
|
return 0;
|
|
}
|
|
}
|
|
|
|
// This just asserted because of the way case ranges were calculated.
|
|
//
|
|
// CHECK-LABEL: define{{.*}} i32 @f12(
|
|
// CHECK: ret i32 3
|
|
// CHECK: }
|
|
int f12(int x) {
|
|
switch (x) {
|
|
default:
|
|
return 3;
|
|
case 10 ... -1:
|
|
return 0;
|
|
}
|
|
}
|
|
|
|
// Make sure return is not constant (if empty range is skipped or miscompiled)
|
|
//
|
|
// CHECK-LABEL: define{{.*}} i32 @f13(
|
|
// CHECK: ret i32 %
|
|
// CHECK: }
|
|
int f13(unsigned x) {
|
|
switch(x) {
|
|
case 2:
|
|
// fallthrough empty range
|
|
case 10 ... 9:
|
|
return 10;
|
|
default:
|
|
return 0;
|
|
}
|
|
}
|
|
|
|
// Don't delete a basic block that we want to introduce later references to.
|
|
// This isn't really specific to switches, but it's easy to show with them.
|
|
int f14(int x) {
|
|
switch (x) {
|
|
|
|
// case range so that the case block has no predecessors
|
|
case 0 ... 15:
|
|
// any expression which doesn't introduce a new block
|
|
(void) 0;
|
|
// kaboom
|
|
|
|
default:
|
|
return x;
|
|
}
|
|
}
|