mirror of
https://github.com/capstone-engine/llvm-capstone.git
synced 2025-05-13 17:37:00 +00:00
c6c86965d9
Close https://github.com/llvm/llvm-project/issues/79240 Cite the comment from @mizvekov in //github.com/llvm/llvm-project/issues/79240: > There are two kinds of bugs / issues relevant here: > > Clang bugs that this change hides > Here we can add a Frontend flag that disables the GMF ODR check, just > so > we can keep tracking, testing and fixing these issues. > The Driver would just always pass that flag. > We could add that flag in this current issue. > Bugs in user code: > I don't think it's worth adding a corresponding Driver flag for > controlling the above Frontend flag, since we intend it's behavior to > become default as we fix the problems, and users interested in testing > the more strict behavior can just use the Frontend flag directly. This patch follows the suggestion: - Introduce the CC1 flag `-fskip-odr-check-in-gmf` which is by default off, so that the every existing test will still be tested with checking ODR violations. - Passing `-fskip-odr-check-in-gmf` in the driver to keep the behavior we intended. - Edit the document to tell the users who are still interested in more strict checks can use `-Xclang -fno-skip-odr-check-in-gmf` to get the existing behavior.
80 lines
2.0 KiB
C++
80 lines
2.0 KiB
C++
// RUN: rm -rf %t
|
|
// RUN: mkdir -p %t
|
|
// RUN: split-file %s %t
|
|
//
|
|
// RUN: %clang_cc1 -std=c++20 %t/mod1.cppm -emit-module-interface -o %t/mod1.pcm
|
|
// RUN: %clang_cc1 -std=c++20 %t/mod2.cppm -fmodule-file=mod1=%t/mod1.pcm \
|
|
// RUN: -fsyntax-only -verify
|
|
//
|
|
// RUN: %clang_cc1 -std=c++20 %t/mod3.cppm -emit-module-interface -o %t/mod3.pcm
|
|
// RUN: %clang_cc1 -std=c++20 %t/mod4.cppm -fmodule-file=mod3=%t/mod3.pcm \
|
|
// RUN: -fsyntax-only -verify
|
|
|
|
// Testing the behavior of `-fskip-odr-check-in-gmf`
|
|
// RUN: %clang_cc1 -std=c++20 %t/mod3.cppm -fskip-odr-check-in-gmf \
|
|
// RUN: -emit-module-interface -o %t/mod3.pcm
|
|
// RUN: %clang_cc1 -std=c++20 %t/mod4.cppm -fmodule-file=mod3=%t/mod3.pcm \
|
|
// RUN: -fskip-odr-check-in-gmf -DSKIP_ODR_CHECK_IN_GMF -fsyntax-only -verify
|
|
|
|
//--- size_t.h
|
|
|
|
extern "C" {
|
|
typedef unsigned int size_t;
|
|
}
|
|
|
|
//--- csize_t
|
|
namespace std {
|
|
using :: size_t;
|
|
}
|
|
|
|
//--- align.h
|
|
namespace std {
|
|
enum class align_val_t : size_t {};
|
|
}
|
|
|
|
//--- mod1.cppm
|
|
module;
|
|
#include "size_t.h"
|
|
#include "align.h"
|
|
export module mod1;
|
|
export using std::align_val_t;
|
|
|
|
//--- mod2.cppm
|
|
// expected-no-diagnostics
|
|
module;
|
|
#include "size_t.h"
|
|
#include "csize_t"
|
|
#include "align.h"
|
|
export module mod2;
|
|
import mod1;
|
|
export using std::align_val_t;
|
|
|
|
//--- signed_size_t.h
|
|
// Test that we can still find the case if the underlying type is different
|
|
extern "C" {
|
|
typedef signed int size_t;
|
|
}
|
|
|
|
//--- mod3.cppm
|
|
module;
|
|
#include "size_t.h"
|
|
#include "align.h"
|
|
export module mod3;
|
|
export using std::align_val_t;
|
|
|
|
//--- mod4.cppm
|
|
module;
|
|
#include "signed_size_t.h"
|
|
#include "csize_t"
|
|
#include "align.h"
|
|
export module mod4;
|
|
import mod3;
|
|
export using std::align_val_t;
|
|
|
|
#ifdef SKIP_ODR_CHECK_IN_GMF
|
|
// expected-no-diagnostics
|
|
#else
|
|
// expected-error@align.h:* {{'std::align_val_t' has different definitions in different modules; defined here first difference is enum with specified type 'size_t' (aka 'int')}}
|
|
// expected-note@align.h:* {{but in 'mod3.<global>' found enum with specified type 'size_t' (aka 'unsigned int')}}
|
|
#endif
|