mirror of
https://github.com/capstone-engine/llvm-capstone.git
synced 2025-05-13 17:37:00 +00:00

1. The generated file contained a lot of duplicate switch cases, e.g.: ``` switch (Syntax) { case AttributeCommonInfo::Syntax::AS_GNU: return llvm::StringSwitch<int>(Name) ... .Case("error", 1) .Case("warning", 1) .Case("error", 1) .Case("warning", 1) ``` 2. Some attributes were listed in wrong places, e.g.: ``` case AttributeCommonInfo::Syntax::AS_CXX11: { if (ScopeName == "") { return llvm::StringSwitch<int>(Name) ... .Case("warn_unused_result", LangOpts.CPlusPlus11 ? 201907 : 0) ``` `warn_unused_result` is a non-standard attribute and should not be available as [[warn_unused_result]]. 3. Some attributes had the wrong version, e.g.: ``` case AttributeCommonInfo::Syntax::AS_CXX11: { } else if (ScopeName == "gnu") { return llvm::StringSwitch<int>(Name) ... .Case("fallthrough", LangOpts.CPlusPlus11 ? 201603 : 0) ``` [[gnu::fallthrough]] is a non-standard spelling and should not have the standard version. Instead, __has_cpp_attribute should return 1 for it. There is another issue with attributes that share spellings, e.g.: ``` .Case("interrupt", true && (T.getArch() == llvm::Triple::arm || ...) ? 1 : 0) .Case("interrupt", true && (T.getArch() == llvm::Triple::avr) ? 1 : 0) ... .Case("interrupt", true && (T.getArch() == llvm::Triple::riscv32 || ...) ? 1 : 0) ``` As can be seen, __has_attribute(interrupt) would only return true for ARM targets. This patch does not address this issue. Differential Revision: https://reviews.llvm.org/D159393
87 lines
1.8 KiB
C
87 lines
1.8 KiB
C
// RUN: %clang_cc1 -std=c11 -E -P %s -o - | FileCheck %s
|
|
// RUN: %clang_cc1 -std=c2x -E -P %s -o - | FileCheck %s
|
|
|
|
#define C2x(x) x: __has_c_attribute(x)
|
|
|
|
// CHECK: fallthrough: 201910L
|
|
C2x(fallthrough)
|
|
|
|
// CHECK: __nodiscard__: 202003L
|
|
C2x(__nodiscard__)
|
|
|
|
// CHECK: warn_unused_result: 0
|
|
C2x(warn_unused_result)
|
|
|
|
// CHECK: gnu::warn_unused_result: 1
|
|
C2x(gnu::warn_unused_result)
|
|
|
|
// CHECK: clang::warn_unused_result: 0
|
|
C2x(clang::warn_unused_result)
|
|
|
|
// CHECK: selectany: 0
|
|
C2x(selectany); // Known attribute not supported in C mode
|
|
|
|
// CHECK: frobble: 0
|
|
C2x(frobble) // Unknown attribute
|
|
|
|
// CHECK: frobble::frobble: 0
|
|
C2x(frobble::frobble) // Unknown vendor namespace
|
|
|
|
// CHECK: clang::annotate: 1
|
|
C2x(clang::annotate)
|
|
|
|
// CHECK: deprecated: 201904L
|
|
C2x(deprecated)
|
|
|
|
// CHECK: maybe_unused: 202106L
|
|
C2x(maybe_unused)
|
|
|
|
// CHECK: __gnu__::warn_unused_result: 1
|
|
C2x(__gnu__::warn_unused_result)
|
|
|
|
// CHECK: gnu::__warn_unused_result__: 1
|
|
C2x(gnu::__warn_unused_result__)
|
|
|
|
// Test that macro expansion of the builtin argument works.
|
|
#define C clang
|
|
#define L likely
|
|
#define CL clang::likely
|
|
#define N nodiscard
|
|
|
|
#if __has_c_attribute(N)
|
|
int has_nodiscard;
|
|
#endif
|
|
// CHECK: int has_nodiscard;
|
|
|
|
#if __has_c_attribute(C::L)
|
|
int has_clang_likely_1;
|
|
#endif
|
|
// CHECK: int has_clang_likely_1;
|
|
|
|
#if __has_c_attribute(clang::L)
|
|
int has_clang_likely_2;
|
|
#endif
|
|
// CHECK: int has_clang_likely_2;
|
|
|
|
#if __has_c_attribute(C::likely)
|
|
int has_clang_likely_3;
|
|
#endif
|
|
// CHECK: int has_clang_likely_3;
|
|
|
|
#if __has_c_attribute(CL)
|
|
int has_clang_likely_4;
|
|
#endif
|
|
// CHECK: int has_clang_likely_4;
|
|
|
|
#define FUNCLIKE1(x) clang::x
|
|
#if __has_c_attribute(FUNCLIKE1(likely))
|
|
int funclike_1;
|
|
#endif
|
|
// CHECK: int funclike_1;
|
|
|
|
#define FUNCLIKE2(x) _Clang::x
|
|
#if __has_c_attribute(FUNCLIKE2(likely))
|
|
int funclike_2;
|
|
#endif
|
|
// CHECK: int funclike_2;
|