mirror of
https://github.com/capstone-engine/llvm-capstone.git
synced 2025-04-18 06:10:37 +00:00

We recently noticed that the unwrap_iter.h file was pushing macros, but it was pushing them again instead of popping them at the end of the file. This led to libc++ basically swallowing any custom definition of these macros in user code: #define min HELLO #include <algorithm> // min is not HELLO anymore, it's not defined While investigating this issue, I noticed that our push/pop pragmas were actually entirely wrong too. Indeed, instead of pushing macros like `move`, we'd push `move(int, int)` in the pragma, which is not a valid macro name. As a result, we would not actually push macros like `move` -- instead we'd simply undefine them. This led to the following code not working: #define move HELLO #include <algorithm> // move is not HELLO anymore Fixing the pragma push/pop incantations led to a cascade of issues because we use identifiers like `move` in a large number of places, and all of these headers would now need to do the push/pop dance. This patch fixes all these issues. First, it adds a check that we don't swallow important names like min, max, move or refresh as explained above. This is done by augmenting the existing system_reserved_names.gen.py test to also check that the macros are what we expect after including each header. Second, it fixes the push/pop pragmas to work properly and adds missing pragmas to all the files I could detect a failure in via the newly added test. rdar://121365472 (cherry picked from commit 7b4622514d232ce5f7110dd8b20d90e81127c467)
157 lines
5.2 KiB
C++
157 lines
5.2 KiB
C++
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef _LIBCPP___NUMERIC_PSTL_TRANSFORM_REDUCE_H
|
|
#define _LIBCPP___NUMERIC_PSTL_TRANSFORM_REDUCE_H
|
|
|
|
#include <__algorithm/pstl_backend.h>
|
|
#include <__algorithm/pstl_frontend_dispatch.h>
|
|
#include <__config>
|
|
#include <__functional/operations.h>
|
|
#include <__numeric/transform_reduce.h>
|
|
#include <__type_traits/is_execution_policy.h>
|
|
#include <__utility/move.h>
|
|
#include <optional>
|
|
|
|
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
|
|
# pragma GCC system_header
|
|
#endif
|
|
|
|
_LIBCPP_PUSH_MACROS
|
|
#include <__undef_macros>
|
|
|
|
#if !defined(_LIBCPP_HAS_NO_INCOMPLETE_PSTL) && _LIBCPP_STD_VER >= 17
|
|
|
|
_LIBCPP_BEGIN_NAMESPACE_STD
|
|
|
|
template <class _ExecutionPolicy,
|
|
class _ForwardIterator1,
|
|
class _ForwardIterator2,
|
|
class _Tp,
|
|
class _BinaryOperation1,
|
|
class _BinaryOperation2,
|
|
class _RawPolicy = __remove_cvref_t<_ExecutionPolicy>,
|
|
enable_if_t<is_execution_policy_v<_RawPolicy>, int> = 0>
|
|
_LIBCPP_HIDE_FROM_ABI optional<_Tp> __transform_reduce(
|
|
_ExecutionPolicy&&,
|
|
_ForwardIterator1&& __first1,
|
|
_ForwardIterator1&& __last1,
|
|
_ForwardIterator2&& __first2,
|
|
_Tp&& __init,
|
|
_BinaryOperation1&& __reduce,
|
|
_BinaryOperation2&& __transform) noexcept {
|
|
using _Backend = typename __select_backend<_RawPolicy>::type;
|
|
return std::__pstl_transform_reduce<_RawPolicy>(
|
|
_Backend{},
|
|
std::move(__first1),
|
|
std::move(__last1),
|
|
std::move(__first2),
|
|
std::move(__init),
|
|
std::move(__reduce),
|
|
std::move(__transform));
|
|
}
|
|
|
|
template <class _ExecutionPolicy,
|
|
class _ForwardIterator1,
|
|
class _ForwardIterator2,
|
|
class _Tp,
|
|
class _BinaryOperation1,
|
|
class _BinaryOperation2,
|
|
class _RawPolicy = __remove_cvref_t<_ExecutionPolicy>,
|
|
enable_if_t<is_execution_policy_v<_RawPolicy>, int> = 0>
|
|
_LIBCPP_HIDE_FROM_ABI _Tp transform_reduce(
|
|
_ExecutionPolicy&& __policy,
|
|
_ForwardIterator1 __first1,
|
|
_ForwardIterator1 __last1,
|
|
_ForwardIterator2 __first2,
|
|
_Tp __init,
|
|
_BinaryOperation1 __reduce,
|
|
_BinaryOperation2 __transform) {
|
|
auto __res = std::__transform_reduce(
|
|
__policy,
|
|
std::move(__first1),
|
|
std::move(__last1),
|
|
std::move(__first2),
|
|
std::move(__init),
|
|
std::move(__reduce),
|
|
std::move(__transform));
|
|
|
|
if (!__res)
|
|
std::__throw_bad_alloc();
|
|
return *std::move(__res);
|
|
}
|
|
|
|
// This overload doesn't get a customization point because it's trivial to detect (through e.g.
|
|
// __desugars_to) when specializing the more general variant, which should always be preferred
|
|
template <class _ExecutionPolicy,
|
|
class _ForwardIterator1,
|
|
class _ForwardIterator2,
|
|
class _Tp,
|
|
enable_if_t<is_execution_policy_v<__remove_cvref_t<_ExecutionPolicy>>, int> = 0>
|
|
_LIBCPP_HIDE_FROM_ABI _Tp transform_reduce(
|
|
_ExecutionPolicy&& __policy,
|
|
_ForwardIterator1 __first1,
|
|
_ForwardIterator1 __last1,
|
|
_ForwardIterator2 __first2,
|
|
_Tp __init) {
|
|
return std::transform_reduce(__policy, __first1, __last1, __first2, __init, plus{}, multiplies{});
|
|
}
|
|
|
|
template <class _ExecutionPolicy,
|
|
class _ForwardIterator,
|
|
class _Tp,
|
|
class _BinaryOperation,
|
|
class _UnaryOperation,
|
|
class _RawPolicy = __remove_cvref_t<_ExecutionPolicy>,
|
|
enable_if_t<is_execution_policy_v<_RawPolicy>, int> = 0>
|
|
[[nodiscard]] _LIBCPP_HIDE_FROM_ABI optional<__remove_cvref_t<_Tp>> __transform_reduce(
|
|
_ExecutionPolicy&&,
|
|
_ForwardIterator&& __first,
|
|
_ForwardIterator&& __last,
|
|
_Tp&& __init,
|
|
_BinaryOperation&& __reduce,
|
|
_UnaryOperation&& __transform) noexcept {
|
|
using _Backend = typename __select_backend<_RawPolicy>::type;
|
|
return std::__pstl_transform_reduce<_RawPolicy>(
|
|
_Backend{},
|
|
std::move(__first),
|
|
std::move(__last),
|
|
std::move(__init),
|
|
std::move(__reduce),
|
|
std::move(__transform));
|
|
}
|
|
|
|
template <class _ExecutionPolicy,
|
|
class _ForwardIterator,
|
|
class _Tp,
|
|
class _BinaryOperation,
|
|
class _UnaryOperation,
|
|
class _RawPolicy = __remove_cvref_t<_ExecutionPolicy>,
|
|
enable_if_t<is_execution_policy_v<_RawPolicy>, int> = 0>
|
|
_LIBCPP_HIDE_FROM_ABI _Tp transform_reduce(
|
|
_ExecutionPolicy&& __policy,
|
|
_ForwardIterator __first,
|
|
_ForwardIterator __last,
|
|
_Tp __init,
|
|
_BinaryOperation __reduce,
|
|
_UnaryOperation __transform) {
|
|
auto __res = std::__transform_reduce(
|
|
__policy, std::move(__first), std::move(__last), std::move(__init), std::move(__reduce), std::move(__transform));
|
|
if (!__res)
|
|
std::__throw_bad_alloc();
|
|
return *std::move(__res);
|
|
}
|
|
|
|
_LIBCPP_END_NAMESPACE_STD
|
|
|
|
#endif // !defined(_LIBCPP_HAS_NO_INCOMPLETE_PSTL) && _LIBCPP_STD_VER >= 17
|
|
|
|
_LIBCPP_POP_MACROS
|
|
|
|
#endif // _LIBCPP___NUMERIC_PSTL_TRANSFORM_REDUCE_H
|