mirror of
https://github.com/capstone-engine/llvm-capstone.git
synced 2024-12-02 10:49:22 +00:00
0f1c1be196
We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
59 lines
2.4 KiB
Objective-C
59 lines
2.4 KiB
Objective-C
// RUN: %clang_cc1 -fsyntax-only -fobjc-arc -verify %s
|
|
|
|
#if __has_feature(arc_cf_code_audited)
|
|
char _global[-1]; // expected-error {{declared as an array with a negative size}}
|
|
#endif
|
|
|
|
typedef const void *CFTypeRef;
|
|
CFTypeRef CFBridgingRetain(id X);
|
|
id CFBridgingRelease(CFTypeRef);
|
|
typedef const struct __CFString *CFStringRef;
|
|
|
|
extern CFStringRef CFMakeString0(void);
|
|
#pragma clang arc_cf_code_audited begin
|
|
extern CFStringRef CFCreateString0(void);
|
|
#pragma clang arc_cf_code_audited end
|
|
void test0(void) {
|
|
id x;
|
|
x = (id) CFMakeString0(); // expected-error {{requires a bridged cast}} expected-note {{__bridge to convert directly}} expected-note {{CFBridgingRelease call to transfer}}
|
|
x = (id) CFCreateString0(); // expected-error {{requires a bridged cast}} expected-note {{CFBridgingRelease call to transfer}}
|
|
}
|
|
|
|
extern CFStringRef CFMakeString1(void) __attribute__((cf_returns_not_retained));
|
|
extern CFStringRef CFCreateString1(void) __attribute__((cf_returns_retained));
|
|
void test1(void) {
|
|
id x;
|
|
x = (id) CFMakeString1();
|
|
x = (id) CFCreateString1(); // expected-error {{requires a bridged cast}} expected-note {{CFBridgingRelease call to transfer}}
|
|
}
|
|
|
|
#define CF_AUDIT_BEGIN _Pragma("clang arc_cf_code_audited begin")
|
|
#define CF_AUDIT_END _Pragma("clang arc_cf_code_audited end")
|
|
#define CF_RETURNS_RETAINED __attribute__((cf_returns_retained))
|
|
#define CF_RETURNS_NOT_RETAINED __attribute__((cf_returns_not_retained))
|
|
|
|
CF_AUDIT_BEGIN
|
|
extern CFStringRef CFMakeString2(void);
|
|
extern CFStringRef CFCreateString2(void) CF_RETURNS_NOT_RETAINED;
|
|
extern CFStringRef CFMakeString3(void) CF_RETURNS_RETAINED;
|
|
extern CFStringRef CFCreateString3(void);
|
|
CF_AUDIT_END
|
|
void test2(void) {
|
|
id x;
|
|
x = (id) CFMakeString2();
|
|
x = (id) CFCreateString2();
|
|
x = (id) CFMakeString3(); // expected-error {{requires a bridged cast}} expected-note {{CFBridgingRelease call to transfer}}
|
|
x = (id) CFCreateString3(); // expected-error {{requires a bridged cast}} expected-note {{CFBridgingRelease call to transfer}}
|
|
}
|
|
|
|
@interface NSString @end
|
|
typedef signed int SInt32;
|
|
#pragma clang arc_cf_code_audited begin
|
|
extern SInt32 CFStringGetIntValue(CFStringRef str); // expected-note {{passing argument to parameter 'str' here}}
|
|
#pragma clang arc_cf_code_audited end
|
|
|
|
void test3(void) {
|
|
NSString* answer = @"42";
|
|
int ans = CFStringGetIntValue(answer); // expected-error {{incompatible pointer types passing retainable parameter of type 'NSString *__strong'to a CF function expecting 'CFStringRef'}}
|
|
}
|