mirror of
https://github.com/capstone-engine/llvm-capstone.git
synced 2025-01-08 00:52:54 +00:00
5565941eff
Specifically, this warns when a character literal is added (using '+') to a variable with type 'char *' (or any other pointer to character type). Like -Wstring-plus-int, there is a fix-it to change "foo + 'a'" to "&foo['a']" iff the character literal is on the right side of the string. Patch by Anders Rönnholm! llvm-svn: 193418
33 lines
1.6 KiB
C++
33 lines
1.6 KiB
C++
// RUN: %clang_cc1 -fsyntax-only -std=c++11 -verify %s
|
|
|
|
class A {
|
|
public:
|
|
A(): str() { }
|
|
A(const char *p) { }
|
|
A(char *p) : str(p + 'a') { } // expected-warning {{adding 'char' to a string pointer does not append to the string}} expected-note {{use array indexing to silence this warning}}
|
|
A& operator+(const char *p) { return *this; }
|
|
A& operator+(char ch) { return *this; }
|
|
char * str;
|
|
};
|
|
|
|
void f(const char *s) {
|
|
A a = s + 'a'; // // expected-warning {{adding 'char' to a string pointer does not append to the string}} expected-note {{use array indexing to silence this warning}}
|
|
a = a + s + 'b'; // no-warning
|
|
|
|
char *str = 0;
|
|
char *str2 = str + 'c'; // expected-warning {{adding 'char' to a string pointer does not append to the string}} expected-note {{use array indexing to silence this warning}}
|
|
|
|
const char *constStr = s + 'c'; // expected-warning {{adding 'char' to a string pointer does not append to the string}} expected-note {{use array indexing to silence this warning}}
|
|
|
|
str = 'c' + str;// expected-warning {{adding 'char' to a string pointer does not append to the string}} expected-note {{use array indexing to silence this warning}}
|
|
|
|
wchar_t *wstr;
|
|
wstr = wstr + L'c'; // expected-warning {{adding 'wchar_t' to a string pointer does not append to the string}} expected-note {{use array indexing to silence this warning}}
|
|
str2 = str + u'a'; // expected-warning {{adding 'char16_t' to a string pointer does not append to the string}} expected-note {{use array indexing to silence this warning}}
|
|
|
|
// no-warning
|
|
char c = 'c';
|
|
str = str + c;
|
|
str = c + str;
|
|
}
|