mirror of
https://github.com/capstone-engine/llvm-capstone.git
synced 2025-04-17 13:51:21 +00:00

'#pragma pack (pop)' and suspicious uses of '#pragma pack' in included files The second recommit (r309106) was reverted because the "non-default #pragma pack value chages the alignment of struct or union members in the included file" warning proved to be too aggressive for external projects like Chromium (https://bugs.chromium.org/p/chromium/issues/detail?id=749197). This recommit makes the problematic warning a non-default one, and gives it the -Wpragma-pack-suspicious-include warning option. The first recommit (r308441) caused a "non-default #pragma pack value might change the alignment of struct or union members in the included file" warning in LLVM itself. This recommit tweaks the added warning to avoid warnings for #includes that don't have any records that are affected by the non-default alignment. This tweak avoids the previously emitted warning in LLVM. Original message: This commit adds a new -Wpragma-pack warning. It warns in the following cases: - When a translation unit is missing terminating #pragma pack (pop) directives. - When entering an included file if the current alignment value as determined by '#pragma pack' directives is different from the default alignment value. - When leaving an included file that changed the state of the current alignment value. rdar://10184173 Differential Revision: https://reviews.llvm.org/D35484 llvm-svn: 309386
35 lines
1.2 KiB
C
35 lines
1.2 KiB
C
// RUN: %clang_cc1 -triple i386-apple-darwin9 -Wno-pragma-pack -fsyntax-only -verify %s
|
|
|
|
/* expected-warning {{expected 'align' following '#pragma options'}} */ #pragma options
|
|
/* expected-warning {{expected '=' following '#pragma options align'}} */ #pragma options align
|
|
/* expected-warning {{expected identifier in '#pragma options'}} */ #pragma options align =
|
|
/* expected-warning {{invalid alignment option in '#pragma options align'}} */ #pragma options align = foo
|
|
/* expected-warning {{extra tokens at end of '#pragma options'}} */ #pragma options align = reset foo
|
|
|
|
#pragma options align=natural
|
|
#pragma options align=reset
|
|
#pragma options align=mac68k
|
|
#pragma options align=power
|
|
|
|
/* expected-warning {{expected '=' following '#pragma align'}} */ #pragma align
|
|
/* expected-warning {{expected identifier in '#pragma align'}} */ #pragma align =
|
|
/* expected-warning {{invalid alignment option in '#pragma align'}} */ #pragma align = foo
|
|
/* expected-warning {{extra tokens at end of '#pragma align'}} */ #pragma align = reset foo
|
|
|
|
#pragma align=natural
|
|
#pragma align=reset
|
|
#pragma align=mac68k
|
|
#pragma align=power
|
|
|
|
// PR13580
|
|
struct S
|
|
{
|
|
char a[3];
|
|
#pragma align=packed
|
|
struct T
|
|
{
|
|
char b;
|
|
int c;
|
|
} d;
|
|
};
|