mirror of
https://github.com/capstone-engine/llvm-capstone.git
synced 2025-04-12 19:38:50 +00:00
42179bbf6b
While clang warns about a possibly incomplete switch statement when switching over an enum variable and failing to cover all enum values (either explicitly or with a default case), no such warning is emitted if a plain integer variable is used as switch variable. Add a clang-tidy check to diagnose these scenarios. No fixit hint is provided since there are multiple possible solutions. Differential Revision: https://reviews.llvm.org/D4784
48 lines
1.5 KiB
C++
48 lines
1.5 KiB
C++
//===--- SwitchMissingDefaultCaseCheck.cpp - clang-tidy -------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "SwitchMissingDefaultCaseCheck.h"
|
|
#include "clang/AST/ASTContext.h"
|
|
|
|
using namespace clang::ast_matchers;
|
|
|
|
namespace clang::tidy::bugprone {
|
|
|
|
namespace {
|
|
|
|
AST_MATCHER(SwitchStmt, hasDefaultCase) {
|
|
const SwitchCase *Case = Node.getSwitchCaseList();
|
|
while (Case) {
|
|
if (DefaultStmt::classof(Case))
|
|
return true;
|
|
|
|
Case = Case->getNextSwitchCase();
|
|
}
|
|
return false;
|
|
}
|
|
} // namespace
|
|
|
|
void SwitchMissingDefaultCaseCheck::registerMatchers(MatchFinder *Finder) {
|
|
Finder->addMatcher(
|
|
switchStmt(hasCondition(expr(unless(isInstantiationDependent()),
|
|
hasType(qualType(hasCanonicalType(
|
|
unless(hasDeclaration(enumDecl()))))))),
|
|
unless(hasDefaultCase()))
|
|
.bind("switch"),
|
|
this);
|
|
}
|
|
|
|
void SwitchMissingDefaultCaseCheck::check(
|
|
const ast_matchers::MatchFinder::MatchResult &Result) {
|
|
const auto *Switch = Result.Nodes.getNodeAs<SwitchStmt>("switch");
|
|
|
|
diag(Switch->getSwitchLoc(), "switching on non-enum value without "
|
|
"default case may not cover all cases");
|
|
}
|
|
} // namespace clang::tidy::bugprone
|