llvm-capstone/flang
Jean Perier 47995a0ec9 [flang] catch implicit interface incompatibility with global scope symbol
Previously, when calling a procedure implicitly for which a global scope
procedure symbol with the same name existed, semantics resolved the
procedure name in the call to the global symbol without checking that
the symbol interface was compatible with the implicit interface of the
call.
This could cause expression rewrite and lowering to later badly process
the implicit call assuming a different result type or an explicit
interface. This could lead to lowering crash in case the actual argument
were incompatible with the dummies from the explicit interface.

Emit errors in the following problematic cases:
- If the result type from the symbol did not match the one from the
  implicit interface.
- If the symbol requires an explicit interface.

This patch still allows calling an F77 like procedure with different
actual argument types than the one it was defined with because it is
correctly supported in lowering and is a feature in some program
(it is a pointer cast). The two cases that won't be accepted have
little chance to make much sense. Results returning ABIs may differ
depending on the return types, and function that requires explicit
interface usually requires descriptors or specific processing that
is incompatible with implicit interfaces.

Note that this patch is not making a deep analysis, and it will only
catch mistakes if a global symbol and an implicit interface are
involved. Cases where the user provided a conflicting explicit
interface would still require a pass after name resolution to study
conflicts more deeply. But these cases will not crash lowering or
trigger expression rewrite to do weird things.

Differential Revision: https://reviews.llvm.org/D119274
2022-02-09 09:30:32 +01:00
..
cmake/modules [CMake] Factor out config prefix finding logic 2022-01-07 20:16:18 +00:00
docs [fir] Add array operations documentation 2022-01-21 09:56:54 +01:00
examples [flang][examples] Add missing CMake dependencies 2022-01-24 09:34:46 +00:00
include [flang] Upstream partial lowering of GET_ENVIRONMENT_VARIABLE intrinsic 2022-02-08 17:42:53 +00:00
lib [flang] catch implicit interface incompatibility with global scope symbol 2022-02-09 09:30:32 +01:00
module Add ieee_is_normal/ieee_is_negative to ieee_arithmetic module. 2022-01-26 11:33:23 +03:00
runtime [flang] Debugging of ACCESS='STREAM' I/O (take 2) 2022-02-04 18:02:34 -08:00
test [flang] catch implicit interface incompatibility with global scope symbol 2022-02-09 09:30:32 +01:00
tools [mlir] Split out a new ControlFlow dialect from Standard 2022-02-06 14:51:16 -08:00
unittests [flang] Upstream partial lowering of GET_ENVIRONMENT_VARIABLE intrinsic 2022-02-08 17:42:53 +00:00
.clang-format
.clang-tidy [flang] Add clang-tidy check for braces around if 2021-06-16 09:13:53 +00:00
.drone.star
.gitignore
CMakeLists.txt [cmake] Make include(GNUInstallDirs) always below project(..) 2022-01-20 18:59:17 +00:00
CODE_OWNERS.TXT
LICENSE.TXT Rename top-level LICENSE.txt files to LICENSE.TXT 2021-03-10 21:26:24 -08:00
README.md [flang][nfc] Update README.md 2022-01-13 10:28:41 +00:00

Flang

Flang is a ground-up implementation of a Fortran front end written in modern C++. It started off as the f18 project (https://github.com/flang-compiler/f18) with an aim to replace the previous flang project (https://github.com/flang-compiler/flang) and address its various deficiencies. F18 was subsequently accepted into the LLVM project and rechristened as Flang.

Getting Started

Read more about flang in the docs directory. Start with the compiler overview.

To better understand Fortran as a language and the specific grammar accepted by flang, read Fortran For C Programmers and flang's specifications of the Fortran grammar and the OpenMP grammar.

Treatment of language extensions is covered in this document.

To understand the compilers handling of intrinsics, see the discussion of intrinsics.

To understand how a flang program communicates with libraries at runtime, see the discussion of runtime descriptors.

If you're interested in contributing to the compiler, read the style guide and also review how flang uses modern C++ features.

If you are interested in writing new documentation, follow markdown style guide from LLVM.

Building flang

There are two ways to build flang. The first method is to build it at the same time that you build all of the projects on which it depends. This is called building in tree. The second method is to first do an in tree build to create all of the projects on which flang depends, and then only build the flang code itself. This is called building standalone. Building standalone has the advantage of being smaller and faster. Once you create the base build and base install areas, you can create multiple standalone builds using them.

Note that instructions for building LLVM can be found at https://llvm.org/docs/GettingStarted.html.

Building flang in tree

Building flang in tree means building flang along with all of the projects on which it depends. These projects include mlir, clang, flang, and compiler-rt. Note that compiler-rt is only needed to access libraries that support 16 bit floating point numbers. It's not needed to run the automated tests.

Here's a complete set of commands to clone all of the necessary source and do the build.

First clone the source:

git clone https://github.com/llvm/llvm-project.git my-project

Once the clone is complete, execute the following commands:

cd my-project

rm -rf build
mkdir -p build

cd build

cmake \
  -G Ninja \
  ../llvm \
  -DCMAKE_BUILD_TYPE=Release \
  -DFLANG_ENABLE_WERROR=On \
  -DLLVM_ENABLE_ASSERTIONS=ON \
  -DLLVM_TARGETS_TO_BUILD=host \
  -DCMAKE_INSTALL_PREFIX=$INSTALLDIR
  -DLLVM_LIT_ARGS=-v \
  -DLLVM_ENABLE_PROJECTS="clang;mlir;flang;compiler-rt"

ninja

To run the flang tests on this build, execute the command in the "build" directory:

ninja check-flang

Note that these instructions specify flang as one of the projects to build in the in tree build. This is not strictly necessary for subsequent standalone builds, but doing so lets you run the flang tests to verify that the source code is in good shape.

Building flang standalone

To do the standalone build, start by building flang in tree as described above. This build is base build for subsequent standalone builds. Start each standalone build the same way by cloning the source for llvm-project:

git clone https://github.com/llvm/llvm-project.git standalone

Once the clone is complete, execute the following commands:

cd standalone
base=<directory that contains the in tree build>

cd flang
rm -rf build
mkdir build
cd build

cmake \
  -G Ninja \
  -DCMAKE_BUILD_TYPE=Release \
  -DFLANG_ENABLE_WERROR=On \
  -DLLVM_TARGETS_TO_BUILD=host \
  -DLLVM_ENABLE_ASSERTIONS=On \
  -DLLVM_BUILD_MAIN_SRC_DIR=$base/build/lib/cmake/llvm \
  -DLLVM_LIT_ARGS=-v \
  -DLLVM_DIR=$base/build/lib/cmake/llvm \
  -DCLANG_DIR=$base/build/lib/cmake/clang \
  -DMLIR_DIR=$base/build/lib/cmake/mlir \
  ..

ninja

To run the flang tests on this build, execute the command in the "flang/build" directory:

ninja check-flang

Supported C++ compilers

Flang is written in C++17.

The code has been compiled and tested with GCC versions from 7.2.0 to 9.3.0.

The code has been compiled and tested with clang version 7.0, 8.0, 9.0 and 10.0 using either GNU's libstdc++ or LLVM's libc++.

The code has been compiled on AArch64, x86_64 and ppc64le servers with CentOS7, Ubuntu18.04, Rhel, MacOs, Mojave, XCode and Apple Clang version 10.0.1.

The code does not compile with Windows and a compiler that does not have support for C++17.

Building flang with GCC

By default, cmake will search for g++ on your PATH. The g++ version must be one of the supported versions in order to build flang.

Or, cmake will use the variable CXX to find the C++ compiler. CXX should include the full path to the compiler or a name that will be found on your PATH, e.g. g++-8.3, assuming g++-8.3 is on your PATH.

export CXX=g++-8.3

or

CXX=/opt/gcc-8.3/bin/g++-8.3 cmake ...

Building flang with clang

To build flang with clang, cmake needs to know how to find clang++ and the GCC library and tools that were used to build clang++.

CXX should include the full path to clang++ or clang++ should be found on your PATH.

export CXX=clang++

Installation Directory

To specify a custom install location, add -DCMAKE_INSTALL_PREFIX=<INSTALL_PREFIX> to the cmake command where <INSTALL_PREFIX> is the path where flang should be installed.

Build Types

To create a debug build, add -DCMAKE_BUILD_TYPE=Debug to the cmake command. Debug builds execute slowly.

To create a release build, add -DCMAKE_BUILD_TYPE=Release to the cmake command. Release builds execute quickly.

How to Run Tests

Flang supports 2 different categories of tests

  1. Regression tests (https://www.llvm.org/docs/TestingGuide.html#regression-tests)
  2. Unit tests (https://www.llvm.org/docs/TestingGuide.html#unit-tests)

For standalone builds

To run all tests:

cd ~/flang/build
cmake -DLLVM_DIR=$LLVM -DMLIR_DIR=$MLIR ~/flang/src
ninja check-all

To run individual regression tests llvm-lit needs to know the lit configuration for flang. The parameters in charge of this are: flang_site_config and flang_config. And they can be set as shown below:

<path-to-llvm-lit>/llvm-lit \
 --param flang_site_config=<path-to-flang-build>/test-lit/lit.site.cfg.py \
 --param flang_config=<path-to-flang-build>/test-lit/lit.cfg.py \
  <path-to-fortran-test>

Unit tests:

If flang was built with -DFLANG_INCLUDE_TESTS=On (ON by default), it is possible to generate unittests. Note: Unit-tests will be skipped for LLVM install for an standalone build as it does not include googletest related headers and libraries.

There are various ways to run unit-tests.


1. ninja check-flang-unit
2. ninja check-all or ninja check-flang
3. <path-to-llvm-lit>/llvm-lit \
        test/Unit
4. Invoking tests from <standalone flang build>/unittests/<respective unit test folder>

For in tree builds

If flang was built with -DFLANG_INCLUDE_TESTS=On (On by default), it is possible to generate unittests.

To run all of the flang unit tests use the check-flang-unit target:

ninja check-flang-unit

To run all of the flang regression tests use the check-flang target:

ninja check-flang

How to Generate Documentation

Generate FIR Documentation

If flang was built with -DLINK_WITH_FIR=On (On by default), it is possible to generate FIR language documentation by running ninja flang-doc. This will create docs/Dialect/FIRLangRef.md in flang build directory.

Generate Doxygen-based Documentation

To generate doxygen-style documentation from source code

  • Pass -DLLVM_ENABLE_DOXYGEN=ON -DFLANG_INCLUDE_DOCS=ON to the cmake command.
cd ~/llvm-project/build
cmake -DLLVM_ENABLE_DOXYGEN=ON -DFLANG_INCLUDE_DOCS=ON ../llvm
ninja doxygen-flang

It will generate html in

    <build-dir>/tools/flang/docs/doxygen/html # for flang docs

Generate Sphinx-based Documentation

Flang documentation should preferably be written in markdown(.md) syntax (they can be in reStructuredText(.rst) format as well but markdown is recommended in first place), it is mostly meant to be processed by the Sphinx documentation generation system to create HTML pages which would be hosted on the webpage of flang and updated periodically.

If you would like to generate and view the HTML locally:

  • Install Sphinx, including the sphinx-markdown-tables extension.
  • Pass -DLLVM_ENABLE_SPHINX=ON -DSPHINX_WARNINGS_AS_ERRORS=OFF to the cmake command.
cd ~/llvm-project/build
cmake -DLLVM_ENABLE_SPHINX=ON -DSPHINX_WARNINGS_AS_ERRORS=OFF ../llvm
ninja docs-flang-html

It will generate html in

   $BROWSER <build-dir>/tools/flang/docs/html/