mirror of
https://github.com/capstone-engine/llvm-capstone.git
synced 2025-03-04 00:20:14 +00:00
30680e9437
Allow Obj-C ivars with incomplete array type but only as the last ivar. Also add a requirement for ivars that contain a flexible array member to be at the end of class too. It is possible to add in a subclass another ivar at the end but we'll emit a warning in this case. Also we'll emit a warning if a variable sized ivar is declared in class extension or in implementation because subclasses won't know they should avoid adding new ivars. In ARC incomplete array objects are treated as __unsafe_unretained so require them to be marked as such. Prohibit synthesizing ivars with flexible array members because order of synthesized ivars is not obvious and tricky to control. Spelling out ivar explicitly gives control to developers and helps to avoid surprises with unexpected ivar ordering. For C and C++ changed diagnostic to tell explicitly a field is not the last one and point to the next field. It is not as useful as in Obj-C but it is an improvement and it is consistent with Obj-C. For C for unions emit more specific err_flexible_array_union instead of generic err_field_incomplete. rdar://problem/21054495 Reviewers: rjmccall, theraven Reviewed By: rjmccall Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D38773 llvm-svn: 316381
102 lines
1.9 KiB
C++
102 lines
1.9 KiB
C++
// RUN: %clang_cc1 -fsyntax-only -verify %s
|
|
// pr7029
|
|
|
|
template <class Key, class T> struct QMap
|
|
{
|
|
void insert(const Key &, const T &);
|
|
T v;
|
|
};
|
|
|
|
|
|
template <class Key, class T>
|
|
void QMap<Key, T>::insert(const Key &, const T &avalue)
|
|
{
|
|
v = avalue;
|
|
}
|
|
|
|
struct Rec {
|
|
union { // expected-warning-re {{variable sized type '{{.*}}' not at the end of a struct or class is a GNU extension}}
|
|
int u0[];
|
|
};
|
|
int x;
|
|
} rec;
|
|
|
|
struct inotify_event
|
|
{
|
|
int wd;
|
|
|
|
// clang doesn't like '[]':
|
|
// cannot initialize a parameter of type 'void *' with an rvalue of type 'char (*)[]'
|
|
char name [];
|
|
};
|
|
|
|
|
|
void foo()
|
|
{
|
|
inotify_event event;
|
|
inotify_event* ptr = &event;
|
|
inotify_event event1 = *ptr;
|
|
*ptr = event;
|
|
QMap<int, inotify_event> eventForId;
|
|
eventForId.insert(ptr->wd, *ptr);
|
|
}
|
|
|
|
struct S {
|
|
virtual void foo();
|
|
};
|
|
|
|
struct X {
|
|
int blah;
|
|
S strings[];
|
|
};
|
|
|
|
S a, b = a;
|
|
S f(X &x) {
|
|
a = b;
|
|
return x.strings[0];
|
|
}
|
|
|
|
class A {
|
|
int s;
|
|
char c[];
|
|
};
|
|
|
|
union B {
|
|
int s;
|
|
char c[];
|
|
};
|
|
|
|
class C {
|
|
char c[]; // expected-error {{flexible array member 'c' with type 'char []' is not at the end of class}}
|
|
int s; // expected-note {{next field declaration is here}}
|
|
};
|
|
|
|
namespace rdar9065507 {
|
|
|
|
struct StorageBase {
|
|
long ref_count;
|
|
unsigned size;
|
|
unsigned capacity;
|
|
};
|
|
|
|
struct Storage : StorageBase {
|
|
int data[];
|
|
};
|
|
|
|
struct VirtStorage : virtual StorageBase {
|
|
int data[]; // expected-error {{flexible array member 'data' not allowed in struct which has a virtual base class}}
|
|
};
|
|
|
|
}
|
|
|
|
struct NonTrivDtor { ~NonTrivDtor(); };
|
|
// FIXME: It's not clear whether we should disallow examples like this. GCC accepts.
|
|
struct FlexNonTrivDtor {
|
|
int n;
|
|
NonTrivDtor ntd[]; // expected-error {{flexible array member 'ntd' of type 'NonTrivDtor []' with non-trivial destruction}}
|
|
~FlexNonTrivDtor() {
|
|
for (int i = n; i != 0; --i)
|
|
ntd[i-1].~NonTrivDtor();
|
|
}
|
|
};
|