mirror of
https://github.com/capstone-engine/llvm-capstone.git
synced 2024-12-14 19:49:36 +00:00
bbc6d68297
It's an old bug that consists in stale references to symbols remaining in the
GDM if they disappear from other program state sections as a result of any
operation that isn't the actual dead symbol collection. The most common example
here is:
FILE *fp = fopen("myfile.txt", "w");
fp = 0; // leak of file descriptor
In this example the leak were not detected previously because the symbol
disappears from the public part of the program state due to evaluating
the assignment. For that reason the checker never receives a notification
that the symbol is dead, and never reports a leak.
This patch not only causes leak false negatives, but also a number of other
problems, including false positives on some checkers.
What's worse, even though the program state contains a finite number of symbols,
the set of symbols that dies is potentially infinite. This means that is
impossible to compute the set of all dead symbols to pass off to the checkers
for cleaning up their part of the GDM.
No longer compute the dead set at all. Disallow iterating over dead symbols.
Disallow querying if any symbols are dead. Remove the API for marking symbols
as dead, as it is no longer necessary. Update checkers accordingly.
Differential Revision: https://reviews.llvm.org/D18860
llvm-svn: 347953
27 lines
550 B
C
27 lines
550 B
C
// RUN: %clang_analyze_cc1 -analyzer-checker=core,debug.ExprInspection -verify %s
|
|
|
|
void clang_analyzer_eval(int);
|
|
|
|
void callee(void **p) {
|
|
int x;
|
|
*p = &x;
|
|
}
|
|
|
|
void loop() {
|
|
void *arr[2];
|
|
for (int i = 0; i < 2; ++i)
|
|
callee(&arr[i]);
|
|
// FIXME: Should be UNKNOWN.
|
|
clang_analyzer_eval(arr[0] == arr[1]); // expected-warning{{TRUE}}
|
|
}
|
|
|
|
void loopWithCall() {
|
|
void *arr[2];
|
|
for (int i = 0; i < 2; ++i) {
|
|
int x;
|
|
arr[i] = &x;
|
|
}
|
|
// FIXME: Should be UNKNOWN.
|
|
clang_analyzer_eval(arr[0] == arr[1]); // expected-warning{{TRUE}}
|
|
}
|