llvm-capstone/clang/test/Analysis/ivars.m
Balazs Benics ffe7950ebc Reland "[analyzer] Deprecate -analyzer-store region flag"
I'm trying to remove unused options from the `Analyses.def` file, then
merge the rest of the useful options into the `AnalyzerOptions.def`.
Then make sure one can set these by an `-analyzer-config XXX=YYY` style
flag.
Then surface the `-analyzer-config` to the `clang` frontend;

After all of this, we can pursue the tablegen approach described
https://discourse.llvm.org/t/rfc-tablegen-clang-static-analyzer-engine-options-for-better-documentation/61488

In this patch, I'm proposing flag deprecations.
We should support deprecated analyzer flags for exactly one release. In
this case I'm planning to drop this flag in `clang-16`.

In the clang frontend, now we won't pass this option to the cc1
frontend, rather emit a warning diagnostic reminding the users about
this deprecated flag, which will be turned into error in clang-16.

Unfortunately, I had to remove all the tests referring to this flag,
causing a mass change. I've also added a test for checking this warning.

I've seen that `scan-build` also uses this flag, but I think we should
remove that part only after we turn this into a hard error.

Reviewed By: martong

Differential Revision: https://reviews.llvm.org/D126215
2022-06-14 09:20:41 +02:00

141 lines
3.8 KiB
Objective-C

// RUN: %clang_analyze_cc1 -analyzer-checker=core,debug.ExprInspection -fblocks -verify -Wno-objc-root-class -analyzer-config eagerly-assume=false %s
void clang_analyzer_eval(int);
@interface Root {
@public
int uniqueID;
}
- (void)refreshID;
@end
void testInvalidation(Root *obj) {
int savedID = obj->uniqueID;
clang_analyzer_eval(savedID == obj->uniqueID); // expected-warning{{TRUE}}
[obj refreshID];
clang_analyzer_eval(savedID == obj->uniqueID); // expected-warning{{UNKNOWN}}
}
@interface Child : Root
@end
@implementation Child
- (void)testSuperInvalidation {
int savedID = self->uniqueID;
clang_analyzer_eval(savedID == self->uniqueID); // expected-warning{{TRUE}}
[super refreshID];
clang_analyzer_eval(savedID == self->uniqueID); // expected-warning{{UNKNOWN}}
}
@end
@interface ManyIvars {
struct S { int a, b; } s;
int c;
int d;
}
@end
struct S makeS(void);
@implementation ManyIvars
- (void)testMultipleIvarInvalidation:(int)useConstraints {
if (useConstraints) {
if (s.a != 1) return;
if (s.b != 2) return;
if (c != 3) return;
if (d != 4) return;
return;
} else {
s.a = 1;
s.b = 2;
c = 3;
d = 4;
}
clang_analyzer_eval(s.a == 1); // expected-warning{{TRUE}}
clang_analyzer_eval(s.b == 2); // expected-warning{{TRUE}}
clang_analyzer_eval(c == 3); // expected-warning{{TRUE}}
clang_analyzer_eval(d == 4); // expected-warning{{TRUE}}
d = 0;
clang_analyzer_eval(s.a == 1); // expected-warning{{TRUE}}
clang_analyzer_eval(s.b == 2); // expected-warning{{TRUE}}
clang_analyzer_eval(c == 3); // expected-warning{{TRUE}}
clang_analyzer_eval(d == 0); // expected-warning{{TRUE}}
d = 4;
s = makeS();
clang_analyzer_eval(s.a == 1); // expected-warning{{UNKNOWN}}
clang_analyzer_eval(s.b == 2); // expected-warning{{UNKNOWN}}
clang_analyzer_eval(c == 3); // expected-warning{{TRUE}}
clang_analyzer_eval(d == 4); // expected-warning{{TRUE}}
s.a = 1;
clang_analyzer_eval(s.a == 1); // expected-warning{{TRUE}}
clang_analyzer_eval(s.b == 2); // expected-warning{{UNKNOWN}}
clang_analyzer_eval(c == 3); // expected-warning{{TRUE}}
clang_analyzer_eval(d == 4); // expected-warning{{TRUE}}
}
+ (void)testMultipleIvarInvalidation:(int)useConstraints
forObject:(ManyIvars *)obj {
if (useConstraints) {
if (obj->s.a != 1) return;
if (obj->s.b != 2) return;
if (obj->c != 3) return;
if (obj->d != 4) return;
return;
} else {
obj->s.a = 1;
obj->s.b = 2;
obj->c = 3;
obj->d = 4;
}
clang_analyzer_eval(obj->s.a == 1); // expected-warning{{TRUE}}
clang_analyzer_eval(obj->s.b == 2); // expected-warning{{TRUE}}
clang_analyzer_eval(obj->c == 3); // expected-warning{{TRUE}}
clang_analyzer_eval(obj->d == 4); // expected-warning{{TRUE}}
obj->d = 0;
clang_analyzer_eval(obj->s.a == 1); // expected-warning{{TRUE}}
clang_analyzer_eval(obj->s.b == 2); // expected-warning{{TRUE}}
clang_analyzer_eval(obj->c == 3); // expected-warning{{TRUE}}
clang_analyzer_eval(obj->d == 0); // expected-warning{{TRUE}}
obj->d = 4;
obj->s = makeS();
clang_analyzer_eval(obj->s.a == 1); // expected-warning{{UNKNOWN}}
clang_analyzer_eval(obj->s.b == 2); // expected-warning{{UNKNOWN}}
clang_analyzer_eval(obj->c == 3); // expected-warning{{TRUE}}
clang_analyzer_eval(obj->d == 4); // expected-warning{{TRUE}}
obj->s.a = 1;
clang_analyzer_eval(obj->s.a == 1); // expected-warning{{TRUE}}
clang_analyzer_eval(obj->s.b == 2); // expected-warning{{UNKNOWN}}
clang_analyzer_eval(obj->c == 3); // expected-warning{{TRUE}}
clang_analyzer_eval(obj->d == 4); // expected-warning{{TRUE}}
}
@end
int testNull(Root *obj) {
if (obj) return 0;
int *x = &obj->uniqueID;
return *x; // expected-warning{{Dereference of null pointer (loaded from variable 'x')}}
}