llvm with tablegen backend for capstone disassembler
Go to file
Duncan Sands 7b90966d4a Rather than giving SmallPtrSetImpl a member field SmallArray which is magically
replaced by a bigger array in SmallPtrSet (by overridding it), instead just use a
pointer to the start of the storage, and have SmallPtrSet pass in the value to use.
This has the disadvantage that SmallPtrSet becomes bigger by one pointer.  It has
the advantage that it no longer uses tricky C++ rules, and is clearly correct while
I'm not sure the previous version was.  This was inspired by g++-4.6 pointing out
that SmallPtrSetImpl was writing off the end of SmallArray, which it was.  Since
SmallArray is replaced with a bigger array in SmallPtrSet, the write was still to
valid memory.  But it was writing off the end of the declared array type - sounds
kind of dubious to me, like it sounded dubious to g++-4.6.  Maybe g++-4.6 is wrong
and this construct is perfectly valid and correctly compiled by all compilers, but
I think it is better to avoid the whole can of worms by avoiding this construct.

llvm-svn: 107285
2010-06-30 15:02:37 +00:00
clang Fix rdar://8139785 "implement warning on dead expression in comma operator" 2010-06-30 10:53:14 +00:00
compiler-rt This is a test commit to verify repository access. 2010-06-19 04:34:50 +00:00
libcxx two steps forward, one step back... 2010-06-30 00:21:42 +00:00
lldb Fix an obvious typo and replace deprecated bcopy(3) with memcpy(3). 2010-06-30 13:43:47 +00:00
llvm Rather than giving SmallPtrSetImpl a member field SmallArray which is magically 2010-06-30 15:02:37 +00:00