mirror of
https://github.com/capstone-engine/llvm-capstone.git
synced 2024-12-26 01:39:11 +00:00
bd44174547
Using -isystem marks the headers as system headers, which means that we don't actually get all the warnings that we'd normally get if we included the headers as user headers. The goal of the test suite is normally to mirror as closely as possible how users would use the library. Technically, this change goes against that philosophy, since users should be using `-isystem` (if they ever need to specify the libc++ path explicitly, which should be a rare occurence). However, I believe fishing out additional warnings from the headers provides more value, hence this change. Ideally, we'd be able to still use `-isystem`, but instruct Clang to still emit warnings from the libc++ headers (e.g. we could tell Clang to emit warnings in any file inside `<...>/usr/include/c++/v1`). Reviewed By: #libc, ldionne, #libc_abi Spies: Mordante, EricWF, mstorsjo, mgorny, aheejin, arichardson, philnik, jloser, libcxx-commits Differential Revision: https://reviews.llvm.org/D118616 |
||
---|---|---|
.. | ||
__hash | ||
hash_map | ||
hash_set |