mirror of
https://github.com/capstone-engine/llvm-capstone.git
synced 2024-11-23 13:50:11 +00:00
615e6dd1c5
We recently noticed that the unwrap_iter.h file was pushing macros, but
it was pushing them again instead of popping them at the end of the
file. This led to libc++ basically swallowing any custom definition of
these macros in user code:
#define min HELLO
#include <algorithm>
// min is not HELLO anymore, it's not defined
While investigating this issue, I noticed that our push/pop pragmas were
actually entirely wrong too. Indeed, instead of pushing macros like
`move`, we'd push `move(int, int)` in the pragma, which is not a valid
macro name. As a result, we would not actually push macros like `move`
-- instead we'd simply undefine them. This led to the following code not
working:
#define move HELLO
#include <algorithm>
// move is not HELLO anymore
Fixing the pragma push/pop incantations led to a cascade of issues
because we use identifiers like `move` in a large number of places, and
all of these headers would now need to do the push/pop dance.
This patch fixes all these issues. First, it adds a check that we don't
swallow important names like min, max, move or refresh as explained
above. This is done by augmenting the existing
system_reserved_names.gen.py test to also check that the macros are what
we expect after including each header.
Second, it fixes the push/pop pragmas to work properly and adds missing
pragmas to all the files I could detect a failure in via the newly added
test.
rdar://121365472
(cherry picked from commit 7b4622514d232ce5f7110dd8b20d90e81127c467)
|
||
|---|---|---|
| .. | ||
| buffer.h | ||
| concepts.h | ||
| container_adaptor.h | ||
| enable_insertable.h | ||
| escaped_output_table.h | ||
| extended_grapheme_cluster_table.h | ||
| format_arg_store.h | ||
| format_arg.h | ||
| format_args.h | ||
| format_context.h | ||
| format_error.h | ||
| format_functions.h | ||
| format_fwd.h | ||
| format_parse_context.h | ||
| format_string.h | ||
| format_to_n_result.h | ||
| formatter_bool.h | ||
| formatter_char.h | ||
| formatter_floating_point.h | ||
| formatter_integer.h | ||
| formatter_integral.h | ||
| formatter_output.h | ||
| formatter_pointer.h | ||
| formatter_string.h | ||
| formatter_tuple.h | ||
| formatter.h | ||
| parser_std_format_spec.h | ||
| range_default_formatter.h | ||
| range_formatter.h | ||
| unicode.h | ||
| width_estimation_table.h | ||
| write_escaped.h | ||