llvm-capstone/clang/tools
Serge Guelton be88539b85 Replace llvm::isPodLike<...> by llvm::is_trivially_copyable<...>
As noted in https://bugs.llvm.org/show_bug.cgi?id=36651, the specialization for
isPodLike<std::pair<...>> did not match the expectation of
std::is_trivially_copyable which makes the memcpy optimization invalid.

This patch renames the llvm::isPodLike trait into llvm::is_trivially_copyable.
Unfortunately std::is_trivially_copyable is not portable across compiler / STL
versions. So a portable version is provided too.

Note that the following specialization were invalid:

    std::pair<T0, T1>
    llvm::Optional<T>

Tests have been added to assert that former specialization are respected by the
standard usage of llvm::is_trivially_copyable, and that when a decent version
of std::is_trivially_copyable is available, llvm::is_trivially_copyable is
compared to std::is_trivially_copyable.

As of this patch, llvm::Optional is no longer considered trivially copyable,
even if T is. This is to be fixed in a later patch, as it has impact on a
long-running bug (see r347004)

Note that GCC warns about this UB, but this got silented by https://reviews.llvm.org/D50296.

Differential Revision: https://reviews.llvm.org/D54472

llvm-svn: 351701
2019-01-20 21:19:56 +00:00
..
arcmt-test Update the file headers across all of the LLVM projects in the monorepo 2019-01-19 08:50:56 +00:00
c-arcmt-test [CMake] Use PRIVATE in target_link_libraries for executables 2017-12-05 21:49:56 +00:00
c-index-test Update the file headers across all of the LLVM projects in the monorepo 2019-01-19 08:50:56 +00:00
clang-check Update the file headers across all of the LLVM projects in the monorepo 2019-01-19 08:50:56 +00:00
clang-diff Update the file headers across all of the LLVM projects in the monorepo 2019-01-19 08:50:56 +00:00
clang-extdef-mapping Update the file headers across all of the LLVM projects in the monorepo 2019-01-19 08:50:56 +00:00
clang-format Update the file headers across all of the LLVM projects in the monorepo 2019-01-19 08:50:56 +00:00
clang-format-vs Update the file headers across all of the LLVM projects in the monorepo 2019-01-19 08:50:56 +00:00
clang-fuzzer Update the file headers across all of the LLVM projects in the monorepo 2019-01-19 08:50:56 +00:00
clang-import-test Update the file headers across all of the LLVM projects in the monorepo 2019-01-19 08:50:56 +00:00
clang-offload-bundler Update the file headers across all of the LLVM projects in the monorepo 2019-01-19 08:50:56 +00:00
clang-refactor Update the file headers across all of the LLVM projects in the monorepo 2019-01-19 08:50:56 +00:00
clang-rename Update the file headers across all of the LLVM projects in the monorepo 2019-01-19 08:50:56 +00:00
diag-build
diagtool Update the file headers across all of the LLVM projects in the monorepo 2019-01-19 08:50:56 +00:00
driver Update the file headers across all of the LLVM projects in the monorepo 2019-01-19 08:50:56 +00:00
libclang Replace llvm::isPodLike<...> by llvm::is_trivially_copyable<...> 2019-01-20 21:19:56 +00:00
scan-build Update the license header in this man-page file. 2019-01-19 09:24:38 +00:00
scan-build-py Update the license mentioned in this documentation. 2019-01-19 11:48:15 +00:00
scan-view Portable Python script across Python version 2019-01-03 14:26:56 +00:00
CMakeLists.txt [analyzer][CrossTU][NFC] Generalize to external definitions instead of external functions 2019-01-10 17:44:04 +00:00