llvm-capstone/lldb
Raphael Isemann ff0102b32c [lldb] Remove modern-type-lookup
Summary:
As discussed on the mailing list [1] we have to make a decision for how to proceed with the modern-type-lookup.

This patch removes modern-type-lookup from LLDB. This just removes all the code behind the modern-type-lookup
setting but it does *not* remove any code from Clang (i.e., the ExternalASTMerger and the clang-import-test stay around
for now).

The motivation for this is that I don't think that the current approach of implementing modern-type-lookup
will work out. Especially creating a completely new lookup system behind some setting that is never turned on by anyone
and then one day make one big switch to the new system seems wrong. It doesn't fit into the way LLVM is developed and has
so far made the transition work much more complicated than it has to be.

A lot of the benefits that were supposed to come with the modern-type-lookup are related to having a better organization
in the way types move across LLDB and having less dependencies on unrelated LLDB code. By just looking at the current code (mostly
the ClangASTImporter) I think we can reach the same goals by just incrementally cleaning up, documenting, refactoring
and actually testing the existing code we have.

[1] http://lists.llvm.org/pipermail/lldb-dev/2019-December/015831.html

Reviewers: shafik, martong

Subscribers: rnkovacs, christof, arphaman, JDevlieghere, usaxena95, lldb-commits, friss

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D71562
2019-12-17 12:24:31 +01:00
..
cmake [lldb/CMake] Initialize LLDB_ENABLE_POSIX based on the UNIX variable. 2019-12-13 13:46:43 -08:00
docs [lldb/CMake] Rename LLDB_DISABLE_PYTHON to LLDB_ENABLE_PYTHON 2019-12-13 13:41:11 -08:00
examples
include/lldb [lldb] Remove modern-type-lookup 2019-12-17 12:24:31 +01:00
packages/Python/lldbsuite [lldb] Remove modern-type-lookup 2019-12-17 12:24:31 +01:00
resources
scripts [lldb/SWIG] Modulerize lldb.swig so parts of it can be reused. 2019-12-13 14:49:44 -08:00
source [lldb] Remove modern-type-lookup 2019-12-17 12:24:31 +01:00
test [lldb/CMake] Rename LLDB_DISABLE_PYTHON to LLDB_ENABLE_PYTHON 2019-12-13 13:41:11 -08:00
third_party/Python/module
tools [lldb/CMake] Rename LLDB_DISABLE_PYTHON to LLDB_ENABLE_PYTHON 2019-12-13 13:41:11 -08:00
unittests [lldb] Add unit test for ClangASTImporter 2019-12-16 12:43:55 +01:00
utils [lldb] Respect previously set values of LLDB_TABLEGEN_EXE 2019-12-16 14:31:42 -08:00
.arcconfig
.clang-format
.gitignore
CMakeLists.txt [lldb/CMake] Rename LLDB_DISABLE_PYTHON to LLDB_ENABLE_PYTHON 2019-12-13 13:41:11 -08:00
CODE_OWNERS.txt
LICENSE.TXT
use_lldb_suite_root.py