Nick Desaulniers 61e1c3d80d [Demangle] convert itaniumDemangle and nonMicrosoftDemangle to use std::string_view ...

D149104 converted llvm::demangle to use std::string_view. Enabling
"expensive checks" (via -DLLVM_ENABLE_EXPENSIVE_CHECKS=ON) causes
lld/test/wasm/why-extract.s to fail. The reason for this is obscure:

Reason #10007 why std::string_view is dangerous:
Consider the following pattern:

  std::string_view s = ...;
  const char *c = s.data();
  std::strlen(c);

Is c a NUL-terminated C style string? It depends; but if it's not then
it's not safe to call std::strlen on the std::string_view::data().
std::string_view::length() should be used instead.

Fixing this fixes the one lone test that caught this.

microsoftDemangle, rustDemangle, and dlangDemangle should get this same
treatment, too. I will do that next.

Reviewed By: MaskRay, efriedma

Differential Revision: https://reviews.llvm.org/D149675

2023-06-02 14:53:49 -07:00

..

CMakeLists.txt

[CMake] Cleanup deps

2023-04-17 00:38:49 +09:00

OptReport.cpp

[Demangle] convert itaniumDemangle and nonMicrosoftDemangle to use std::string_view

2023-06-02 14:53:49 -07:00