From 1d92509b1aa5a1a65062bc9f84db8875e5d3e3cf Mon Sep 17 00:00:00 2001 From: Armin Weihbold Date: Sun, 24 Dec 2023 12:18:07 +0100 Subject: [PATCH] Fix running arch/debug specific tests in r2r ##tests Mark failing tests as broken Mark tests that timeout as NORUN Include bits in testfolder names Update CI to upload results.json --- .github/workflows/ci.yml | 4 +++ binr/r2r/load.c | 2 +- binr/r2r/r2r.h | 6 ++++ .../{darwin-x64 => darwin-x86_64}/cmd_i | 0 .../cmd_interpreter | 0 .../archos/{darwin-x64 => darwin-x86_64}/http | 0 .../{linux-x64 => linux-x86_64}/.dbg_fork | 0 .../{linux-x64 => linux-x86_64}/.dbg_fork2 | 0 .../{linux-x64 => linux-x86_64}/bug_6678 | 0 .../archos/{linux-x64 => linux-x86_64}/cmd_dd | 4 +++ .../cmd_di_onsignals | 32 ++++++++++++++++++- .../archos/{linux-x64 => linux-x86_64}/cmd_dx | 2 ++ .../archos/{linux-x64 => linux-x86_64}/cmd_i | 0 .../cmd_interpreter | 0 .../db/archos/{linux-x64 => linux-x86_64}/dbg | 0 .../{linux-x64 => linux-x86_64}/dbg_aaa_dcu | 0 .../{linux-x64 => linux-x86_64}/dbg_aslr | 0 .../{linux-x64 => linux-x86_64}/dbg_bps | 0 .../{linux-x64 => linux-x86_64}/dbg_bps2 | 0 .../{linux-x64 => linux-x86_64}/dbg_cmdbps | 0 .../{linux-x64 => linux-x86_64}/dbg_cont | 0 .../{linux-x64 => linux-x86_64}/dbg_cont_back | 3 +- .../archos/{linux-x64 => linux-x86_64}/dbg_dL | 3 +- .../{linux-x64 => linux-x86_64}/dbg_dmh | 3 ++ .../{linux-x64 => linux-x86_64}/dbg_dmht | 3 ++ .../{linux-x64 => linux-x86_64}/dbg_dmi | 1 + .../{linux-x64 => linux-x86_64}/dbg_drt | 3 ++ .../{linux-x64 => linux-x86_64}/dbg_drv | 0 .../{linux-x64 => linux-x86_64}/dbg_dts | 0 .../{linux-x64 => linux-x86_64}/dbg_fds | 15 +-------- .../archos/{linux-x64 => linux-x86_64}/dbg_io | 0 .../{linux-x64 => linux-x86_64}/dbg_maps | 0 .../archos/{linux-x64 => linux-x86_64}/dbg_oo | 0 .../{linux-x64 => linux-x86_64}/dbg_px0 | 2 +- .../{linux-x64 => linux-x86_64}/dbg_seginfo | 0 .../{linux-x64 => linux-x86_64}/dbg_step | 0 .../{linux-x64 => linux-x86_64}/dbg_step_back | 1 + .../{linux-x64 => linux-x86_64}/dbg_trace1 | 0 .../{linux-x64 => linux-x86_64}/dbg_trace2 | 0 .../{linux-x64 => linux-x86_64}/dbg_trace3 | 0 .../{linux-x64 => linux-x86_64}/dbg_wps | 0 .../archos/{linux-x64 => linux-x86_64}/http | 3 +- .../{linux-x64 => linux-x86_64}/shell_uname | 0 .../dbg_rebase | 0 .../{windows-x64 => windows-x86_64}/http | 0 45 files changed, 67 insertions(+), 20 deletions(-) rename test/db/archos/{darwin-x64 => darwin-x86_64}/cmd_i (100%) rename test/db/archos/{darwin-x64 => darwin-x86_64}/cmd_interpreter (100%) rename test/db/archos/{darwin-x64 => darwin-x86_64}/http (100%) rename test/db/archos/{linux-x64 => linux-x86_64}/.dbg_fork (100%) rename test/db/archos/{linux-x64 => linux-x86_64}/.dbg_fork2 (100%) rename test/db/archos/{linux-x64 => linux-x86_64}/bug_6678 (100%) rename test/db/archos/{linux-x64 => linux-x86_64}/cmd_dd (99%) rename test/db/archos/{linux-x64 => linux-x86_64}/cmd_di_onsignals (97%) rename test/db/archos/{linux-x64 => linux-x86_64}/cmd_dx (99%) rename test/db/archos/{linux-x64 => linux-x86_64}/cmd_i (100%) rename test/db/archos/{linux-x64 => linux-x86_64}/cmd_interpreter (100%) rename test/db/archos/{linux-x64 => linux-x86_64}/dbg (100%) rename test/db/archos/{linux-x64 => linux-x86_64}/dbg_aaa_dcu (100%) rename test/db/archos/{linux-x64 => linux-x86_64}/dbg_aslr (100%) rename test/db/archos/{linux-x64 => linux-x86_64}/dbg_bps (100%) rename test/db/archos/{linux-x64 => linux-x86_64}/dbg_bps2 (100%) rename test/db/archos/{linux-x64 => linux-x86_64}/dbg_cmdbps (100%) rename test/db/archos/{linux-x64 => linux-x86_64}/dbg_cont (100%) rename test/db/archos/{linux-x64 => linux-x86_64}/dbg_cont_back (97%) rename test/db/archos/{linux-x64 => linux-x86_64}/dbg_dL (85%) rename test/db/archos/{linux-x64 => linux-x86_64}/dbg_dmh (97%) rename test/db/archos/{linux-x64 => linux-x86_64}/dbg_dmht (96%) rename test/db/archos/{linux-x64 => linux-x86_64}/dbg_dmi (99%) rename test/db/archos/{linux-x64 => linux-x86_64}/dbg_drt (96%) rename test/db/archos/{linux-x64 => linux-x86_64}/dbg_drv (100%) rename test/db/archos/{linux-x64 => linux-x86_64}/dbg_dts (100%) rename test/db/archos/{linux-x64 => linux-x86_64}/dbg_fds (68%) rename test/db/archos/{linux-x64 => linux-x86_64}/dbg_io (100%) rename test/db/archos/{linux-x64 => linux-x86_64}/dbg_maps (100%) rename test/db/archos/{linux-x64 => linux-x86_64}/dbg_oo (100%) rename test/db/archos/{linux-x64 => linux-x86_64}/dbg_px0 (81%) rename test/db/archos/{linux-x64 => linux-x86_64}/dbg_seginfo (100%) rename test/db/archos/{linux-x64 => linux-x86_64}/dbg_step (100%) rename test/db/archos/{linux-x64 => linux-x86_64}/dbg_step_back (99%) rename test/db/archos/{linux-x64 => linux-x86_64}/dbg_trace1 (100%) rename test/db/archos/{linux-x64 => linux-x86_64}/dbg_trace2 (100%) rename test/db/archos/{linux-x64 => linux-x86_64}/dbg_trace3 (100%) rename test/db/archos/{linux-x64 => linux-x86_64}/dbg_wps (100%) rename test/db/archos/{linux-x64 => linux-x86_64}/http (99%) rename test/db/archos/{linux-x64 => linux-x86_64}/shell_uname (100%) rename test/db/archos/{windows-x64 => windows-x86_64}/dbg_rebase (100%) rename test/db/archos/{windows-x64 => windows-x86_64}/http (100%) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 782e683e78..1e1fde9b78 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -148,6 +148,10 @@ jobs: run: | export LD_LIBRARY_PATH=/usr/local/lib make tests + - uses: actions/upload-artifact@v3 + with: + name: results.json + path: test/results.json linux-static-meson: if: contains(github.ref, 'master') || contains(github.ref, 'ci-') continue-on-error: true diff --git a/binr/r2r/load.c b/binr/r2r/load.c index dc2e11779e..c62fbc821b 100644 --- a/binr/r2r/load.c +++ b/binr/r2r/load.c @@ -622,7 +622,7 @@ static bool database_load(R2RTestDatabase *db, const char *path, int depth) { } bool is_archos_folder = !strcmp (path, "archos") || r_str_endswith (path, R_SYS_DIR"archos"); if (is_archos_folder && (skip_archos || strcmp (subname, R2R_ARCH_OS))) { - R_LOG_ERROR ("Skipping %s"R_SYS_DIR"%s because it does not match the current platform", path, subname); + R_LOG_ERROR ("Skipping %s"R_SYS_DIR"%s because it does not match the current platform \"%s\"", path, subname, R2R_ARCH_OS); continue; } r_strbuf_setf (&subpath, "%s%s%s", path, R_SYS_DIR, subname); diff --git a/binr/r2r/r2r.h b/binr/r2r/r2r.h index 880d33edd6..817a073142 100644 --- a/binr/r2r/r2r.h +++ b/binr/r2r/r2r.h @@ -5,7 +5,13 @@ #include +#if R_SYS_BITS & R_SYS_BITS_64 +#define R2R_ARCH_OS R_SYS_OS "-"R_SYS_ARCH "_64" +#elif R_SYS_BITS & R_SYS_BITS_32 +#define R2R_ARCH_OS R_SYS_OS "-"R_SYS_ARCH "_32" +#elif #define R2R_ARCH_OS R_SYS_OS "-"R_SYS_ARCH +#endif typedef struct r2r_cmd_test_string_record { char *value; diff --git a/test/db/archos/darwin-x64/cmd_i b/test/db/archos/darwin-x86_64/cmd_i similarity index 100% rename from test/db/archos/darwin-x64/cmd_i rename to test/db/archos/darwin-x86_64/cmd_i diff --git a/test/db/archos/darwin-x64/cmd_interpreter b/test/db/archos/darwin-x86_64/cmd_interpreter similarity index 100% rename from test/db/archos/darwin-x64/cmd_interpreter rename to test/db/archos/darwin-x86_64/cmd_interpreter diff --git a/test/db/archos/darwin-x64/http b/test/db/archos/darwin-x86_64/http similarity index 100% rename from test/db/archos/darwin-x64/http rename to test/db/archos/darwin-x86_64/http diff --git a/test/db/archos/linux-x64/.dbg_fork b/test/db/archos/linux-x86_64/.dbg_fork similarity index 100% rename from test/db/archos/linux-x64/.dbg_fork rename to test/db/archos/linux-x86_64/.dbg_fork diff --git a/test/db/archos/linux-x64/.dbg_fork2 b/test/db/archos/linux-x86_64/.dbg_fork2 similarity index 100% rename from test/db/archos/linux-x64/.dbg_fork2 rename to test/db/archos/linux-x86_64/.dbg_fork2 diff --git a/test/db/archos/linux-x64/bug_6678 b/test/db/archos/linux-x86_64/bug_6678 similarity index 100% rename from test/db/archos/linux-x64/bug_6678 rename to test/db/archos/linux-x86_64/bug_6678 diff --git a/test/db/archos/linux-x64/cmd_dd b/test/db/archos/linux-x86_64/cmd_dd similarity index 99% rename from test/db/archos/linux-x64/cmd_dd rename to test/db/archos/linux-x86_64/cmd_dd index 9888fe9dba..4022bf86dd 100644 --- a/test/db/archos/linux-x64/cmd_dd +++ b/test/db/archos/linux-x86_64/cmd_dd @@ -1,4 +1,5 @@ NAME=basic dd usage +BROKEN=1 FILE=bins/elf/ls-focal ARGS=-d CMDS=<