Magic-Mirror/radare2
1
0
Fork 0
mirror of https://github.com/radareorg/radare2.git synced 2024-11-28 15:41:38 +00:00
Code Issues Actions 7 Packages Projects Releases Wiki Activity

Fix resource leak and logic bug in r_io_reopen ##io

Browse Source
This commit is contained in:
condret 2021-10-12 23:17:08 +02:00
parent d6e6609617
commit 220f56881d
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
libr/io/io.c
View File

@ -231,7 +231,7 @@ R_API bool r_io_reopen(RIO* io, int fd, int perm, int mode) {
}
//does this really work, or do we have to handler debuggers ugly
uri = old->referer? old->referer: old->uri;
if (old->plugin->close && old->plugin->close (old)) {
if (old->plugin->close && !old->plugin->close (old)) {
return false; // TODO: this is an unrecoverable scenario
}
if (!(new = r_io_open_nomap (io, uri, perm, mode))) {
@ -251,8 +251,7 @@ R_API bool r_io_reopen(RIO* io, int fd, int perm, int mode) {
RIODesc *nd = r_io_open_nomap (io, uri, perm, mode);
if (nd) {
r_io_desc_exchange (io, od->fd, nd->fd);
r_io_desc_del (io, od->fd);
// bool res = r_io_desc_close (od);
r_io_desc_close (od);
if (nd->perm & R_PERM_W) {
io->corebind.cmdf (io->corebind.core, "omfg");
}