Magic-Mirror/radare2
1
0
Fork 0
mirror of https://github.com/radareorg/radare2.git synced 2024-12-02 10:16:21 +00:00
Code Issues Actions 7 Packages Projects Releases Wiki Activity

Fix leak in RIO: free iter after removing it from list

Browse Source 
ls_append/ls_prepend will create a new iter, so we need to free the
iter that was removed from the list.
This commit is contained in:
Riccardo Schirone 2019-03-04 14:48:36 +01:00 committed by radare
parent e3f93ec490
commit 3a96e51b3a
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
libr/io/map.c
View File

@ -414,14 +414,15 @@ R_API bool r_io_map_del_for_fd(RIO* io, int fd) {
//return a boolean denoting whether is was possible to priorized
R_API bool r_io_map_priorize(RIO* io, ut32 id) {
r_return_val_if_fail (io, false);
RIOMap* map;
SdbListIter* iter;
RIOMap *map;
SdbListIter *iter;
ls_foreach (io->maps, iter, map) {
// search for iter with the correct map
if (map->id == id) {
ls_split_iter (io->maps, iter);
ls_append (io->maps, map);
io_map_calculate_skyline (io);
free (iter);
return true;
}
}
@ -430,14 +431,15 @@ R_API bool r_io_map_priorize(RIO* io, ut32 id) {
R_API bool r_io_map_depriorize(RIO* io, ut32 id) {
r_return_val_if_fail (io, false);
RIOMap* map;
SdbListIter* iter;
RIOMap *map;
SdbListIter *iter;
ls_foreach (io->maps, iter, map) {
// search for iter with the correct map
if (map->id == id) {
ls_split_iter (io->maps, iter);
ls_prepend (io->maps, map);
io_map_calculate_skyline (io);
free (iter);
return true;
}
}