Magic-Mirror/radare2
1
0
Fork 0
mirror of https://github.com/radareorg/radare2.git synced 2024-10-06 18:13:46 +00:00
Code Issues Actions 7 Packages Projects Releases Wiki Activity

Fix pic_pic18 endian bug ##port

Browse Source
This commit is contained in:
Richard Patel 2024-04-01 03:37:45 +00:00 committed by pancake
parent 55a43afe37
commit 3d157d361c
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
libr/arch/p/pic/pic_pic18.c
View File

@ -116,8 +116,7 @@ char *pic_pic18_disassemble(const ut8 *b, int blen, int *opsz) {
return NULL;
}
*opsz = 2;
ut16 instr = 0; // instruction
memcpy (&instr, b, sizeof (instr));
ut16 instr = r_read_le16 (b); // instruction
r_strf_buffer (64);
// if still redundan code is reported think of this of instr=0x2
const char *buf_asm = "invalid";
@ -155,7 +154,7 @@ char *pic_pic18_disassemble(const ut8 *b, int blen, int *opsz) {
}
*opsz = 4;
{
ut32 dword_instr = *(ut32 *)b;
ut32 dword_instr = r_read_le32 (b);
//I dont even know how the bits are arranged but it works !!!
//`the wierdness of little endianness`
if (dword_instr >> 28 != 0xf) {
@ -171,7 +170,7 @@ char *pic_pic18_disassemble(const ut8 *b, int blen, int *opsz) {
}
{
*opsz = 4;
ut32 dword_instr = *(ut32 *)b;
ut32 dword_instr = r_read_le32 (b);
if (dword_instr >> 28 != 0xf) {
return NULL;
}
@ -185,7 +184,7 @@ char *pic_pic18_disassemble(const ut8 *b, int blen, int *opsz) {
}
*opsz = 4;
{
ut32 dword_instr = *(ut32 *)b;
ut32 dword_instr = r_read_le32 (b);
if (dword_instr >> 28 != 0xf) {
return NULL;
}
@ -201,7 +200,7 @@ char *pic_pic18_disassemble(const ut8 *b, int blen, int *opsz) {
break;
case LFSR_T: {
*opsz = 4;
ut32 dword_instr = *(ut32 *)b;
ut32 dword_instr = r_read_le32 (b);
if (dword_instr >> 28 != 0xf) {
return NULL;
}