Magic-Mirror/radare2
1
0
Fork 0
mirror of https://github.com/radareorg/radare2.git synced 2025-01-23 22:36:27 +00:00
Code Issues Actions 7 Packages Projects Releases Wiki Activity

Optimize sdb_array_add_num (#11157)

Browse Source
This commit is contained in:
Fangrui Song 2018-08-21 17:57:02 -07:00 committed by radare
parent 3be40b9a39
commit 6d115eac58
2 changed files with 6 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
libr/anal/meta.c
View File

@ -381,7 +381,8 @@ static int meta_add(RAnal *a, int type, int subtype, ut64 from, ut64 to, const c
int idx = sdb_array_indexof (DB, key, value, 0);
sdb_array_delete (DB, key, idx, 0);
}
snprintf (val, sizeof (val)-1, "%c", type);
val[0] = type;
val[1] = '\0';
sdb_array_add (DB, key, val, 0);
meta_inrange_add (a, from, to - from);
return true;

14
shlr/sdb/src/array.c
View File

@ -210,15 +210,9 @@ SDB_API int sdb_array_set_num(Sdb *s, const char *key, int idx, ut64 val,
}
SDB_API int sdb_array_add_num(Sdb *s, const char *key, ut64 val, ut32 cas) {
char valstr10[SDB_NUM_BUFSZ], valstr16[SDB_NUM_BUFSZ];
char *v10 = sdb_itoa (val, valstr10, 10);
char *v16 = sdb_itoa (val, valstr16, 16);
// TODO: optimize
// TODO: check cas vs mycas
if (sdb_array_contains (s, key, v10, NULL)) {
return 0;
}
return sdb_array_add (s, key, v16, cas); // TODO: v10 or v16
char buf[SDB_NUM_BUFSZ];
char *v = sdb_itoa (val, buf, SDB_NUM_BASE);
return sdb_array_add (s, key, v, cas);
}
// XXX: index should be supressed here? if its a set we shouldnt change the index
@ -226,7 +220,7 @@ SDB_API int sdb_array_add(Sdb *s, const char *key, const char *val, ut32 cas) {
if (sdb_array_contains (s, key, val, NULL)) {
return 0;
}
return sdb_array_set (s, key, -1, val, cas);
return sdb_array_insert (s, key, -1, val, cas);
}
SDB_API int sdb_array_add_sorted(Sdb *s, const char *key, const char *val, ut32 cas) {