Magic-Mirror/radare2
1
0
Fork 0
mirror of https://github.com/radareorg/radare2.git synced 2024-11-24 05:40:10 +00:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

USE_IS_VALID_OFFSET in RAnalData to speedup disasm ~10x on slow io backends

Browse Source 
- This requires more testing and the backend must provide
  sections or valid memory region areas somehow to make it
  work on the gdb backend for example, otherwise it's disabled
This commit is contained in:
pancake 2014-12-02 11:49:41 +01:00
parent cd0dad8234
commit 6e3d16dc81
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
libr/anal/data.c
View File

@ -48,6 +48,7 @@ static int is_invalid (const ut8 *buf, int size) {
return (!memcmp (buf, "\xff\xff\xff\xff\xff\xff\xff\xff", size))? 1: 0; return (!memcmp (buf, "\xff\xff\xff\xff\xff\xff\xff\xff", size))? 1: 0;
} }
#define USE_IS_VALID_OFFSET 1
static ut64 is_pointer(RIOBind *iob, const ut8 *buf, int endian, int size) { static ut64 is_pointer(RIOBind *iob, const ut8 *buf, int endian, int size) {
ut64 n; ut64 n;
ut8 buf2[32]; ut8 buf2[32];
@ -56,7 +57,10 @@ static ut64 is_pointer(RIOBind *iob, const ut8 *buf, int endian, int size) {
size = sizeof (buf2); size = sizeof (buf2);
n = r_mem_get_num (buf, size, endian); n = r_mem_get_num (buf, size, endian);
if (!n) return 1; // null pointer if (!n) return 1; // null pointer
#if USE_IS_VALID_OFFSET
int r = iob->is_valid_offset (iob->io, n);
return r? n: 0LL;
#else
// optimization to ignore very low and very high pointers // optimization to ignore very low and very high pointers
// this makes disasm 5x faster, but can result in some false positives // this makes disasm 5x faster, but can result in some false positives
// we should compare with current offset, to avoid // we should compare with current offset, to avoid
@ -67,6 +71,7 @@ static ut64 is_pointer(RIOBind *iob, const ut8 *buf, int endian, int size) {
ret = iob->read_at (iob->io, n, buf2, size); ret = iob->read_at (iob->io, n, buf2, size);
if (ret != size) return 0; if (ret != size) return 0;
return is_invalid (buf2, size)? 0: n; return is_invalid (buf2, size)? 0: n;
#endif
} }
static int is_bin(const ut8 *buf, int size) { static int is_bin(const ut8 *buf, int size) {