Magic-Mirror/radare2
1
0
Fork 0
mirror of https://github.com/radareorg/radare2.git synced 2024-12-12 07:26:42 +00:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

Fix x86 assembler output for some memory loads (#15068) ##asm

Browse Source 
Fixes some missing/wrong operand size prefixes
and a corrects a typo in handling 64-bit offsets.
This commit is contained in:
Brandon Lin 2019-09-18 00:57:40 -07:00 committed by radare
parent 146173767e
commit 9bf5aeb58a
1 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
libr/asm/p/asm_x86_nz.c
View File

@ -2100,8 +2100,10 @@ static int opmov(RAsm *a, ut8 *data, const Opcode *op) {
}
offset = op->operands[1].offset * op->operands[1].offset_sign;
if (op->operands[0].reg == X86R_EAX && op->operands[1].regs[0] == X86R_UNDEFINED) {
if (a->bits == 64) {
if (op->operands[0].type & OT_QWORD) {
data[l++] = 0x48;
} else if (op->operands[0].type & OT_WORD && a->bits != 16) {
data[l++] = 0x66;
}
if (op->operands[0].type & OT_BYTE) {
data[l++] = 0xa0;
@ -2110,13 +2112,15 @@ static int opmov(RAsm *a, ut8 *data, const Opcode *op) {
}
data[l++] = offset;
data[l++] = offset >> 8;
data[l++] = offset >> 16;
data[l++] = offset >> 24;
if (a->bits == 64) {
data[l++] = offset >> 32;
data[l++] = offset >> 40;
data[l++] = offset >> 48;
data[l++] = offset >> 54;
if (a->bits >= 32) {
data[l++] = offset >> 16;
data[l++] = offset >> 24;
if (a->bits == 64) {
data[l++] = offset >> 32;
data[l++] = offset >> 40;
data[l++] = offset >> 48;
data[l++] = offset >> 56;
}
}
return l;
}