Magic-Mirror/radare2
1
0
Fork 0
mirror of https://github.com/radareorg/radare2.git synced 2025-02-01 11:11:56 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Fix some coverity vulnerabilities (#18516)

Browse Source 
* Fix 1451533 Resource leak
* Fix 1451532 Resource leak
* Fix 1451074 Buffer not null terminated
* Fix 1409066 String not null terminated
This commit is contained in:
Murphy 2021-03-30 22:05:47 +02:00 committed by GitHub
parent 507d173c98
commit a0213f0347
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
libr/core/cmd_anal.c
View File

@ -8912,6 +8912,7 @@ R_API void cmd_agfb3(RCore *core, const char *s, int x, int y) {
RConsPixel *p = r_cons_pixel_new (w, h);
r_cons_pixel_sets (p, 0, 0, s);
r_cons_pixel_flush (p, x, y);
R_FREE (p);
}
R_API void cmd_agfb2(RCore *core, const char *s) {

2
libr/core/core.c
View File

@ -3580,7 +3580,7 @@ reaccept:
// silly http emulation over rap://
char line[256] = {0};
r_socket_read_block (c, (ut8*)line, sizeof (line));
if (!strncmp (line, "ET /cmd/", 8)) {
if (!r_str_ncpy (line, "ET /cmd/", 8)) {
char *cmd = line + 8;
char *http = strstr (cmd, "HTTP");
if (http) {

3
libr/hash/state.c
View File

@ -1,6 +1,7 @@
/* radare - LGPL - Copyright 2009-2017 pancake */
#include <r_hash.h>
#include <r_util.h>
#if HAVE_LIB_SSL
#include <openssl/md4.h>
@ -52,7 +53,7 @@ R_API ut8 *r_hash_do_ssdeep(RHash *ctx, const ut8 *input, int len) {
}
char *res = r_hash_ssdeep (input, len);
if (res) {
strncpy ((char *)ctx->digest, res, R_HASH_SIZE_SSDEEP);
r_str_ncpy ((char *)ctx->digest, res, R_HASH_SIZE_SSDEEP);
free (res);
}
return ctx->digest;

1
libr/socket/run.c
View File

@ -96,6 +96,7 @@ static void dyn_init(void) {
if (!dyn_forkpty) {
dyn_forkpty = r_lib_dl_sym (libutil, "forkpty");
}
R_FREE (libutil);
}
#endif
}