Magic-Mirror/radare2
1
0
Fork 0
mirror of https://github.com/radareorg/radare2.git synced 2025-03-06 13:29:46 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix some null derefs and memleaks from coverity

Browse Source
This commit is contained in:
pancake 2017-04-05 10:38:52 +02:00
parent bbc508b324
commit a2afa236a2
3 changed files with 19 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
libr/anal/sign.c
View File

@ -972,6 +972,7 @@ static int refsMatchCB(RSignItem *it, void *user) {
}
}
if (ctx->cb) {
free (refs);
return ctx->cb (it, ctx->fcn, ctx->user);
}

6
libr/asm/p/asm_wasm.c
View File

@ -460,7 +460,11 @@ static int disassemble(RAsm *a, RAsmOp *op, const ut8 *buf, int len) {
{
st64 val = 0;
size_t n = read_i64_leb128 (buf + 1, buf + len, &val);
sprintf (op->buf_asm, "i64.const 0x%08x", val);
if (val < 1) {
sprintf (op->buf_asm, "i64.const %" PFMT64d, val);
} else {
sprintf (op->buf_asm, "i64.const 0x%08" PFMT64x, val);
}
rep += n;
}
break;

16
libr/core/cmd_info.c
View File

@ -109,7 +109,11 @@ static void r_core_file_info(RCore *core, int mode) {
r_cons_printf (",\"fd\":%d", cf->desc->fd);
if (fsz != UT64_MAX) {
r_cons_printf (",\"size\":%"PFMT64d, fsz);
r_cons_printf (",\"humansz\":\"%s\"", r_num_units (NULL, fsz));
char *humansz = r_num_units (NULL, fsz);
if (humansz) {
r_cons_printf (",\"humansz\":\"%s\"", humansz);
free (humansz);
}
}
r_cons_printf (",\"iorw\":%s", r_str_bool ( io_cache ||\
cf->desc->flags & R_IO_WRITE ));
@ -144,7 +148,9 @@ static void r_core_file_info(RCore *core, int mode) {
if (cf->desc) {
pair ("fd", sdb_fmt (0, "%d", cf->desc->fd));
}
pair ("file", fn? fn: cf->desc->uri);
if (fn || (cf->desc && cf->desc->uri)) {
pair ("file", fn? fn: cf->desc->uri);
}
if (plugin) {
pair ("format", plugin->name);
}
@ -162,7 +168,11 @@ static void r_core_file_info(RCore *core, int mode) {
ut64 fsz = r_io_desc_size (core->io, cf->desc);
if (fsz != UT64_MAX) {
pair ("size", sdb_fmt (0,"0x%"PFMT64x, fsz));
pair ("humansz", r_num_units (NULL, fsz));
char *humansz = r_num_units (NULL, fsz);
if (humansz) {
pair ("humansz", humansz);
free (humansz);
}
}
}
if (info) {