Magic-Mirror/radare2
1
0
Fork 0
mirror of https://github.com/radareorg/radare2.git synced 2025-02-06 13:37:07 +00:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

Fix last pending warnings

Browse Source
This commit is contained in:
pancake 2017-07-11 17:54:22 +02:00
parent 68cb26566e
commit abaf84d857
8 changed files with 22 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
libr/asm/arch/hexagon/gnu/hexagon-opc.c
View File

@ -1158,8 +1158,8 @@ hexagon_extend
if (hexagon_if_arch_kext ())
{
/* TODO: It would be better to use the insn table to figure out the number of bits. */
xvalue = *value & (~0L << 6);
*value = *value & ~(~0L << 6);
xvalue = *value & ((~0UL >> 6) << 6);
*value = *value & ~((~0UL >> 6) << 6);
/*
if (is_signed && *value > (1L << (bits - 1)))
@ -1336,7 +1336,7 @@ hexagon_hash_icode
/* Configuration flags. */
/* Various HEXAGON_HAVE_XXX bits. */
#define HEXAGON_CPU_TYPE_UNINIT (~0 << sizeof (cpu_type))
#define HEXAGON_CPU_TYPE_UNINIT (~0UL << sizeof (cpu_type))
static int cpu_type;
static int cpu_flag;
@ -1697,9 +1697,9 @@ hexagon_encode_operand
}
if (operand->flags & HEXAGON_OPERAND_IS_LO16)
value.s = HEXAGON_LO16 (value.s);
value.s = HEXAGON_LO16 (value.u);
else if (operand->flags & HEXAGON_OPERAND_IS_HI16)
value.s = HEXAGON_HI16 (value.s);
value.s = HEXAGON_HI16 (value.u);
else if (operand->flags & HEXAGON_OPERAND_IS_SUBSET)
value.s = HEXAGON_SUBREGS_TO (value.s, operand->flags & HEXAGON_OPERAND_IS_PAIR);
@ -1837,6 +1837,7 @@ hexagon_reg_num
continue;
*input = regs + len - (*name? 1: 0);
// unused result . thank you gnu
return ((int) (aliasn? *aliasn = i: i), (int) regn);
}
}
@ -2832,14 +2833,14 @@ hexagon_dis_operand
xed = FALSE;
value -= paddr;
value >>= operand->shift_count;
value &= ~(~0 << 6);
value &= ~(~0UL << 6);
value += xvalue + paddr;
}
else
{
xed = TRUE;
value >>= operand->shift_count;
value &= ~(~0 << 6);
value &= ~(~0UL << 6);
value += xvalue;
}
xer = xvalue = 0;

2
libr/asm/arch/hexagon/gnu/opcode/hexagon.h
View File

@ -71,7 +71,7 @@
#define HEXAGON_IS16INSN(num) 0 /* not yet implemented */
/* Extract the low 16 bits */
#define HEXAGON_LO16(num) ((num) & ~(-1 << 16))
#define HEXAGON_LO16(num) ((num) & ~(-1UL << 16))
/* Extract the high 16 bits */
#define HEXAGON_HI16(num) (HEXAGON_LO16 ((num) >> 16))

2
libr/asm/code.c
View File

@ -1,4 +1,4 @@
/* radare - LGPL - Copyright 2009-2016 - pancake */
/* radare - LGPL - Copyright 2009-2017 - pancake */
#include <stdio.h>
#include <r_asm.h>

2
libr/bin/pdb/pdb_downloader.c
View File

@ -162,7 +162,7 @@ int r_bin_pdb_download(RCore* core, int isradjson, int* actions_done, SPDBOption
opt.dbg_file, ret ? "success" : "failed");
}
if (actions_done) {
*actions_done++;
(*actions_done)++;
}
deinit_pdb_downloader (&pdb_downloader);

3
libr/debug/debug.c
View File

@ -924,10 +924,7 @@ R_API int r_debug_step_over(RDebug *dbg, int steps) {
R_API int r_debug_step_back(RDebug *dbg) {
ut64 pc, prev = 0, end, cnt = 0;
ut8 buf[32];
RAnalOp op;
RDebugSession *before;
RListIter *tail;
if (r_debug_is_dead (dbg)) {
return 0;

21
libr/debug/session.c
View File

@ -213,11 +213,11 @@ R_API void r_debug_session_save(RDebug *dbg, const char *file) {
snapentry.size = base->size;
snapentry.timestamp = base->timestamp;
snapentry.perm = base->perm;
r_file_dump (base_file, &snapentry, sizeof (RSnapEntry), 1);
r_file_dump (base_file, base->data, base->size, 1);
r_file_dump (base_file, (const ut8*)&snapentry, sizeof (RSnapEntry), 1);
r_file_dump (base_file, (const ut8*)base->data, base->size, 1);
/* dump all hases */
for (i = 0; i < base->page_num; i++) {
r_file_dump (base_file, base->hashes[i], 128, 1);
r_file_dump (base_file, (const ut8*)base->hashes[i], 128, 1);
}
}
@ -227,14 +227,14 @@ R_API void r_debug_session_save(RDebug *dbg, const char *file) {
header.id = session->key.id;
header.addr = session->key.addr;
header.difflist_len = r_list_length (session->memlist);
r_file_dump (diff_file, &header, sizeof (RSessionHeader), 1);
r_file_dump (diff_file, (ut8*)&header, sizeof (RSessionHeader), 1);
/* dump registers */
r_debug_reg_sync (dbg, R_REG_TYPE_ALL, 0);
for (i = 0; i < R_REG_TYPE_LAST; i++) {
RRegArena *arena = session->reg[i]->data;
r_file_dump (diff_file, &arena->size, sizeof (int), 1);
r_file_dump (diff_file, arena->bytes, arena->size, 1);
r_file_dump (diff_file, (const ut8*)&arena->size, sizeof (int), 1);
r_file_dump (diff_file, (const ut8*)arena->bytes, arena->size, 1);
// eprintf ("arena[%d] size=%d\n", i, arena->size);
}
if (!header.difflist_len) {
@ -248,13 +248,13 @@ R_API void r_debug_session_save(RDebug *dbg, const char *file) {
/* Dump diff header */
diffentry.pages_len = r_list_length (snapdiff->pages);
diffentry.base_idx = r_snap_to_idx (dbg, snapdiff->base);
r_file_dump (diff_file, &diffentry, sizeof (RDiffEntry), 1);
r_file_dump (diff_file, (const ut8*)&diffentry, sizeof (RDiffEntry), 1);
/* Dump page entries */
r_list_foreach (snapdiff->pages, iter3, page) {
r_file_dump (diff_file, &page->page_off, sizeof (ut32), 1);
r_file_dump (diff_file, page->data, SNAP_PAGE_SIZE, 1);
r_file_dump (diff_file, page->hash, 128, 1);
r_file_dump (diff_file, (const ut8*)&page->page_off, sizeof (ut32), 1);
r_file_dump (diff_file, (const ut8*)page->data, SNAP_PAGE_SIZE, 1);
r_file_dump (diff_file, (const ut8*)page->hash, 128, 1);
}
}
}
@ -263,7 +263,6 @@ R_API void r_debug_session_save(RDebug *dbg, const char *file) {
}
R_API void r_debug_session_restore(RDebug *dbg, const char *file) {
RListIter *iter;
RDebugSession *session;
RDebugSnap *base;
RDebugSnapDiff *snapdiff;

1
libr/debug/snap.c
View File

@ -15,7 +15,6 @@ R_API RDebugSnap *r_debug_snap_new() {
R_API void r_debug_snap_free(void *p) {
RDebugSnap *snap = (RDebugSnap *) p;
ut32 i = 0;
r_list_free (snap->history);
free (snap->data);
free (snap->comment);

2
libr/parse/code.c
View File

@ -68,7 +68,7 @@ static int typeload(void *p, const char *k, const char *v) {
} while (next);
free (members);
}
tcc_sym_push(typename, typesize, btype);
tcc_sym_push (typename, typesize, btype);
}
return 0;
}