Magic-Mirror/radare2
1
0
Fork 0
mirror of https://github.com/radareorg/radare2.git synced 2024-11-24 22:00:18 +00:00
Code Issues Actions 7 Packages Projects Releases Wiki Activity

Fix oobread in protobuf parser ##crash

Browse Source
This commit is contained in:
pancake 2022-09-12 18:52:50 +02:00
parent ea16c078d9
commit ada98b4dbb
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libr/util/protobuf.c
View File

@ -106,7 +106,11 @@ static void decode_buffer(RStrBuf *sb, const ut8* start, const ut8* end, ut32 pa
{
bytes_read = read_u64_leb128 (buffer, end, &var64);
const ut8* ps = buffer + bytes_read;
const ut8* pe = ps + var64;
if ((int)var64 < 0) {
R_LOG_ERROR ("Invalid delta in var64");
break;
}
const ut8* pe = (const ut8*)ps + var64;
if (ps > buffer && pe <= end) {
if (is_string (ps, pe)) {
r_strbuf_appendf (sb, ": \"%.*s\"\n", (int)var64, (const char*) ps);