Magic-Mirror/radare2
1
0
Fork 0
mirror of https://github.com/radareorg/radare2.git synced 2025-02-17 12:48:41 +00:00
Code Issues Actions 7 Packages Projects Releases Wiki Activity

Fix a heap overflow (non-null terminated string) in RCons.rgb_str()

Browse Source
This commit is contained in:
pancake 2018-03-07 18:08:19 +01:00
parent 6428824bc6
commit b323f78dc5
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
libr/cons/rgb.c
View File

@ -203,18 +203,22 @@ static void r_cons_rgb_gen (char *outstr, ut8 attr, ut8 a, ut8 r, ut8 g, ut8 b)
/* Return the computed color string for the specified color */
R_API char *r_cons_rgb_str (char *outstr, RColor *rcolor) {
if (!rcolor || (!outstr && !(outstr = malloc (128)))) {
if (!rcolor) {
return NULL;
}
if (!outstr) {
outstr = calloc (32, 1);
}
*outstr = 0;
if (rcolor->a == ALPHA_RESET) {
sprintf (outstr, "%s", Color_RESET);
strcpy (outstr, Color_RESET);
return outstr;
}
// If the color handles both foreground and background, also add background
if (rcolor->a == ALPHA_FGBG) {
r_cons_rgb_gen (outstr, 0, ALPHA_BG, rcolor->r2, rcolor->g2, rcolor->b2);
}
// APPEND
r_cons_rgb_gen (outstr + strlen (outstr), rcolor->attr, rcolor->a, rcolor->r, rcolor->g, rcolor->b);
return outstr;