Magic-Mirror/radare2
1
0
Fork 0
mirror of https://github.com/radareorg/radare2.git synced 2025-03-05 21:13:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

kvm_openfiles can fail so make sure we print the error message. (#5285)

Browse Source 
* kvm_openfiles can fail so make sure we print the error message.

On OpenBSD you can use the kvm interface without /dev/kmem access but on FreeBSD
you need root or kmem access which one do not want to give a user.

Look at ps(1) on FreeBSD and see how they do it.
This commit is contained in:
nevun 2016-07-05 04:13:10 +02:00 committed by radare
parent 04de3e657f
commit d8d6d1a073
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
libr/debug/p/debug_native.c
View File

@ -47,6 +47,7 @@ static int r_debug_native_reg_write (RDebug *dbg, int type, const ut8* buf, int
#include <sys/types.h>
#include <sys/wait.h>
#include <kvm.h>
#include <limits.h>
#define R_DEBUG_REG_T struct reg
#include "native/procfs.h"
#if __KFBSD__
@ -522,10 +523,12 @@ static RList *r_debug_native_pids (int pid) {
# define KP_PID(x) (x)->ki_pid
# define KP_PPID(x) (x)->ki_ppid
#endif
char errbuf[_POSIX2_LINE_MAX];
struct kinfo_proc* kp;
int cnt = 0;
kvm_t* kd = kvm_openfiles (NULL, NULL, NULL, KVM_OPEN_FLAG, NULL);
kvm_t* kd = kvm_openfiles (NULL, NULL, NULL, KVM_OPEN_FLAG, &errbuf);
if (!kd) {
eprintf ("kvm_openfiles says %s\n", errbuf);
return NULL;
}
@ -534,7 +537,7 @@ static RList *r_debug_native_pids (int pid) {
if (cnt == 1) {
RDebugPid *p = r_debug_pid_new (KP_COMM(kp), pid, 's', 0);
if (p) r_list_append (list, p);
/* we got our processes, now fetch the parent process */
/* we got our process, now fetch the parent process */
kp = KVM_GETPROCS (kd, KERN_PROC_PID, KP_PPID(kp), &cnt);
if (cnt == 1) {
RDebugPid *p = r_debug_pid_new (KP_COMM(kp), KP_PID(kp), 's', 0);