Magic-Mirror/radare2
1
0
Fork 0
mirror of https://github.com/radareorg/radare2.git synced 2024-12-15 01:10:01 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Fix coverity issues

Browse Source
This commit is contained in:
pancake 2014-06-17 10:29:15 +02:00
parent 160c4568f7
commit e60552452d
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
libr/bin/p/bin_elf.c
View File

@ -20,7 +20,7 @@ static void setsymord (ELFOBJ* eobj, ut32 ord, RBinSymbol *ptr) {
} }
static void setimpord (ELFOBJ* eobj, ut32 ord, RBinImport *ptr) { static void setimpord (ELFOBJ* eobj, ut32 ord, RBinImport *ptr) {
if (!eobj->imports_by_ord && ord >= eobj->imports_by_ord_size) if (!eobj->imports_by_ord || ord >= eobj->imports_by_ord_size)
return; return;
free (eobj->imports_by_ord[ord]); free (eobj->imports_by_ord[ord]);
eobj->imports_by_ord[ord] = r_mem_dup (ptr, sizeof (RBinImport)); eobj->imports_by_ord[ord] = r_mem_dup (ptr, sizeof (RBinImport));
@ -208,7 +208,7 @@ static RList* sections(RBinFile *arch) {
} }
static RList* symbols(RBinFile *arch) { static RList* symbols(RBinFile *arch) {
int i, has_va = Elf_(r_bin_elf_has_va) (arch->o->bin_obj); int i, has_va;
struct Elf_(r_bin_elf_obj_t) *bin; struct Elf_(r_bin_elf_obj_t) *bin;
struct r_bin_elf_symbol_t *symbol = NULL; struct r_bin_elf_symbol_t *symbol = NULL;
RBinSymbol *ptr = NULL; RBinSymbol *ptr = NULL;
@ -217,6 +217,7 @@ static RList* symbols(RBinFile *arch) {
if (!arch || !arch->o || !arch->o->bin_obj) if (!arch || !arch->o || !arch->o->bin_obj)
return NULL; return NULL;
bin = arch->o->bin_obj; bin = arch->o->bin_obj;
has_va = Elf_(r_bin_elf_has_va) (bin);
if (!has_va) { if (!has_va) {
// find base address for non-linked object (.o) // // find base address for non-linked object (.o) //
if (arch->o->sections) { if (arch->o->sections) {

2
libr/core/anal.c
View File

@ -754,7 +754,7 @@ else
eprintf ("Invalid reference from 0x%08"PFMT64x eprintf ("Invalid reference from 0x%08"PFMT64x
" to 0x%08"PFMT64x"\n", fcni->addr, fcnr->addr); " to 0x%08"PFMT64x"\n", fcni->addr, fcnr->addr);
fr = &fakefr; fr = &fakefr;
free (fr->name); if (fr) free (fr->name);
fr->name = malloc (32); fr->name = malloc (32);
snprintf (fr->name, 31, "unk.0x%"PFMT64x, fcnr->addr); snprintf (fr->name, 31, "unk.0x%"PFMT64x, fcnr->addr);
} }