Magic-Mirror/radare2
1
0
Fork 0
mirror of https://github.com/radareorg/radare2.git synced 2024-12-02 18:27:18 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

* Apply Edd Barrett patch fixing the zombie processes

Browse Source 
bug in the r_sys_cmd_str_full() function
This commit is contained in:
pancake 2011-06-30 17:41:48 +02:00
parent 5beff0f193
commit e80caee947
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
libr/util/sys.c
View File

@ -208,7 +208,7 @@ R_API char *r_sys_getcwd(void) {
R_API char *r_sys_cmd_str_full(const char *cmd, const char *input, int *len, char **sterr) {
char *output, buffer[1024];
char *inputptr = (char *)input;
int pid, bytes = 0;
int pid, bytes = 0, status;
int sh_in[2], sh_out[2], sh_err[2];
if (len) *len = 0;
@ -238,7 +238,6 @@ R_API char *r_sys_cmd_str_full(const char *cmd, const char *input, int *len, cha
execl ("/bin/sh", "sh", "-c", cmd, (char*)NULL);
exit (1);
default:
{
output = calloc (1, 1024); // TODO: use malloc
if (!output)
return NULL;
@ -286,11 +285,15 @@ R_API char *r_sys_cmd_str_full(const char *cmd, const char *input, int *len, cha
close (sh_out[0]);
close (sh_err[0]);
close (sh_in[1]);
waitpid(pid, &status, 0);
if (status != 0) {
eprintf("%s: command returned !0\n", __func__);
return (NULL);
}
if (*output)
return output;
free (output);
}
}
return NULL;
}