Magic-Mirror/radare2
1
0
Fork 0
mirror of https://github.com/radareorg/radare2.git synced 2025-02-26 17:15:38 +00:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

Improve dupped symbol filter logic

Browse Source
This commit is contained in:
pancake 2021-07-29 20:05:20 +02:00 committed by pancake
parent a7a26b4f13
commit f1c81abd53
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
libr/bin/filter.c
View File

@ -33,26 +33,29 @@ R_API char *r_bin_filter_name(RBinFile *bf, HtPU *db, ut64 vaddr, char *name) {
r_return_val_if_fail (db && name, NULL);
char *resname = name;
char *uname = r_str_newf ("%" PFMT64x ".%s", vaddr, name);
int count = 0;
HtPUKv *kv = ht_pu_find_kv (db, name, NULL);
if (kv) {
count = ++kv->value;
kv->value++;
count = kv->value;
} else {
count = 1;
ht_pu_insert (db, name, 1ULL);
}
bool found;
// check if there's another symbol with the same name and address);
char *uname = r_str_newf ("%" PFMT64x ".%s", vaddr, name);
bool found = false;
ht_pu_find (db, uname, &found);
if (found) {
// TODO: symbol is dupped, so symbol can be removed!
free (uname);
return resname;
return NULL; // r_str_newf ("%s_%d", name, count);
}
HtPUKv tmp = {
.key = uname,
.key_len = 1,
.key_len = strlen (uname),
.value = count,
.value_len = sizeof (ut64)
};