Magic-Mirror/radare2
1
0
Fork 0
mirror of https://github.com/radareorg/radare2.git synced 2024-11-23 21:29:49 +00:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

Add SPP coverity fixes (#6416)

Browse Source
This commit is contained in:
Sven Steinbauer 2017-01-03 11:47:27 +00:00 committed by radare
parent e18ced61af
commit f73fc431ae
2 changed files with 6 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
shlr/spp/p/spp.h
View File

@ -74,9 +74,11 @@ TAG_CALLBACK(spp_getrandom)
if (!echo[ifl]) {
return 0;
}
srandom (getpid()); // TODO: change this to be portable
srandom (getpid ()); // TODO: change this to be portable
max = atoi (buf);
max = (int)(rand()%max);
if (max > 0) {
max = (int)(rand () % max);
}
do_printf (out, "%d", max);
return 0;
}
@ -363,6 +365,7 @@ TAG_CALLBACK(spp_endpipe)
pclose (spp_pipe_fd);
}
spp_pipe_fd = NULL;
free (str);
return 0;
}

19
shlr/spp/spp.c
View File

@ -224,24 +224,7 @@ retry:
do_fputs (out, ptr2 + delta);
} else {
D printf ("==> 3\n");
if (ptr) {
lbuf_strcat (lbuf, ptr);
} else {
if (!lbuf) {
// XXX should never happen
fprintf (stderr, "syntax error?\n");
return;
}
if (buf[0]) {
if (incmd) {
lbuf_strcat (lbuf, buf);
} else {
do_fputs (out, buf);
}
} else {
do_fputs (out, buf);
}
}
lbuf_strcat (lbuf, ptr);
}
}