Commit Graph

663 Commits

Author SHA1 Message Date
Riccardo Schirone
cfe9afb47a core/visual: just move the cursor also when using Vo
extract a couple of functions to avoid code duplication
2018-04-08 12:22:36 +02:00
Riccardo Schirone
82c8d558f3 core/visual: when possible, just move the cursor in visual mode
Instead of seeking to a new position even if the new address is already
visible in the screen, just move the cursor there.
2018-04-08 12:22:36 +02:00
Riccardo Schirone
ec2ac4185a core/visual: reset the cursor position when seeking elsewhere 2018-04-08 12:22:36 +02:00
Vanellope
14909482d8 Vane11ope/fix panels (#9814)
* created RPanals out of panels.c

* deleted a garbage
2018-04-07 16:51:25 +02:00
pancake
fe7ae5d0af Fix last 20 coverity issues 2018-03-19 11:51:04 +01:00
Florian Märkl
93d9f4ec66 Add mask parameter to r_anal_op() 2018-03-16 11:10:15 +01:00
cyanpencil
cd719d120b Implement pluggable dietline history. Use it in Vo (#9591) 2018-03-09 00:33:33 +01:00
pancake
b860076802 Fix #9541 - VC rotates scr.color instead of toggling 2018-03-02 17:58:44 +01:00
Vanellope
82374ce2d7 Fix disasm scroll issue when invalid on panels 2018-02-28 22:16:11 +01:00
pancake
92996067db BlindFix #9503 - Check core->file for NULL 2018-02-28 10:34:04 +01:00
pancake
d045b70c2d Fix crash in RConfig.setString(int) and add VbT to browse themes 2018-02-24 19:44:09 +01:00
xarkes
5e097dbae1 Killed cons->truecolor in favor of cons->color 2018-02-24 11:47:38 +01:00
pancake
ed1ed75474 Fix #9475 - visual crash after oom 2018-02-23 18:27:17 +01:00
pancake
53d5514a3d Revert "Workaround to make Vcj fail that often, needs full rewrite"
This reverts commit dcf4b49d79.
2018-02-22 18:17:46 +01:00
Farid AYOUJIL
1e29f31576 Refactoring asm.cmt* and scr.* 2018-02-22 17:59:08 +01:00
pancake
dcf4b49d79 Workaround to make Vcj fail that often, needs full rewrite 2018-02-22 17:15:27 +01:00
pancake
22bd9e9fb5 Add scr.slow and fix uninitialized var issue 2018-02-22 12:45:54 +01:00
sivaramaaa
8ca0d327e4 Intial implementation of function call argument display (#9411)
* Cleanup disasm code
* Move this to new command afal and few bug fix
* Wrap the command with config var
2018-02-22 13:21:40 +08:00
pancake
c2a8afa8fb Add VbC to browse comments 2018-02-21 03:10:38 +01:00
pancake
95e7d6ab64 Add VbF to browse functions 2018-02-21 02:17:31 +01:00
pancake
185c91eefd Implement VV) - rotate asm.emu.str in visual graph 2018-02-20 22:03:27 +01:00
pancake
7abcec8f12 Remove global variable and make V) a tri-state 2018-02-19 23:24:41 +01:00
pancake
30a5247a8a Add ')' key in visual to toggle asm.emu.str 2018-02-19 23:04:17 +01:00
pancake
fe194d205a Add Visual browser for process threads 2018-02-04 13:04:34 +01:00
pancake
43420e4671 Add Vb[is] for imports/symbols 2018-01-24 10:47:33 +01:00
pancake
303820dbac Initial purge of R2_PREFIX towards dir.prefix 2018-01-16 11:13:21 +01:00
pancake
335938be58 r_str_chop -> r_str_trim 2018-01-08 03:22:26 +01:00
Lowly Worm
8ec19dbfdd skip over strings with Vj 2018-01-06 17:23:48 -08:00
pancake
b23360ef7e Do print edges before nodes again and add V^ key like VV^ 2017-12-30 04:11:49 +01:00
pancake
df4ddfc745 Fix last covs 2017-12-20 15:05:33 +01:00
pancake
0b1e8eaecc Fix almost all warnings from the msvc build 2017-12-19 00:18:39 +01:00
pancake
0154e8297a Fix #9038 - Handle pds in VO 2017-12-18 14:00:54 +01:00
pancake
0851129765 Implement r_cons_readchar_timeout. wink wink 2017-12-18 02:44:51 +01:00
Florian Märkl
7028e3113d Add r_core_prevop_addr_force() with fallback 2017-12-16 20:02:54 +01:00
pancake
2ea61faaeb Oops 2017-12-16 02:25:35 +01:00
pancake
fdb4c05612 Make VO rotate instead of toggle for asm.pseudo and asm.esil 2017-12-16 02:23:53 +01:00
pancake
40295143a5 Honor pP and add ? in Vx 2017-12-16 01:44:45 +01:00
pancake
d8c22d8edb Add comment counter in ds and show rendering in VV 2017-11-24 23:19:26 +01:00
pancake
f371229fe0 Oops scr.fps was already there :D show it in graph view too 2017-11-24 00:55:18 +01:00
pancake
7d2da2201e Implement scr.fps 2017-11-23 23:16:19 +01:00
pancake
bb7a490277 Honor supported bits mask in V& 2017-11-09 12:21:03 +01:00
pancake
62b7fa7c4c Bring back V& with anal hints 2017-10-20 02:21:19 +02:00
Lowly Worm
fbec8ce2c2 rm useless include 2017-10-18 22:22:54 -07:00
Lowly Worm
2054b08a48 skip over entire multi-byte data sections in Vj
- still doesn't work for scrolling up
- will require a bit of rework of meta
2017-10-18 22:16:40 -07:00
pancake
acbdf19b4e More work on Vb for browsing stuff 2017-10-16 22:31:29 +02:00
pancake
3b2b592506 V\ now looks a bit better (make cl clear one line) 2017-10-16 16:38:33 +02:00
pancake
5bc44fbc44 Initial work on the Vb refactoring 2017-10-16 16:15:15 +02:00
pancake
899d561574 Fix two covs 2017-09-18 15:46:55 +02:00
pancake
6da1fa47bf Fix crash in dd A, dd .,,.,,, and in V||| and V```... 2017-09-15 16:59:51 +02:00
Fangrui Song
1c4407cb69 Fix #8388 - Replace RIOMap::{from,to} with RAddrInterval itv. 2017-09-14 12:40:22 +02:00
pancake
46b6051129 Add quiet files list (oq, omq) 2017-08-26 03:49:54 +02:00
condret
2f201bded0 opsalamance - merge the big siol branch
- Thanks @MaskRay and @condret
2017-08-22 09:42:16 +02:00
alvarofe
2e462ec8f0 Bring RIODesc from SIOL and cleanup 2017-08-18 01:31:57 +00:00
rene
b1ef3edd18 changed VX that it does not need a function to work 2017-08-17 14:35:41 +08:00
pancake
e0f0c89783 Fix #8115 - PoC for the Visual Split mode 2017-08-03 14:52:59 +02:00
pancake
7e4d73947d Fix build 2017-07-02 23:39:30 +02:00
pancake
50643229e7 Make Vb run dbs like key.f2 for consistency 2017-07-02 23:37:13 +02:00
xarkes
342887c7d8 Fix windows F keys press in visual mode (#7843) 2017-06-30 17:40:07 +02:00
pancake
dac86f039a Fix visual cursor, invert V|| offset and fix so-1 2017-06-28 02:21:16 +02:00
pancake
bf883ee806 Reduce flashes in V|| aka cmd.cprompt 2017-06-28 00:35:58 +02:00
pancake
721304a3ed Implement visual entropy browser with V|| and then hl keys to move 2017-06-28 00:24:26 +02:00
alvarofe
7af491dda5 Fix build 2017-06-09 21:35:38 +02:00
pancake
470c183010 Initial work towards supporting a visual ESIL debugger VpOd 2017-06-09 19:12:20 +02:00
Roi Martin
d9202106f4 Fix hex column resize in visual mode (#7712) 2017-06-09 15:58:49 +02:00
Lowly Worm
192dbad64e fix a few covs for out of bounds reads/writes
from fencepost errors
2017-06-03 01:21:07 -04:00
pancake
78ecad3d3b Fix dmi honoring dmm on Mac debugger 2017-05-29 11:45:13 +02:00
pancake
a504ece143 Support square pixels, cursor and scroll in prc, available in VPP, add hex.pcols 2017-05-29 04:36:34 +02:00
pancake
6111637a66 Fix stack overflow in a race condition inside V@ 2017-05-17 23:48:05 +02:00
xarkes
926f024909 Improved MSVC support (WIP) 2017-05-09 14:25:57 +02:00
pancake
d7c2c717ea Fix deadlock in r_core_cmd spawned from V@ 2017-05-09 03:06:50 +02:00
pancake
204da24d0e Integrate pss into the visual mode 2017-05-03 03:23:05 +02:00
pancake
5e641b2d68 Implement pss command to use it in cmd.visual or broken terminals 2017-05-03 03:05:01 +02:00
pancake
1707d0115c Honor cmd.visual in Visual title 2017-05-03 02:54:31 +02:00
pancake
ffe0da0fa1 Fix many more clang-analyzer null derefs and overflows 2017-04-18 00:38:24 +02:00
pancake
a66cc10d46 Fix a huge list of null derefs from clang-analyzer 2017-04-17 22:02:04 +02:00
pancake
d750500573 V; prompt on top instead of scroll 2017-04-12 03:14:56 +02:00
pancake
a8d0aeea05 0 is also a valid address for V. 2017-03-24 11:34:40 +01:00
pancake
b862dc5587 Fix logic in V. (thx @jroimartin for the tip) 2017-03-24 01:28:24 +01:00
pancake
6b8d0b9aaf Support alt-q in Visual and Visual Insert modes 2017-03-24 01:23:25 +01:00
pancake
2b783319e8 Enhance V. to work with firmwares and dumps 2017-03-24 01:06:41 +01:00
neutralinsomniac
653bac82d5 Add '0' visual mode command to help 2017-03-23 15:41:04 +01:00
Riccardo Schirone
26fd259d04 New command 'ss' (Silent Seek)
These commands seek to an address or a register without logging the
entry in the seek history.
2017-03-19 02:34:53 +01:00
Maijin
b21527e9a4 Fix visual help 2017-03-15 19:46:39 +01:00
Maijin
ae70991673 Fix visual help 2017-03-15 19:29:05 +01:00
pancake
f82930fd75 Fix latest covs 2017-03-15 12:12:55 +01:00
xarkes
335fff01ba Fix alignment in Vx 2017-03-13 20:45:19 +01:00
xarkes
507e52acca Fix #4093 - rework on VX 2017-03-12 23:14:09 +01:00
Álvaro Felipe Melchor
ea7b25213a Kill & in visual.c 2017-03-12 11:37:12 +01:00
Maijin
99bdc3e957 Remove & in Visual replaced with dh Fix #6655 2017-03-12 11:36:36 +01:00
pancake
bd7c316e71 Fix #6837 - Replace pc for pxx in visual 2017-02-23 19:48:40 +01:00
pancake
1943d1ef07 Disable mouse when prompting in Visual Panels 2017-02-23 19:46:01 +01:00
Maijin
3184412db2 Fix #6823 and Fix #6728 fKEYS in Graphs.c, Visual.c and Panels.c 2017-02-22 23:45:51 +01:00
pancake
4bbc73a0e2 Fix #6818 - json indent ~{} honors scr.color
- Cannot configure the color palette
2017-02-20 02:32:58 +01:00
pancake
b7396fffa5 Enhance Vx - visual xrefs browser, with more highlight and less glitches 2017-02-08 12:14:52 +01:00
Álvaro Felipe Melchor
f3b1bb32bb Just iterate over plugin's bits when V& 2017-02-07 01:55:30 +00:00
pancake
e11f033110 Honor Vd[x] in batch mode, also refresh with Vrq 2017-02-06 00:55:03 +01:00
Maijin
3249b24d32 Add key in visual mode to toggle asm.pseudo Fix #2914 2017-02-06 00:49:27 +01:00
pancake
1cac404463 Vr refresh visual screen 2017-02-06 00:24:01 +01:00
SchumBlubBlub
6c00c9e2d5 Reorganize string macros 2017-02-06 00:00:03 +01:00
SchumBlubBlub
3522830c71 Tweak Visual ?help (#6679) 2017-02-04 13:01:39 +01:00
pancake
adf851d21d Fix #6665 - show t in V? 2017-02-03 14:44:21 +01:00
SchumBlubBlub
86bcdf46a0 Fix mouse paste in some visual cmds when scr.wheel=1 (#6649) 2017-02-03 13:09:34 +01:00
pancake
c17889a9b4 Fix fd and use it in axt and visual xrefs 2017-01-24 01:41:12 +01:00
Moritz Eckert
c176c48ffc Implement: Show comments in hexdump #6460 (#6527)
* Add hex.comments variable to config
* Add get_comments callback to the core api
* Add comment printing functionality to px
* Add pxc function
* Change visual mode hexdump to pxc
* Boolify use_comments
2017-01-18 16:12:06 +01:00
pancake
95cddc5151 Show function+delta in visual title 2017-01-11 23:56:36 +01:00
pancake
075949f04a Fix V@ and implement Vc@ 2017-01-11 23:51:20 +01:00
pancake
e23c173460 Use <> keys in visual to seek cursor to select ranges and move with precission 2017-01-10 01:47:15 +01:00
pancake
5cbb0324b6 Restore the selected tab on non-debugger view 2016-12-28 12:44:26 +01:00
pancake
79d785c19d More fixes for Vx to make it work on small terminals 2016-12-26 14:05:00 +01:00
pancake
d78af7acf6 Enhance Vx visualization 2016-12-26 13:51:12 +01:00
pancake
3cab378e00 Fix regression after memleak fix 2016-12-20 02:14:37 +01:00
Álvaro Felipe Melchor
24f9981b65 Fix warning and restore asm.cmtright in r_core_visual_graph 2016-12-20 02:12:05 +01:00
pancake
44040638b0 Fix some overflows and null derefs reported by clang-analyzer 2016-12-20 00:48:02 +01:00
Álvaro Felipe Melchor
88d4649cc6 fix more coverities 2016-12-19 17:23:30 +01:00
pancake
9039228b58 Honor Q as an alias for q! in visual and prompt 2016-12-19 04:46:50 +01:00
Álvaro Felipe Melchor
224b3c3319 fix some coverities 2016-12-18 23:41:55 +01:00
pancake
529613dbbe Fix #6293 - V after agf not working 2016-12-09 15:29:15 +01:00
pancake
8c96a90d09 Fix first visual seek to PC in debugger mode 2016-12-03 12:27:32 +01:00
pancake
72e874c2ac Fix noreturn issue introduced with the flag_get_at aproximation 2016-12-01 10:48:00 +01:00
pancake
15b43564fd Manipulate stack.delta and stack.size with Vppc[jk+-.] 2016-11-24 23:25:49 +01:00
pancake
2aaf0b2d9d Fix #2924 - Add key in visual insert mode to remove or insert bytes 2016-11-24 04:46:01 +01:00
pancake
5cbcdb2466 Temporary PoC to fix flagdelta in visual title 2016-11-23 12:30:43 +01:00
pancake
2f8acc984b Adjust asm.cmtcol in visual with [] keys and cursor mode enabled 2016-11-22 23:30:46 +01:00
Álvaro Felipe Melchor
87724384d1 added r_cons_break_{push/pop} to handle ^C better
Besides an UAF has been fixed afecting only ELF
2016-11-21 16:56:12 +01:00
pancake
d606c77266 Use quotes in visual to toggle columns mode 2016-11-21 00:19:15 +01:00
Álvaro Felipe Melchor
1dcd1273fb Fix oob write in disasm.c myregwrite
There was a dangling pointer in esil pointing to RDisasmState

WRITE of size 1 at 0x620000000a88 thread T0
    #0 0x103fab3dc in myregwrite disasm.c:2793
    #1 0x1049544b9 in r_anal_esil_reg_write esil.c:545
    #2 0x1049621e4 in esil_subeq esil.c:1418
    #3 0x1049570e0 in runword esil.c:2365
    #4 0x104955bcf in r_anal_esil_parse esil.c:2466
    #5 0x103f417e4 in r_core_anal_esil anal.c:3145
    #6 0x103df14e0 in cmd_anal_all .cmd_anal.c:4600
    #7 0x103d6c610 in cmd_anal .cmd_anal.c:4829
    #8 0x103f1ee25 in r_cmd_call cmd_api.c:213
    #9 0x103dd7afc in r_core_cmd_subst_i cmd.c:1960
    #10 0x103d66007 in r_core_cmd_subst cmd.c:1311
    #11 0x103d5fd0b in r_core_cmd cmd.c:2477
    #12 0x103d3910c in r_core_prompt_exec core.c:1687
    #13 0x103c9b1de in main radare2.c:1021
    #14 0x7fff9339b5ac in start (libdyld.dylib+0x35ac)
2016-11-15 19:35:28 +01:00
Sebastian Reichel
e9383b1441 Arch independent data in share (#6183)
* magic data is architecture independent

* fcnsign data is architecture independent

* opcode data is architecture independent

* syscall data is architecture independent

* hud data is architecture independent
2016-11-12 11:08:34 +01:00
pancake
637e6db3e1 Initial fix for #5113 - axf not working 2016-11-07 03:13:17 +01:00
pancake
f3895cdfc0 Initial implementation of io.pava 2016-11-04 03:15:17 +01:00
pancake
c15cf1239c Initial support for io.pava 2016-11-04 01:30:35 +01:00
pancake
9f4c8768a7 Implement prj.files and fix some bugs in project listing and saving 2016-10-17 23:58:39 +02:00
pancake
dd8ccc7b13 Honor vim command 2016-10-17 13:11:46 +02:00
pancake
2b37951e63 Initial implementation of pC (column disasm) 2016-10-08 00:02:47 +02:00
radare
20ec177ba0 Initial implementation of flag zones 2016-10-06 02:40:26 +02:00
pancake
6db1ee101d Fix wxs command 2016-10-04 18:03:03 +02:00
pancake
cde25b0335 Refix #5715 - Add Ve$ command to see vars in visual 2016-09-15 12:40:46 +02:00
Anton Kochkov
b86f1c471d Add , help 2016-09-08 13:24:42 +03:00
pancake
6b1a0677fd Revert "Remove agv fix #5662"
This reverts commit 1248617989.
2016-09-02 17:14:52 +02:00
Maijin
1248617989 Remove agv fix #5662 2016-09-02 14:11:42 +02:00
pancake
2f73865c5c Fix #5572 - show disasm in Vx and also fix build 2016-08-22 18:44:52 +02:00
pancake
9021789382 Fix #5546 - Implement Vv[JK] to scroll pages of functions 2016-08-18 00:29:11 +02:00
SkUaTeR
83266a0a4e Add socket timeout on windows connect 2016-08-16 03:19:15 +02:00
Chris Rorvick
9b47635f0c remove `next' param from r_core_block_read()
This was originally used to cause a seek to the next block prior to
reading such that successive calls to r_core_block_read() would progress
through memory one block at a time.  This was broken, though, by commit
452669d941 ("more cleanup in r_core_block_read") when when it used
`next' to directly calculate the offset rather than via a seek.

Only one call site remains that attempts to read the next block instead
of the current, and this probably was not even observable due to the
"hacky fix" added in commit 3bfa61946e ("Cleaner pvj, fix tinype load,
and honor 'ao N's").

The current of semantics of `next' appear to be broken and there is very
little dependence on it.  If the original behavior should be restored
anywhere, it would be much better to add a new function, or just do the
seek explicitly, rather than parameterizing r_core_block_read() on it.
2016-08-15 14:26:58 -05:00
pancake
6dfba715b1 Fix #5361 - realtime hexview edit mode 2016-07-25 05:14:48 +02:00
Álvaro Felipe Melchor
4b08d38cb1 more mem leak fixes 2016-06-29 10:11:25 +02:00
Jeffrey Crowell
c145740030 replace r_cons_printf("%s\n",p) r_cons_println(p)
move from 10% of code in vfprintf to just 6% \o/ for simple tests of r2
-c "aaa" -q /bin/ls
2016-06-26 00:52:03 -04:00
pancake
b829244c19 Fixes for thumb/arm string references and endian refptr 2016-06-12 23:42:37 +02:00
Jeffrey Crowell
7c3fb53a5e fix disassembling 'backwards'
(e.g. pd -5) producing wrong output

fixes #5105
2016-06-11 10:59:42 +02:00
Anton Kochkov
68ef35f635 Uniform name RUndos -> RIOUndos (for bindings) 2016-06-02 07:34:06 +03:00
pancake
d3394d5a7a Fix latest 28 COVs 2016-06-02 03:19:31 +02:00