* Add hex.comments variable to config
* Add get_comments callback to the core api
* Add comment printing functionality to px
* Add pxc function
* Change visual mode hexdump to pxc
* Boolify use_comments
There was a dangling pointer in esil pointing to RDisasmState
WRITE of size 1 at 0x620000000a88 thread T0
#0 0x103fab3dc in myregwrite disasm.c:2793
#1 0x1049544b9 in r_anal_esil_reg_write esil.c:545
#2 0x1049621e4 in esil_subeq esil.c:1418
#3 0x1049570e0 in runword esil.c:2365
#4 0x104955bcf in r_anal_esil_parse esil.c:2466
#5 0x103f417e4 in r_core_anal_esil anal.c:3145
#6 0x103df14e0 in cmd_anal_all .cmd_anal.c:4600
#7 0x103d6c610 in cmd_anal .cmd_anal.c:4829
#8 0x103f1ee25 in r_cmd_call cmd_api.c:213
#9 0x103dd7afc in r_core_cmd_subst_i cmd.c:1960
#10 0x103d66007 in r_core_cmd_subst cmd.c:1311
#11 0x103d5fd0b in r_core_cmd cmd.c:2477
#12 0x103d3910c in r_core_prompt_exec core.c:1687
#13 0x103c9b1de in main radare2.c:1021
#14 0x7fff9339b5ac in start (libdyld.dylib+0x35ac)
* magic data is architecture independent
* fcnsign data is architecture independent
* opcode data is architecture independent
* syscall data is architecture independent
* hud data is architecture independent
This was originally used to cause a seek to the next block prior to
reading such that successive calls to r_core_block_read() would progress
through memory one block at a time. This was broken, though, by commit
452669d941 ("more cleanup in r_core_block_read") when when it used
`next' to directly calculate the offset rather than via a seek.
Only one call site remains that attempts to read the next block instead
of the current, and this probably was not even observable due to the
"hacky fix" added in commit 3bfa61946e ("Cleaner pvj, fix tinype load,
and honor 'ao N's").
The current of semantics of `next' appear to be broken and there is very
little dependence on it. If the original behavior should be restored
anywhere, it would be much better to add a new function, or just do the
seek explicitly, rather than parameterizing r_core_block_read() on it.
