Remove duplicate empty lines from all source files.

There is no reason for them to be in our sources (except for Python, where
their presence is mandated by PEP8).
This commit is contained in:
Petr Zemek 2019-05-30 13:41:00 +02:00
parent 0456a3d0b3
commit ef2870314f
30 changed files with 0 additions and 50 deletions

View File

@ -37,7 +37,6 @@ class ReturnEntry
const std::vector<llvm::StoreInst*>& retStores() const;
const std::vector<llvm::Value*>& retValues() const;
protected:
llvm::ReturnInst* _retInst = nullptr;

View File

@ -30,7 +30,6 @@ class AbiX86 : public Abi
public:
virtual bool isNopInstruction(cs_insn* insn) override;
// Calling conventions.
//
private:

View File

@ -4,7 +4,6 @@
* @copyright (c) 2019 Avast Software, licensed under the MIT license
*/
#ifndef RETDEC_BIN2LLVMIR_PROVIDERS_CALL_CONV_CALL_CONV_H
#define RETDEC_BIN2LLVMIR_PROVIDERS_CALL_CONV_CALL_CONV_H

View File

@ -306,7 +306,6 @@ void Collector::collectStoresRecursively(
seen[block] = values;
}
bool Collector::collectStoresInInstructionBlock(
Instruction* start,
std::set<Value*>& values,
@ -476,7 +475,6 @@ void Collector::collectCallSpecificTypes(CallEntry* ce) const
return;
}
if (!extractFormatString(ce))
{
return;

View File

@ -440,7 +440,6 @@ void Filter::filterArgsByKnownTypes(FilterableLayout& lay) const
}
}
if (!requiredStacks && stackOrd == OrderID::ORD_STACK)
{
requiredStacks = getNumberOfStacksForType(t);
@ -770,7 +769,6 @@ void Filter::filterRetsByKnownTypes(FilterableLayout& lay) const
lay.knownTypes = {retType};
}
void Filter::leaveCommonArgs(std::vector<FilterableLayout>& allArgs) const
{
leaveCommon(allArgs);
@ -1093,7 +1091,6 @@ std::vector<llvm::Value*> Filter::createGroupedValues(const FilterableLayout& la
}
break;
default:
continue;
}

View File

@ -4,7 +4,6 @@
* @copyright (c) 2019 Avast Software, licensed under the MIT license
*/
#include "retdec/bin2llvmir/providers/abi/abi.h"
#include "retdec/bin2llvmir/providers/calling_convention/calling_convention.h"
#include "retdec/bin2llvmir/providers/calling_convention/arm/arm_conv.h"

View File

@ -699,7 +699,6 @@ llvm::Value* Capstone2LlvmIrTranslatorArm64_impl::loadRegister(
return getCurrentPc(_insn);
}
llvm::Type* rt = nullptr;
try
{
@ -2906,7 +2905,6 @@ void Capstone2LlvmIrTranslatorArm64_impl::translateMovi(cs_insn* i, cs_arm64* ai
storeOp(ai->operands[0], op1, irb);
}
/**
* ARM64_INS_FMUL, ARM64_INS_FNMUL
*/

View File

@ -630,7 +630,6 @@ void Capstone2LlvmIrTranslatorArm64_impl::initializeRegTypeMap()
auto* f64 = llvm::Type::getDoubleTy(_module->getContext());
auto* f128 = llvm::Type::getFP128Ty(_module->getContext());
std::map<uint32_t, llvm::Type*> r2t =
{
// General purpose registers.
@ -1557,7 +1556,6 @@ void Capstone2LlvmIrTranslatorArm64_impl::initializeRegistersParentMapToOther(
}
}
void Capstone2LlvmIrTranslatorArm64_impl::initializeRegistersParentMap()
{
// Last element in vector is its own parent.

View File

@ -476,7 +476,6 @@ class Capstone2LlvmIrTranslator_impl : virtual public Capstone2LlvmIrTranslator
virtual uint8_t getOperandAccess(CInsnOp& op);
virtual void translatePseudoAsmGeneric(cs_insn* i, CInsn* ci, llvm::IRBuilder<>& irb);
void throwUnexpectedOperands(cs_insn* i, const std::string comment = "");
void throwUnhandledInstructions(cs_insn* i, const std::string comment = "");

View File

@ -4427,7 +4427,6 @@ void Capstone2LlvmIrTranslatorX86_impl::translateFst(cs_insn* i, cs_x86* xi, llv
storeOp(xi->operands[0], src, irb, eOpConv::FP_CAST);
}
if (i->id == X86_INS_FSTP)
{
storeX87TagReg(irb, top, llvm::ConstantInt::get(irb.getIntNTy(2), 3)); // 0b11

View File

@ -150,7 +150,6 @@ class ProgramOptions
}
}
void dump()
{
cout << endl;

View File

@ -1569,7 +1569,6 @@ const TlsInfo* FileFormat::getTlsInfo() const
return tlsInfo;
}
/**
* Get information about ELF core file
* @return Pointer to ELF core info of @c nullptr if file has no certificates

View File

@ -30,7 +30,6 @@
#include "retdec/fileformat/utils/file_io.h"
#include "retdec/crypto/crypto.h"
using namespace retdec::utils;
using namespace PeLib;
@ -739,7 +738,6 @@ void PeFormat::loadVisualBasicHeader()
visualBasicInfo.setLanguageDLLPrimaryLCID(vbh.LCID1);
visualBasicInfo.setLanguageDLLSecondaryLCID(vbh.LCID2);
if (getOffsetFromAddress(vbProjectInfoOffset, vbh.projectInfoAddr))
{
parseVisualBasicProjectInfo(vbProjectInfoOffset);

View File

@ -607,7 +607,6 @@ bool BitmapImage::reduce8x8()
}
}
/* crop to 8x8 */
image.resize(8);
for (auto &row : image)
@ -711,6 +710,5 @@ void BitmapImage::greyScale()
}
}
} // namespace fileformat
} // namespace retdec

View File

@ -187,7 +187,6 @@ bool ResourceIcon::hasLoadedProperties() const
return loadedProperties;
}
/**
* A method which indicates whether color count of an icon is valid.
* @return @c `true` if it is, otherwise `false`

View File

@ -7,7 +7,6 @@
#include "retdec/fileformat/types/resource_table/resource_icon.h"
#include "retdec/fileformat/types/resource_table/resource_icon_group.h"
namespace {
// Icon priority list

View File

@ -68,12 +68,9 @@ struct VersionInfoHeader
} // anonymous namespace
namespace retdec {
namespace fileformat {
/**
* Constructor
*/

View File

@ -61,6 +61,5 @@ void VisualBasicExtern::setApiName(const std::string &aName)
apiName = aName;
}
} // namespace fileformat
} // namespace retdec

View File

@ -10,7 +10,6 @@
#include "retdec/utils/conversion.h"
#include "retdec/fileformat/types/visual_basic/visual_basic_info.h"
using namespace retdec::utils;
namespace retdec {
@ -768,6 +767,5 @@ std::string VisualBasicInfo::guidToStr(const std::uint8_t data[16])
return r1 + "-" + r2 + "-" + r3 + "-" + r4 + "-" + r5;
}
} // namespace fileformat
} // namespace retdec

View File

@ -70,7 +70,5 @@ void VisualBasicObject::addMethod(const std::string &method)
methods.push_back(method);
}
} // namespace fileformat
} // namespace retdec

View File

@ -1118,13 +1118,6 @@ std::string FileInformation::getVisualBasicObjectTableHashSha256() const
return visualBasicInfo.getObjectTableHashSha256();
}
/**
* Get type of related PDB file
* @return Type of related PDB file

View File

@ -195,7 +195,6 @@ class FileInformation
std::string getVisualBasicObjectTableHashSha256() const;
/// @}
/// @name Getters of @a pdbInfo
/// @{
std::string getPdbType() const;

View File

@ -133,5 +133,4 @@ bool TlsInfo::isUsed() const
return tlsInfo != nullptr;
}
} // namespace fileinfo

View File

@ -412,5 +412,4 @@ bool VisualBasicInfo::isPcode() const
return visualBasicInfo ? visualBasicInfo->isPcode() : false;
}
} // namespace fileinfo

View File

@ -765,6 +765,5 @@ void BIRWriter::visit(ShPtr<UnknownType> type) {
out << "type_unknown";
}
} // namespace llvmir2hll
} // namespace retdec

View File

@ -92,7 +92,6 @@ bool DeadLocalAssignOptimizer::canBeOptimized(ShPtr<Variable> var,
return false;
}
// The use cannot contain any function calls.
if (useData->hasCalls()) {
return false;

View File

@ -8,7 +8,6 @@
#include "unpackertool/plugins/upx/decompressors/decompressor.h"
namespace retdec {
namespace unpackertool {
namespace upx {

View File

@ -1,2 +1 @@

View File

@ -3442,7 +3442,6 @@ TEST_F(ParamReturnTests, x86FastcallBasic)
checkModuleAgainstExpectedIr(exp);
}
TEST_F(ParamReturnTests, x86FastcallLargeTypeCatch)
{
parseInput(R"(

View File

@ -276,7 +276,6 @@ TEST_P(Capstone2LlvmIrTranslatorArm64Tests, ARM64_INS_ADC32_flags)
EXPECT_NO_VALUE_CALLED();
}
TEST_P(Capstone2LlvmIrTranslatorArm64Tests, ARM64_INS_ADC_flags)
{
setRegisters({
@ -6018,7 +6017,6 @@ TEST_P(Capstone2LlvmIrTranslatorArm64Tests, ARM64_INS_UXTH_r_r_false)
EXPECT_NO_VALUE_CALLED();
}
//
// ARM64_INS_TBNZ
//
@ -7496,7 +7494,6 @@ TEST_P(Capstone2LlvmIrTranslatorArm64Tests, ARM64_INS_FMAX_d_d_d)
EXPECT_NO_VALUE_CALLED();
}
TEST_P(Capstone2LlvmIrTranslatorArm64Tests, ARM64_INS_FMAX_d_d_d_1)
{
setRegisters({
@ -7611,7 +7608,6 @@ TEST_P(Capstone2LlvmIrTranslatorArm64Tests, ARM64_INS_FMIN_d_d_d)
EXPECT_NO_VALUE_CALLED();
}
TEST_P(Capstone2LlvmIrTranslatorArm64Tests, ARM64_INS_FMIN_d_d_d_1)
{
setRegisters({