Files
PraisonAIUI/tests/test_feature_approvals.py
a433c483c1 fix: document bootstrap entrypoints in examples (fixes #71) (#96)
* feat: standardize bootstrap entrypoint to 'aiui run app.py' across examples

Standardizes platform bootstrap patterns across examples per issue #71:

- Update examples README table to use 'aiui run app.py' consistently
- Update docstrings in examples 10, 12, 19-21 to show 'aiui run' instead of 'python app.py'
- Remove fragmented bootstrap approaches (uvicorn.run, asyncio patterns)
- Enforce single bootstrap SSOT as designed in CLI

Co-authored-by: Mervin Praison <[email protected]>

* feat: consolidate bootstrap entrypoints - auto-detect gateway apps (fixes #71)

- Add bootstrap detection in CLI run command
- Auto-detect gateway pattern (async main + AIUIGateway imports)
- Auto-switch to praisonai backend for gateway apps
- Delegate to user-defined main() when present
- Remove sys.path hacks from example 14
- Update examples README to show unified aiui run entrypoint
- Add BOOTSTRAP.md documentation for migration patterns

Co-authored-by: Mervin Praison <[email protected]>

* fix: resolve critical bootstrap entrypoint issues

- Fix AST parsing bug in gateway auto-detection (cli.py:1419)
- Revert background bots (email-bot, agentmail-bot) to python app.py
- Revert custom UI apps (agent-dashboard) to python app.py
- Update README.md to reflect correct run commands
- Fix import formatting and remove unused imports

These changes ensure that:
1. Gateway auto-detection works correctly by properly checking ast.alias.name
2. Background bots execute their __main__ blocks and don't start unnecessary web servers
3. Custom UI apps register their custom routes in __main__ blocks
4. Documentation matches actual working run commands

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-authored-by: Mervin Praison <[email protected]>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Mervin Praison <[email protected]>
Co-authored-by: Mervin Praison <[email protected]>
Co-authored-by: Cursor <[email protected]>
2026-06-15 16:36:35 +01:00

105 lines
3.4 KiB
Python

"""Per-feature test: Approvals — API + CLI parity."""
import os
import sys
sys.path.insert(0, os.path.join(os.path.dirname(__file__), "..", "src"))
from starlette.testclient import TestClient
from praisonaiui.server import create_app
client = TestClient(create_app())
passed = failed = 0
errors = []
def check(name, r, status=200, keys=None):
global passed, failed
try:
assert r.status_code == status, f"Expected {status}, got {r.status_code}: {r.text[:200]}"
if keys:
data = r.json()
for k in keys:
assert k in data, f"Missing '{k}' in {list(data.keys())}"
passed += 1
print(f" ✓ {name}")
except AssertionError as e:
failed += 1; errors.append(f" ✗ {name}: {e}"); print(f" ✗ {name}: {e}")
print("\n── Approvals: API Tests ──")
# Empty list
check("GET /api/approvals (empty)", client.get("/api/approvals"), 200, ["approvals", "count"])
assert client.get("/api/approvals").json()["count"] == 0
# Create
r = client.post("/api/approvals", json={
"tool_name": "run_code", "arguments": {"code": "1+1"},
"risk_level": "low", "agent_name": "MathBot",
})
check("POST create", r, 201, ["id", "status", "tool_name"])
aid = r.json()["id"]
assert r.json()["status"] == "pending"
# Get by ID
check("GET /:id", client.get(f"/api/approvals/{aid}"), 200, ["id", "tool_name"])
# Filter pending
r = client.get("/api/approvals?status=pending")
check("GET ?status=pending", r, 200, ["approvals"])
assert r.json()["count"] == 1
# Resolve — approve
r = client.post(f"/api/approvals/{aid}/resolve", json={"approved": True, "reason": "safe"})
check("POST resolve (approve)", r, 200, ["status", "resolved_at"])
assert r.json()["status"] == "approved"
# Verify resolved
r = client.get("/api/approvals?status=resolved")
check("GET ?status=resolved", r, 200)
assert r.json()["count"] == 1
# Pending should now be 0
r = client.get("/api/approvals?status=pending")
check("GET ?status=pending (empty after resolve)", r, 200)
assert r.json()["count"] == 0
# Create + deny
r2 = client.post("/api/approvals", json={"tool_name": "delete_file", "risk_level": "high"})
aid2 = r2.json()["id"]
r = client.post(f"/api/approvals/{aid2}/resolve", json={"approved": False, "reason": "too risky"})
check("POST resolve (deny)", r, 200)
assert r.json()["status"] == "denied"
# 404 on nonexistent
check("POST resolve nonexistent → 404", client.post("/api/approvals/xxx/resolve", json={"approved": True}), 404)
check("GET nonexistent → 404", client.get("/api/approvals/nope"), 404)
# All filter
r = client.get("/api/approvals?status=all")
check("GET ?status=all", r, 200)
assert r.json()["count"] == 2
# Config endpoint
check("GET /api/approvals/config", client.get("/api/approvals/config"), 200)
print("\n── Approvals: CLI Parity ──")
from typer.testing import CliRunner
from praisonaiui.cli import app as cli_app
runner = CliRunner()
# CLI list (against running server — will fail since no server, but verify Typer registration)
result = runner.invoke(cli_app, ["approval", "--help"])
check("CLI approval --help", type("R", (), {"status_code": 200 if result.exit_code == 0 else 500, "json": lambda: {}, "text": result.output})(), 200)
assert "list" in result.output
assert "pending" in result.output
assert "resolve" in result.output
print(f"\n{'='*50}")
print(f" Approvals: {passed} passed, {failed} failed")
print(f"{'='*50}")
if errors:
for e in errors: print(e)
sys.exit(1)