Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 22:23:50 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #263] [CLOSED] Feature/devcontainer #3275

New Issue
Closed
opened 2026-02-22 18:33:26 -05:00 by yindo · 0 comments
yindo commented 2026-02-22 18:33:26 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/263
Author: @franzbischoff
Created: 10/1/2023
Status: ❌ Closed

Base: master ← Head: feature/devcontainer

📝 Commits (10+)

📊 Changes

221 files changed (+14198 additions, -14314 deletions)

View changed files

➕ .devcontainer/README.md (+75 -0)
➕ .devcontainer/devcontainer.json (+164 -0)
📝 .dockerignore (+9 -8)
📝 .editorconfig (+9 -4)
📝 .gitignore (+1 -0)
➕ .prettierignore (+12 -0)
➕ .prettierrc (+38 -0)
➕ .vscode/launch.json (+59 -0)
📝 .vscode/settings.json (+3 -6)
➕ .vscode/tasks.json (+96 -0)
📝 LICENSE (+1 -1)
📝 README.md (+27 -15)
📝 SECURITY.md (+0 -1)
📝 clean.sh (+0 -0)
📝 cloud-deployments/aws/cloudformation/DEPLOY.md (+17 -12)
📝 cloud-deployments/aws/cloudformation/aws_build_from_source_no_credentials.json (+4 -10)
➕ cloud-deployments/aws/cloudformation/aws_https_instructions.md (+122 -0)
📝 cloud-deployments/aws/cloudformation/cf_template.template (+2 -2)
📝 cloud-deployments/digitalocean/terraform/DEPLOY.md (+16 -13)
📝 cloud-deployments/gcp/deployment/DEPLOY.md (+16 -13)

...and 80 more files

📄 Description

This PR does the following:

  • Added configuration for creating a devcontainer with the environment ready for starting server:dev and frontend:dev
  • Changes the location of eslint config in order to be global. In fact, Eslint is mostly useful when employed with the IDE extension. The package lint script uses prettier, not eslint.
  • Creates a prettier config file and ignore file, so both CLI and IDE extensions have the same formatting rules.
  • Tailwind is now integrated into the IDE.

Adjustments:

  • settings.json needs the eslint config, so VSCode doesn't complain about the old format.
  • package-lock.json is removed in favor of yarn.lock. The project uses yarn, not npm.
  • Some adjustments were made on all "package.json" files.
  • Added SERVER_ADDRESS in server/.env.example to fix a bug when using WSL.

Others:

  • Most (99%) of changes in files are lint/format, not code changes.
  • The markdown files are also formatted by the IDE, and CLI if done manually. Some markdown files had to be reviewed because the original code (that wasn't following the standard) was misformatted by prettier. From now on, these files can be re-formatted normally.
  • Dockerfile wasn't changed, just linted/reformatted
  • The "collector" folder and the Python code are still the same. In the next PR I'll think about it.

Final words:

These standardizations of code format don't require to use of the devcontainer. One can still run the server and frontend and configure the extensions by hand in the system environment. Nevertheless, the devcontainer is a safer and quicker way to start developing.

I've tested in several ways and it is working. But who knows... 🤞

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/263 **Author:** [@franzbischoff](https://github.com/franzbischoff) **Created:** 10/1/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `feature/devcontainer` --- ### 📝 Commits (10+) - [`70255ca`](https://github.com/Mintplex-Labs/anything-llm/commit/70255ca8d158560a062f21a4dd048d7247a0f6ba) devconfig - [`0f60758`](https://github.com/Mintplex-Labs/anything-llm/commit/0f60758691cf76d12c8ee8da7d08226c8fd372d5) dev - [`3e2b31d`](https://github.com/Mintplex-Labs/anything-llm/commit/3e2b31db943d7bab3f77564f13eb14c1c039a255) Second stage - [`33b03b9`](https://github.com/Mintplex-Labs/anything-llm/commit/33b03b9134da513318580a85a66faa11cab850ff) prettier, eslint, tailwindcss, hadolint ok - [`a830275`](https://github.com/Mintplex-Labs/anything-llm/commit/a830275bff07424dc5ffcc7a19d93bb8693989e1) pre-release - [`6e1819f`](https://github.com/Mintplex-Labs/anything-llm/commit/6e1819f7f2638874d59af08ff3511cead51978a0) pre-release - [`c3540f5`](https://github.com/Mintplex-Labs/anything-llm/commit/c3540f582bb052b848e9c2b02be261bda8710f5a) pre-release - [`5fd78e1`](https://github.com/Mintplex-Labs/anything-llm/commit/5fd78e1db40141242a8ec36b2b07233c3035da71) merge with last updates - [`4c39904`](https://github.com/Mintplex-Labs/anything-llm/commit/4c399045f5b6a655eaa4cf5859e3a5e63cbe17ff) pre-release - [`bfb5f37`](https://github.com/Mintplex-Labs/anything-llm/commit/bfb5f37f3b9768454c90f1abb78e5e17978b96dc) pre-release ### 📊 Changes **221 files changed** (+14198 additions, -14314 deletions) <details> <summary>View changed files</summary> ➕ `.devcontainer/README.md` (+75 -0) ➕ `.devcontainer/devcontainer.json` (+164 -0) 📝 `.dockerignore` (+9 -8) 📝 `.editorconfig` (+9 -4) 📝 `.gitignore` (+1 -0) ➕ `.prettierignore` (+12 -0) ➕ `.prettierrc` (+38 -0) ➕ `.vscode/launch.json` (+59 -0) 📝 `.vscode/settings.json` (+3 -6) ➕ `.vscode/tasks.json` (+96 -0) 📝 `LICENSE` (+1 -1) 📝 `README.md` (+27 -15) 📝 `SECURITY.md` (+0 -1) 📝 `clean.sh` (+0 -0) 📝 `cloud-deployments/aws/cloudformation/DEPLOY.md` (+17 -12) 📝 `cloud-deployments/aws/cloudformation/aws_build_from_source_no_credentials.json` (+4 -10) ➕ `cloud-deployments/aws/cloudformation/aws_https_instructions.md` (+122 -0) 📝 `cloud-deployments/aws/cloudformation/cf_template.template` (+2 -2) 📝 `cloud-deployments/digitalocean/terraform/DEPLOY.md` (+16 -13) 📝 `cloud-deployments/gcp/deployment/DEPLOY.md` (+16 -13) _...and 80 more files_ </details> ### 📄 Description This PR does the following: - Added configuration for creating a devcontainer with the environment ready for starting server:dev and frontend:dev - Changes the location of eslint config in order to be global. In fact, Eslint is mostly useful when employed with the IDE extension. The package lint script uses prettier, not eslint. - Creates a prettier config file and ignore file, so both CLI and IDE extensions have the same formatting rules. - Tailwind is now integrated into the IDE. Adjustments: - settings.json needs the eslint config, so VSCode doesn't complain about the old format. - package-lock.json is removed in favor of yarn.lock. The project uses yarn, not npm. - Some adjustments were made on all "package.json" files. - Added SERVER_ADDRESS in server/.env.example to fix a bug when using WSL. Others: - Most (99%) of changes in files are lint/format, not code changes. - The markdown files are also formatted by the IDE, and CLI if done manually. Some markdown files had to be reviewed because the original code (that wasn't following the standard) was misformatted by prettier. From now on, these files can be re-formatted normally. - Dockerfile wasn't changed, just linted/reformatted - The "collector" folder and the Python code are still the same. In the next PR I'll think about it. Final words: These standardizations of code format don't require to use of the devcontainer. One can still run the server and frontend and configure the extensions by hand in the system environment. Nevertheless, the devcontainer is a safer and quicker way to start developing. I've tested in several ways and it is working. But who knows... 🤞 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:33:26 -05:00
yindo closed this issue 2026-02-22 18:33:26 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#3275
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?