Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 14:13:35 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #609] [MERGED] Update Ubuntu base image and improve Dockerfile #3422

New Issue
Closed
opened 2026-02-22 18:33:45 -05:00 by yindo · 0 comments
yindo commented 2026-02-22 18:33:45 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/609
Author: @franzbischoff
Created: 1/16/2024
Status: ✅ Merged
Merged: 3/6/2024
Merged by: @timothycarambat

Base: master ← Head: feature/dockerfile

📝 Commits (10+)

  • 2c7da44 Update Ubuntu base image and improve Dockerfile
  • ec49536 Add unzip to Docker image dependencies
  • 68b5c25 Merge branch 'Mintplex-Labs:master' into feature/dockerfile
  • c7b6e15 Merge branch 'Mintplex-Labs:master' into feature/dockerfile
  • c0d1aee Merge branch 'Mintplex-Labs:master' into feature/dockerfile
  • cfcb883 reset tabs
  • 766d515 Merge branch 'Mintplex-Labs:master' into feature/dockerfile
  • 812c159 formalized lint rules for hadolint. however the Docker formatting is being handled by MS Docker extension which doesn't indent code as expected. WIP.
  • 8050e36 found a workaround to keep formatting
  • caea114 Merge branch 'Mintplex-Labs:master' into feature/dockerfile

📊 Changes

5 files changed (+62 additions, -30 deletions)

View changed files

➕ .hadolint.yaml (+8 -0)
📝 .vscode/settings.json (+3 -2)
📝 docker/Dockerfile (+40 -18)
📝 docker/docker-entrypoint.sh (+6 -5)
📝 docker/docker-healthcheck.sh (+5 -5)

📄 Description

robustness

Upgraded the base Ubuntu image to the latest version to incorporate current security and package updates. Enhanced Dockerfile by introducing pipefail shell option to ensure any step in a pipe sequence failing will fail the entire pipeline, increasing build reliability. Refactored user creation commands for clarity and consistency and removed unnecessary unzip and git installations. Simplified RUN instructions in the Dockerfile to facilitate maintenance and potential readability. Adjusted the execution permission setting of entrypoint and healthcheck scripts to be more concise.

Normalized quoting and whitespace within RUN commands and shell scripts for consistency across the codebase. Ensured proper ownership of copied files at build time to prevent potential permission issues during container startup. Shifted to WORKDIR instructions for setting the working directory instead of using 'cd' for better readability and Docker best practices.

Resolved missing newline characters at the end of shell scripts which follows common conventions and aids in file concatenation.

These changes contribute to the stabilization and optimization of the Docker build process, which should result in more consistent and reliable builds for the AnythingLLM project.

Pull Request Type

  • ♻️ refactor
  • 💄 style

Relevant Issues

What is in this change?

Describe the changes in this PR that are impactful to the repo.

Additional Information

Add any other context about the Pull Request here that was not captured above.

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/609 **Author:** [@franzbischoff](https://github.com/franzbischoff) **Created:** 1/16/2024 **Status:** ✅ Merged **Merged:** 3/6/2024 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `feature/dockerfile` --- ### 📝 Commits (10+) - [`2c7da44`](https://github.com/Mintplex-Labs/anything-llm/commit/2c7da4470c32eedcefe865fbe9135b1a0d4aa9ab) Update Ubuntu base image and improve Dockerfile - [`ec49536`](https://github.com/Mintplex-Labs/anything-llm/commit/ec495362b3610796483559339dc6baf2e637d6ef) Add unzip to Docker image dependencies - [`68b5c25`](https://github.com/Mintplex-Labs/anything-llm/commit/68b5c2589f8e85a3b47ffd487b28eb64bd8ba49d) Merge branch 'Mintplex-Labs:master' into feature/dockerfile - [`c7b6e15`](https://github.com/Mintplex-Labs/anything-llm/commit/c7b6e1556da7e36cf99632ad58e617ea2e6c2215) Merge branch 'Mintplex-Labs:master' into feature/dockerfile - [`c0d1aee`](https://github.com/Mintplex-Labs/anything-llm/commit/c0d1aee2885171bb900802a29d521761b3c63ba2) Merge branch 'Mintplex-Labs:master' into feature/dockerfile - [`cfcb883`](https://github.com/Mintplex-Labs/anything-llm/commit/cfcb883412e41ab45efd26c949086ca81d026565) reset tabs - [`766d515`](https://github.com/Mintplex-Labs/anything-llm/commit/766d515970ee67868ead73620f326656047584dc) Merge branch 'Mintplex-Labs:master' into feature/dockerfile - [`812c159`](https://github.com/Mintplex-Labs/anything-llm/commit/812c1591cbd98c9dbd1b9f7bec11561596b018ce) formalized lint rules for hadolint. however the Docker formatting is being handled by MS Docker extension which doesn't indent code as expected. WIP. - [`8050e36`](https://github.com/Mintplex-Labs/anything-llm/commit/8050e36148e6be48c9b9eaa5c5e00c8f865aab33) found a workaround to keep formatting - [`caea114`](https://github.com/Mintplex-Labs/anything-llm/commit/caea1147e96b80ba2838c5da0ccad5f500e68b41) Merge branch 'Mintplex-Labs:master' into feature/dockerfile ### 📊 Changes **5 files changed** (+62 additions, -30 deletions) <details> <summary>View changed files</summary> ➕ `.hadolint.yaml` (+8 -0) 📝 `.vscode/settings.json` (+3 -2) 📝 `docker/Dockerfile` (+40 -18) 📝 `docker/docker-entrypoint.sh` (+6 -5) 📝 `docker/docker-healthcheck.sh` (+5 -5) </details> ### 📄 Description robustness Upgraded the base Ubuntu image to the latest version to incorporate current security and package updates. Enhanced Dockerfile by introducing pipefail shell option to ensure any step in a pipe sequence failing will fail the entire pipeline, increasing build reliability. Refactored user creation commands for clarity and consistency and removed unnecessary unzip and git installations. Simplified RUN instructions in the Dockerfile to facilitate maintenance and potential readability. Adjusted the execution permission setting of entrypoint and healthcheck scripts to be more concise. Normalized quoting and whitespace within RUN commands and shell scripts for consistency across the codebase. Ensured proper ownership of copied files at build time to prevent potential permission issues during container startup. Shifted to WORKDIR instructions for setting the working directory instead of using 'cd' for better readability and Docker best practices. Resolved missing newline characters at the end of shell scripts which follows common conventions and aids in file concatenation. These changes contribute to the stabilization and optimization of the Docker build process, which should result in more consistent and reliable builds for the AnythingLLM project. ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [x] ♻️ refactor - [X] 💄 style ### Relevant Issues ### What is in this change? Describe the changes in this PR that are impactful to the repo. ### Additional Information Add any other context about the Pull Request here that was not captured above. ### Developer Validations <!-- All of the applicable items should be checked. --> - [x] I ran `yarn lint` from the root of the repo & committed changes - [x] Relevant documentation has been updated - [x] I have tested my code functionality - [x] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:33:45 -05:00
yindo closed this issue 2026-02-22 18:33:45 -05:00
yindo changed title from [PR #609] Update Ubuntu base image and improve Dockerfile to [PR #609] [MERGED] Update Ubuntu base image and improve Dockerfile 2026-06-05 15:13:20 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#3422
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?