Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 14:13:35 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #620] [MERGED] chore: Better VectorDb and Embedder error messages #3426

New Issue
Closed
opened 2026-02-22 18:33:45 -05:00 by yindo · 0 comments
yindo commented 2026-02-22 18:33:45 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/620
Author: @timothycarambat
Created: 1/18/2024
Status: ✅ Merged
Merged: 1/18/2024
Merged by: @timothycarambat

Base: master ← Head: vector-db-error-messages

📝 Commits (2)

  • 9fa182a chore: propogate embedder and vectordb errors during document mutations
  • 272cc9d add default value for errors on addDocuments

📊 Changes

13 files changed (+77 additions, -47 deletions)

View changed files

📝 frontend/src/index.css (+4 -0)
📝 server/endpoints/workspaces.js (+5 -3)
📝 server/models/documents.js (+11 -4)
📝 server/utils/EmbeddingEngines/azureOpenAi/index.js (+12 -4)
📝 server/utils/EmbeddingEngines/localAi/index.js (+12 -4)
📝 server/utils/EmbeddingEngines/openAi/index.js (+12 -4)
📝 server/utils/vectorDbProviders/chroma/index.js (+3 -4)
📝 server/utils/vectorDbProviders/lance/index.js (+3 -4)
📝 server/utils/vectorDbProviders/milvus/index.js (+3 -4)
📝 server/utils/vectorDbProviders/pinecone/index.js (+3 -4)
📝 server/utils/vectorDbProviders/qdrant/index.js (+3 -4)
📝 server/utils/vectorDbProviders/weaviate/index.js (+3 -4)
📝 server/utils/vectorDbProviders/zilliz/index.js (+3 -4)

📄 Description

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

What is in this change?

When a document is failed to embed or is failed to be inserted into a vector db we return a single generic error message that does not inform the user of why an error has occurred.

Now we can return more descriptive error messages that can at least help determine the exact location and provider that caused a document to fail to be inserted into a workspace.

Additional Information

Updated toast messages to now support \n newlines in the window.

Developer Validations

  • Test with all embedders + vector databases.
  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/620 **Author:** [@timothycarambat](https://github.com/timothycarambat) **Created:** 1/18/2024 **Status:** ✅ Merged **Merged:** 1/18/2024 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `vector-db-error-messages` --- ### 📝 Commits (2) - [`9fa182a`](https://github.com/Mintplex-Labs/anything-llm/commit/9fa182a11123f8c01e374554d2c522702e6f258c) chore: propogate embedder and vectordb errors during document mutations - [`272cc9d`](https://github.com/Mintplex-Labs/anything-llm/commit/272cc9d2ebb1d48f9ba209452d81156f8da9df94) add default value for errors on addDocuments ### 📊 Changes **13 files changed** (+77 additions, -47 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/index.css` (+4 -0) 📝 `server/endpoints/workspaces.js` (+5 -3) 📝 `server/models/documents.js` (+11 -4) 📝 `server/utils/EmbeddingEngines/azureOpenAi/index.js` (+12 -4) 📝 `server/utils/EmbeddingEngines/localAi/index.js` (+12 -4) 📝 `server/utils/EmbeddingEngines/openAi/index.js` (+12 -4) 📝 `server/utils/vectorDbProviders/chroma/index.js` (+3 -4) 📝 `server/utils/vectorDbProviders/lance/index.js` (+3 -4) 📝 `server/utils/vectorDbProviders/milvus/index.js` (+3 -4) 📝 `server/utils/vectorDbProviders/pinecone/index.js` (+3 -4) 📝 `server/utils/vectorDbProviders/qdrant/index.js` (+3 -4) 📝 `server/utils/vectorDbProviders/weaviate/index.js` (+3 -4) 📝 `server/utils/vectorDbProviders/zilliz/index.js` (+3 -4) </details> ### 📄 Description ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [ ] ✨ feat - [x] 🐛 fix - [x] ♻️ refactor - [ ] 💄 style - [x] 🔨 chore - [ ] 📝 docs ### What is in this change? When a document is failed to embed or is failed to be inserted into a vector db we return a single generic error message that does not inform the user of why an error has occurred. Now we can return more descriptive error messages that can at least help determine the exact location and provider that caused a document to fail to be inserted into a workspace. ### Additional Information Updated `toast` messages to now support `\n` newlines in the window. ### Developer Validations - Test with all embedders + vector databases. <!-- All of the applicable items should be checked. --> - [x] I ran `yarn lint` from the root of the repo & committed changes - [x] Relevant documentation has been updated - [x] I have tested my code functionality - [x] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:33:45 -05:00
yindo closed this issue 2026-02-22 18:33:45 -05:00
yindo changed title from [PR #620] chore: Better VectorDb and Embedder error messages to [PR #620] [MERGED] chore: Better VectorDb and Embedder error messages 2026-06-05 15:13:22 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#3426
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?