Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 14:13:35 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #655] [MERGED] Patch lanceDB not deleting vectors from workspace #3445

New Issue
Closed
opened 2026-02-22 18:33:48 -05:00 by yindo · 0 comments
yindo commented 2026-02-22 18:33:48 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/655
Author: @timothycarambat
Created: 1/29/2024
Status: ✅ Merged
Merged: 1/29/2024
Merged by: @timothycarambat

Base: master ← Head: 594-lancedb-not-removing-embeddings

📝 Commits (1)

  • 8db66c2 patch lanceDB not deleting vectors from workspace

📊 Changes

2 files changed (+4 additions, -1 deletions)

View changed files

📝 server/models/documents.js (+3 -0)
📝 server/utils/vectorDbProviders/lance/index.js (+1 -1)

📄 Description

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #594

What is in this change?

  • documentVectors self-sanitize on delete of parent document
  • patch lanceDB not deleting vectors from workspace

RCA:
When adding a new document to a workspace for lanceDB that also created the table, the submissions item would have a different id given to it by the collector that would overwrite the known document id that was stored in the database - making deletion of it impossible.

This only impacted vectors that were totally new to the system (uncached) as cached documents would be able to be properly tracked.

If users have this issue, the easiest full solve is just to delete the workspace and it will fully remove the vectors. They will persist in the DB, but be orphaned which is a negligible impact.

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/655 **Author:** [@timothycarambat](https://github.com/timothycarambat) **Created:** 1/29/2024 **Status:** ✅ Merged **Merged:** 1/29/2024 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `594-lancedb-not-removing-embeddings` --- ### 📝 Commits (1) - [`8db66c2`](https://github.com/Mintplex-Labs/anything-llm/commit/8db66c2e944c57755395f20e022b862e79c311e8) patch lanceDB not deleting vectors from workspace ### 📊 Changes **2 files changed** (+4 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `server/models/documents.js` (+3 -0) 📝 `server/utils/vectorDbProviders/lance/index.js` (+1 -1) </details> ### 📄 Description ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [ ] ✨ feat - [x] 🐛 fix - [ ] ♻️ refactor - [ ] 💄 style - [ ] 🔨 chore - [ ] 📝 docs ### Relevant Issues <!-- Use "resolves #xxx" to auto resolve on merge. Otherwise, please use "connect #xxx" --> resolves #594 ### What is in this change? - documentVectors self-sanitize on delete of parent document - patch lanceDB not deleting vectors from workspace RCA: When adding a new document to a workspace for lanceDB that also created the table, the `submissions` item would have a different `id` given to it by the `collector` that would overwrite the known document id that was stored in the database - making deletion of it impossible. This only impacted vectors that were totally new to the system (uncached) as cached documents would be able to be properly tracked. If users have this issue, the easiest full solve is just to delete the workspace and it will fully remove the vectors. They will persist in the DB, but be orphaned which is a negligible impact. ### Developer Validations <!-- All of the applicable items should be checked. --> - [x] I ran `yarn lint` from the root of the repo & committed changes - [ ] Relevant documentation has been updated - [x] I have tested my code functionality - [x] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:33:48 -05:00
yindo closed this issue 2026-02-22 18:33:48 -05:00
yindo changed title from [PR #655] Patch lanceDB not deleting vectors from workspace to [PR #655] [MERGED] Patch lanceDB not deleting vectors from workspace 2026-06-05 15:13:27 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#3445
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?