Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 14:13:35 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #660] [MERGED] [FIX]: Fix Chinese characters causing empty workspace slug #3448

New Issue
Closed
opened 2026-02-22 18:33:48 -05:00 by yindo · 0 comments
yindo commented 2026-02-22 18:33:48 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/660
Author: @shatfield4
Created: 1/31/2024
Status: ✅ Merged
Merged: 1/31/2024
Merged by: @timothycarambat

Base: master ← Head: 659-bug-when-creating-a-workspace-if-the-name-of-the-space-contains-chinese-characters-the-corresponding-number-for-the-space-is-not-generated-and-it-is-not-possible-to-navigate-to-the-new-spaces-interface-as-shown-in-the-figure

📝 Commits (1)

  • 4e08771 if slug is empty on create workspace, generate a uuid as the workspace slug

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 server/models/workspace.js (+2 -0)

📄 Description

…e slug

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #659

What is in this change?

Describe the changes in this PR that are impactful to the repo.

  • Bug fix for when chinese characters are provided as a workspace name, this would cause the workspace slug to be empty

Additional Information

Add any other context about the Pull Request here that was not captured above.

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/660 **Author:** [@shatfield4](https://github.com/shatfield4) **Created:** 1/31/2024 **Status:** ✅ Merged **Merged:** 1/31/2024 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `659-bug-when-creating-a-workspace-if-the-name-of-the-space-contains-chinese-characters-the-corresponding-number-for-the-space-is-not-generated-and-it-is-not-possible-to-navigate-to-the-new-spaces-interface-as-shown-in-the-figure` --- ### 📝 Commits (1) - [`4e08771`](https://github.com/Mintplex-Labs/anything-llm/commit/4e08771b7d78b88fa7a6c8001340cf44a02c7672) if slug is empty on create workspace, generate a uuid as the workspace slug ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `server/models/workspace.js` (+2 -0) </details> ### 📄 Description …e slug ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [ ] ✨ feat - [x] 🐛 fix - [ ] ♻️ refactor - [ ] 💄 style - [ ] 🔨 chore - [ ] 📝 docs ### Relevant Issues <!-- Use "resolves #xxx" to auto resolve on merge. Otherwise, please use "connect #xxx" --> resolves #659 ### What is in this change? Describe the changes in this PR that are impactful to the repo. - Bug fix for when chinese characters are provided as a workspace name, this would cause the workspace slug to be empty ### Additional Information Add any other context about the Pull Request here that was not captured above. ### Developer Validations <!-- All of the applicable items should be checked. --> - [x] I ran `yarn lint` from the root of the repo & committed changes - [x] Relevant documentation has been updated - [x] I have tested my code functionality - [x] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:33:48 -05:00
yindo closed this issue 2026-02-22 18:33:48 -05:00
yindo changed title from [PR #660] [FIX]: Fix Chinese characters causing empty workspace slug to [PR #660] [MERGED] [FIX]: Fix Chinese characters causing empty workspace slug 2026-06-05 15:13:28 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#3448
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?