Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 14:13:35 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #683] [MERGED] [CHORE] Hide security tab on Settings Sidebar/Refactor SettingsSidebar component #3452

New Issue
Closed
opened 2026-02-22 18:33:48 -05:00 by yindo · 0 comments
yindo commented 2026-02-22 18:33:48 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/683
Author: @shatfield4
Created: 2/6/2024
Status: ✅ Merged
Merged: 2/7/2024
Merged by: @timothycarambat

Base: master ← Head: 682-feat-hide-security-tab-on-setting-sidbar

📝 Commits (5)

  • dc19ddf hide security setting in settings sidebar when in multiusermode
  • f189072 rebase
  • c28eb74 refactor sidebar to handle mobile view inside SettingsSidebar component
  • 92d406c Merge branch '682-feat-hide-security-tab-on-setting-sidbar' of github.com:Mintplex-Labs/anything-llm into 682-feat-hide-security-tab-on-setting-sidbar
  • 91f8940 forgot eventlogs on sidebar

📊 Changes

18 files changed (+291 additions, -448 deletions)

View changed files

📝 frontend/src/components/SettingsSidebar/index.jsx (+257 -396)
📝 frontend/src/pages/Admin/Invitations/index.jsx (+2 -3)
📝 frontend/src/pages/Admin/Logging/index.jsx (+2 -3)
📝 frontend/src/pages/Admin/System/index.jsx (+2 -3)
📝 frontend/src/pages/Admin/Users/index.jsx (+2 -3)
📝 frontend/src/pages/Admin/Workspaces/index.jsx (+2 -3)
📝 frontend/src/pages/GeneralSettings/ApiKeys/index.jsx (+2 -3)
📝 frontend/src/pages/GeneralSettings/Appearance/index.jsx (+2 -4)
📝 frontend/src/pages/GeneralSettings/Chats/index.jsx (+2 -3)
📝 frontend/src/pages/GeneralSettings/DataConnectors/Connectors/Github/index.jsx (+2 -3)
📝 frontend/src/pages/GeneralSettings/DataConnectors/Connectors/Youtube/index.jsx (+2 -3)
📝 frontend/src/pages/GeneralSettings/DataConnectors/index.jsx (+2 -3)
📝 frontend/src/pages/GeneralSettings/EmbedChats/index.jsx (+2 -3)
📝 frontend/src/pages/GeneralSettings/EmbedConfigs/index.jsx (+2 -3)
📝 frontend/src/pages/GeneralSettings/EmbeddingPreference/index.jsx (+2 -3)
📝 frontend/src/pages/GeneralSettings/LLMPreference/index.jsx (+2 -3)
📝 frontend/src/pages/GeneralSettings/Security/index.jsx (+2 -3)
📝 frontend/src/pages/GeneralSettings/VectorDatabase/index.jsx (+2 -3)

📄 Description

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #682

What is in this change?

Describe the changes in this PR that are impactful to the repo.

  • When the instance is in multiusermode, we hide the security settings tab because there is no point in showing this screen since you cannot modify anything after multiusermode is enabled.
  • Refactor SettingsSidebar component so that we do not have a separate mobile sidebar anymore and render the same options on both.

Additional Information

Add any other context about the Pull Request here that was not captured above.

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/683 **Author:** [@shatfield4](https://github.com/shatfield4) **Created:** 2/6/2024 **Status:** ✅ Merged **Merged:** 2/7/2024 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `682-feat-hide-security-tab-on-setting-sidbar` --- ### 📝 Commits (5) - [`dc19ddf`](https://github.com/Mintplex-Labs/anything-llm/commit/dc19ddfa10f33193ee827ef4cb2ca1f16688efa9) hide security setting in settings sidebar when in multiusermode - [`f189072`](https://github.com/Mintplex-Labs/anything-llm/commit/f189072ce91fc4886fadc9c2723b477dc74129a0) rebase - [`c28eb74`](https://github.com/Mintplex-Labs/anything-llm/commit/c28eb74ae726c9cc930b70e2fd999c3b7d4e123c) refactor sidebar to handle mobile view inside SettingsSidebar component - [`92d406c`](https://github.com/Mintplex-Labs/anything-llm/commit/92d406c8baaf98fa472c5458226faaf35d2211c1) Merge branch '682-feat-hide-security-tab-on-setting-sidbar' of github.com:Mintplex-Labs/anything-llm into 682-feat-hide-security-tab-on-setting-sidbar - [`91f8940`](https://github.com/Mintplex-Labs/anything-llm/commit/91f89406a155d54fefdafbe5292c818e492424ae) forgot eventlogs on sidebar ### 📊 Changes **18 files changed** (+291 additions, -448 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/components/SettingsSidebar/index.jsx` (+257 -396) 📝 `frontend/src/pages/Admin/Invitations/index.jsx` (+2 -3) 📝 `frontend/src/pages/Admin/Logging/index.jsx` (+2 -3) 📝 `frontend/src/pages/Admin/System/index.jsx` (+2 -3) 📝 `frontend/src/pages/Admin/Users/index.jsx` (+2 -3) 📝 `frontend/src/pages/Admin/Workspaces/index.jsx` (+2 -3) 📝 `frontend/src/pages/GeneralSettings/ApiKeys/index.jsx` (+2 -3) 📝 `frontend/src/pages/GeneralSettings/Appearance/index.jsx` (+2 -4) 📝 `frontend/src/pages/GeneralSettings/Chats/index.jsx` (+2 -3) 📝 `frontend/src/pages/GeneralSettings/DataConnectors/Connectors/Github/index.jsx` (+2 -3) 📝 `frontend/src/pages/GeneralSettings/DataConnectors/Connectors/Youtube/index.jsx` (+2 -3) 📝 `frontend/src/pages/GeneralSettings/DataConnectors/index.jsx` (+2 -3) 📝 `frontend/src/pages/GeneralSettings/EmbedChats/index.jsx` (+2 -3) 📝 `frontend/src/pages/GeneralSettings/EmbedConfigs/index.jsx` (+2 -3) 📝 `frontend/src/pages/GeneralSettings/EmbeddingPreference/index.jsx` (+2 -3) 📝 `frontend/src/pages/GeneralSettings/LLMPreference/index.jsx` (+2 -3) 📝 `frontend/src/pages/GeneralSettings/Security/index.jsx` (+2 -3) 📝 `frontend/src/pages/GeneralSettings/VectorDatabase/index.jsx` (+2 -3) </details> ### 📄 Description ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [ ] ✨ feat - [ ] 🐛 fix - [x] ♻️ refactor - [ ] 💄 style - [ ] 🔨 chore - [ ] 📝 docs ### Relevant Issues <!-- Use "resolves #xxx" to auto resolve on merge. Otherwise, please use "connect #xxx" --> resolves #682 ### What is in this change? Describe the changes in this PR that are impactful to the repo. - When the instance is in multiusermode, we hide the security settings tab because there is no point in showing this screen since you cannot modify anything after multiusermode is enabled. - Refactor SettingsSidebar component so that we do not have a separate mobile sidebar anymore and render the same options on both. ### Additional Information Add any other context about the Pull Request here that was not captured above. ### Developer Validations <!-- All of the applicable items should be checked. --> - [x] I ran `yarn lint` from the root of the repo & committed changes - [x] Relevant documentation has been updated - [x] I have tested my code functionality - [x] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:33:48 -05:00
yindo closed this issue 2026-02-22 18:33:49 -05:00
yindo changed title from [PR #683] [CHORE] Hide security tab on Settings Sidebar/Refactor SettingsSidebar component to [PR #683] [MERGED] [CHORE] Hide security tab on Settings Sidebar/Refactor SettingsSidebar component 2026-06-05 15:13:30 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#3452
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?