Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 14:13:35 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #681] [MERGED] Fix white screen bug when deleting chats under Workspace Chats menu #3454

New Issue
Closed
opened 2026-02-22 18:33:49 -05:00 by yindo · 0 comments
yindo commented 2026-02-22 18:33:49 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/681
Author: @shatfield4
Created: 2/6/2024
Status: ✅ Merged
Merged: 2/6/2024
Merged by: @timothycarambat

Base: master ← Head: 669-bug-white-screen-after-deleting-a-workspace-chat-from-settings

📝 Commits (5)

  • 4defebc use filter instead of ref to delete row from workspace chat component on delete/fix backend invalid json error
  • f0e56b6 Merge branch 'master' into 669-bug-white-screen-after-deleting-a-workspace-chat-from-settings
  • a715435 remove ref from pagination on embed chats and fix white screen bug
  • 9519725 remove unneeded import
  • 129c9e3 normalize response object

📊 Changes

5 files changed (+21 additions, -19 deletions)

View changed files

📝 frontend/src/pages/GeneralSettings/Chats/ChatRow/index.jsx (+3 -8)
📝 frontend/src/pages/GeneralSettings/Chats/index.jsx (+7 -1)
📝 frontend/src/pages/GeneralSettings/EmbedChats/ChatRow/index.jsx (+3 -8)
📝 frontend/src/pages/GeneralSettings/EmbedChats/index.jsx (+7 -1)
📝 server/endpoints/system.js (+1 -1)

📄 Description

… on delete/fix backend invalid json error

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #669

What is in this change?

Describe the changes in this PR that are impactful to the repo.

  • Fix a bug where if we have more than 20 workspace chats and we delete a chat then click previous or next buttons, a white screen would show until we refresh the page
  • Changed from using a ref to delete the row to just filtering out the chats in the parent component

Additional Information

Add any other context about the Pull Request here that was not captured above.

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/681 **Author:** [@shatfield4](https://github.com/shatfield4) **Created:** 2/6/2024 **Status:** ✅ Merged **Merged:** 2/6/2024 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `669-bug-white-screen-after-deleting-a-workspace-chat-from-settings` --- ### 📝 Commits (5) - [`4defebc`](https://github.com/Mintplex-Labs/anything-llm/commit/4defebc4ceef4e65e49aa619160c7fa0edc3c913) use filter instead of ref to delete row from workspace chat component on delete/fix backend invalid json error - [`f0e56b6`](https://github.com/Mintplex-Labs/anything-llm/commit/f0e56b65cad8f4fb002c13e0bd3adbd52c9f9640) Merge branch 'master' into 669-bug-white-screen-after-deleting-a-workspace-chat-from-settings - [`a715435`](https://github.com/Mintplex-Labs/anything-llm/commit/a7154353bbb2d7e10928a4c24e698e6c205fa310) remove ref from pagination on embed chats and fix white screen bug - [`9519725`](https://github.com/Mintplex-Labs/anything-llm/commit/9519725324fba1904dc0501dea68f47959c8bd96) remove unneeded import - [`129c9e3`](https://github.com/Mintplex-Labs/anything-llm/commit/129c9e37d903c6c3a6c59e1bae79430b8f301786) normalize response object ### 📊 Changes **5 files changed** (+21 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/pages/GeneralSettings/Chats/ChatRow/index.jsx` (+3 -8) 📝 `frontend/src/pages/GeneralSettings/Chats/index.jsx` (+7 -1) 📝 `frontend/src/pages/GeneralSettings/EmbedChats/ChatRow/index.jsx` (+3 -8) 📝 `frontend/src/pages/GeneralSettings/EmbedChats/index.jsx` (+7 -1) 📝 `server/endpoints/system.js` (+1 -1) </details> ### 📄 Description … on delete/fix backend invalid json error ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [ ] ✨ feat - [x] 🐛 fix - [ ] ♻️ refactor - [ ] 💄 style - [ ] 🔨 chore - [ ] 📝 docs ### Relevant Issues <!-- Use "resolves #xxx" to auto resolve on merge. Otherwise, please use "connect #xxx" --> resolves #669 ### What is in this change? Describe the changes in this PR that are impactful to the repo. - Fix a bug where if we have more than 20 workspace chats and we delete a chat then click previous or next buttons, a white screen would show until we refresh the page - Changed from using a ref to delete the row to just filtering out the chats in the parent component ### Additional Information Add any other context about the Pull Request here that was not captured above. ### Developer Validations <!-- All of the applicable items should be checked. --> - [x] I ran `yarn lint` from the root of the repo & committed changes - [x] Relevant documentation has been updated - [x] I have tested my code functionality - [x] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:33:49 -05:00
yindo closed this issue 2026-02-22 18:33:49 -05:00
yindo changed title from [PR #681] Fix white screen bug when deleting chats under Workspace Chats menu to [PR #681] [MERGED] Fix white screen bug when deleting chats under Workspace Chats menu 2026-06-05 15:13:30 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#3454
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?