Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 14:13:35 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #723] [MERGED] Enforce name requirements for Zilliz/Milvus #3473

New Issue
Closed
opened 2026-02-22 18:33:51 -05:00 by yindo · 0 comments
yindo commented 2026-02-22 18:33:51 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/723
Author: @timothycarambat
Created: 2/14/2024
Status: ✅ Merged
Merged: 2/14/2024
Merged by: @timothycarambat

Base: master ← Head: 720-ensure-name-reqs-for-milvus-zilliz

📝 Commits (1)

  • 5c6333e Enforce name requirements for Zilliz/Milvus

📊 Changes

2 files changed (+50 additions, -30 deletions)

View changed files

📝 server/utils/vectorDbProviders/milvus/index.js (+25 -15)
📝 server/utils/vectorDbProviders/zilliz/index.js (+25 -15)

📄 Description

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #720

What is in this change?

Handle requirement for Zilliz/Milvus for collection naming where names can only contain letters,numbers, and underscores. Since we slugify we are using hyphens. We just need to move any invalid char to _

Additional Information

This mutation only occurs when talking to the db, the slug will remain the same in the DB/UI and elsewhere.

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/723 **Author:** [@timothycarambat](https://github.com/timothycarambat) **Created:** 2/14/2024 **Status:** ✅ Merged **Merged:** 2/14/2024 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `720-ensure-name-reqs-for-milvus-zilliz` --- ### 📝 Commits (1) - [`5c6333e`](https://github.com/Mintplex-Labs/anything-llm/commit/5c6333e30b71a57d512dc809085fee60043a95f9) Enforce name requirements for Zilliz/Milvus ### 📊 Changes **2 files changed** (+50 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `server/utils/vectorDbProviders/milvus/index.js` (+25 -15) 📝 `server/utils/vectorDbProviders/zilliz/index.js` (+25 -15) </details> ### 📄 Description ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [ ] ✨ feat - [x] 🐛 fix - [ ] ♻️ refactor - [ ] 💄 style - [ ] 🔨 chore - [ ] 📝 docs ### Relevant Issues <!-- Use "resolves #xxx" to auto resolve on merge. Otherwise, please use "connect #xxx" --> resolves #720 ### What is in this change? Handle requirement for Zilliz/Milvus for collection naming where names can only contain letters,numbers, and underscores. Since we slugify we are using hyphens. We just need to move any invalid char to `_` ### Additional Information This mutation only occurs when talking to the db, the slug will remain the same in the DB/UI and elsewhere. ### Developer Validations <!-- All of the applicable items should be checked. --> - [x] I ran `yarn lint` from the root of the repo & committed changes - [x] Relevant documentation has been updated - [x] I have tested my code functionality - [x] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:33:51 -05:00
yindo closed this issue 2026-02-22 18:33:51 -05:00
yindo changed title from [PR #723] Enforce name requirements for Zilliz/Milvus to [PR #723] [MERGED] Enforce name requirements for Zilliz/Milvus 2026-06-05 15:13:36 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#3473
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?