[PR #929] [MERGED] [REFACTOR] Refactor & comment document picker modal #3531

Closed
opened 2026-02-22 18:33:58 -05:00 by yindo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/929
Author: @shatfield4
Created: 3/19/2024
Status: Merged
Merged: 3/20/2024
Merged by: @timothycarambat

Base: masterHead: 914-refactor-refactorcomment-document-picker-modal


📝 Commits (10+)

  • b51428f implement alternating color rows for file picker
  • b2564c9 implement alternating colors for workspace directory
  • 1d44181 remove unneeded props/variables
  • ca948c7 Merge branch 'master' into 890-feat-implement-correct-highlight-colors-on-document-picker
  • 36907d9 remove unused border classes
  • add34d1 WIP new folder UI
  • 2458a97 remove unneeded expanded prop from filerow component
  • 8984afb Merge branch '890-feat-implement-correct-highlight-colors-on-document-picker' into 891-feat-upload-ui-folder-creation
  • eaa593c folder creation UI and files object manipulation WIP
  • b234067 folder creation & moving files complete

📊 Changes

9 files changed (+82 additions, -63 deletions)

View changed files

📝 frontend/src/components/Modals/MangeWorkspace/Documents/Directory/FileRow/index.jsx (+1 -1)
📝 frontend/src/components/Modals/MangeWorkspace/Documents/Directory/FolderRow/index.jsx (+3 -3)
📝 frontend/src/components/Modals/MangeWorkspace/Documents/Directory/index.jsx (+45 -47)
📝 frontend/src/components/Modals/MangeWorkspace/Documents/UploadFile/index.jsx (+2 -2)
📝 frontend/src/components/Modals/MangeWorkspace/Documents/WorkspaceDirectory/WorkspaceFileRow/index.jsx (+1 -1)
📝 frontend/src/components/Modals/MangeWorkspace/Documents/WorkspaceDirectory/index.jsx (+4 -4)
📝 frontend/src/components/Modals/MangeWorkspace/Documents/index.jsx (+2 -2)
📝 frontend/src/components/Modals/MangeWorkspace/index.jsx (+4 -3)
📝 frontend/src/index.css (+20 -0)

📄 Description

Pull Request Type

  • feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #914

blocked by #902

What is in this change?

Describe the changes in this PR that are impactful to the repo.

  • Add comments to document picker component for readability
  • Reduce complexity by combining functions that don't need to be split
  • Fix alternating row colors for file rows and folder rows
  • Make document picker modal responsive and switch flex direction on smaller screen sizes

Additional Information

Add any other context about the Pull Request here that was not captured above.

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/929 **Author:** [@shatfield4](https://github.com/shatfield4) **Created:** 3/19/2024 **Status:** ✅ Merged **Merged:** 3/20/2024 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `914-refactor-refactorcomment-document-picker-modal` --- ### 📝 Commits (10+) - [`b51428f`](https://github.com/Mintplex-Labs/anything-llm/commit/b51428fc07d52563868e0bb3a8dbfc41dfe795d8) implement alternating color rows for file picker - [`b2564c9`](https://github.com/Mintplex-Labs/anything-llm/commit/b2564c9bf6e5f8df8ac3abe2a64f4bbcf9931246) implement alternating colors for workspace directory - [`1d44181`](https://github.com/Mintplex-Labs/anything-llm/commit/1d44181829cad955a89f66e2e35bba5ab53e6325) remove unneeded props/variables - [`ca948c7`](https://github.com/Mintplex-Labs/anything-llm/commit/ca948c796d8c92d3eaca8bf4e0196bdb0ce8e9fd) Merge branch 'master' into 890-feat-implement-correct-highlight-colors-on-document-picker - [`36907d9`](https://github.com/Mintplex-Labs/anything-llm/commit/36907d93b22f9ad71f9d8ae96b94c16451eff3f5) remove unused border classes - [`add34d1`](https://github.com/Mintplex-Labs/anything-llm/commit/add34d17500343ead3c717ffc19829cc5c3541bb) WIP new folder UI - [`2458a97`](https://github.com/Mintplex-Labs/anything-llm/commit/2458a978cdbe88f36b8ad3a545cbe9f1f9b57497) remove unneeded expanded prop from filerow component - [`8984afb`](https://github.com/Mintplex-Labs/anything-llm/commit/8984afb1b973b85dd993132e63e024b1eddfbd5a) Merge branch '890-feat-implement-correct-highlight-colors-on-document-picker' into 891-feat-upload-ui-folder-creation - [`eaa593c`](https://github.com/Mintplex-Labs/anything-llm/commit/eaa593cadb1da9d76a6bde7102567a95b7a5b700) folder creation UI and files object manipulation WIP - [`b234067`](https://github.com/Mintplex-Labs/anything-llm/commit/b23406752552ad421007df3ae4326867c873f495) folder creation & moving files complete ### 📊 Changes **9 files changed** (+82 additions, -63 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/components/Modals/MangeWorkspace/Documents/Directory/FileRow/index.jsx` (+1 -1) 📝 `frontend/src/components/Modals/MangeWorkspace/Documents/Directory/FolderRow/index.jsx` (+3 -3) 📝 `frontend/src/components/Modals/MangeWorkspace/Documents/Directory/index.jsx` (+45 -47) 📝 `frontend/src/components/Modals/MangeWorkspace/Documents/UploadFile/index.jsx` (+2 -2) 📝 `frontend/src/components/Modals/MangeWorkspace/Documents/WorkspaceDirectory/WorkspaceFileRow/index.jsx` (+1 -1) 📝 `frontend/src/components/Modals/MangeWorkspace/Documents/WorkspaceDirectory/index.jsx` (+4 -4) 📝 `frontend/src/components/Modals/MangeWorkspace/Documents/index.jsx` (+2 -2) 📝 `frontend/src/components/Modals/MangeWorkspace/index.jsx` (+4 -3) 📝 `frontend/src/index.css` (+20 -0) </details> ### 📄 Description ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [ ] ✨ feat - [ ] 🐛 fix - [x] ♻️ refactor - [ ] 💄 style - [ ] 🔨 chore - [ ] 📝 docs ### Relevant Issues <!-- Use "resolves #xxx" to auto resolve on merge. Otherwise, please use "connect #xxx" --> resolves #914 blocked by #902 ### What is in this change? Describe the changes in this PR that are impactful to the repo. - Add comments to document picker component for readability - Reduce complexity by combining functions that don't need to be split - Fix alternating row colors for file rows and folder rows - Make document picker modal responsive and switch flex direction on smaller screen sizes ### Additional Information Add any other context about the Pull Request here that was not captured above. ### Developer Validations <!-- All of the applicable items should be checked. --> - [x] I ran `yarn lint` from the root of the repo & committed changes - [x] Relevant documentation has been updated - [x] I have tested my code functionality - [x] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:33:58 -05:00
yindo closed this issue 2026-02-22 18:33:58 -05:00
yindo changed title from [PR #929] [REFACTOR] Refactor & comment document picker modal to [PR #929] [MERGED] [REFACTOR] Refactor & comment document picker modal 2026-06-05 15:13:55 -04:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#3531