Mintplex-Labs/anything-llm
1
0
Fork 0
mirror of https://github.com/Mintplex-Labs/anything-llm.git synced 2026-07-19 14:13:35 -04:00
Code Issues 328 Packages Projects Releases 10 Wiki Activity

[PR #978] [MERGED] [FIX] User messages not saving due to empty message check #3542

New Issue
Closed
opened 2026-02-22 18:34:00 -05:00 by yindo · 0 comments
yindo commented 2026-02-22 18:34:00 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/Mintplex-Labs/anything-llm/pull/978
Author: @shatfield4
Created: 3/26/2024
Status: ✅ Merged
Merged: 3/27/2024
Merged by: @timothycarambat

Base: master ← Head: 974-custom-message-not-saving-bug-fix

📝 Commits (1)

  • 0b1416b fix user messages not saving due to empty message check

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 server/models/welcomeMessages.js (+1 -1)

📄 Description

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #974

What is in this change?

Describe the changes in this PR that are impactful to the repo.

  • Fix bug where user message would not save due to skipping message if message.response does not exist
  • Fixed to check if both message.response and message.user does not exist, then skip

Additional Information

Add any other context about the Pull Request here that was not captured above.

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Mintplex-Labs/anything-llm/pull/978 **Author:** [@shatfield4](https://github.com/shatfield4) **Created:** 3/26/2024 **Status:** ✅ Merged **Merged:** 3/27/2024 **Merged by:** [@timothycarambat](https://github.com/timothycarambat) **Base:** `master` ← **Head:** `974-custom-message-not-saving-bug-fix` --- ### 📝 Commits (1) - [`0b1416b`](https://github.com/Mintplex-Labs/anything-llm/commit/0b1416b2c5f932a919180f2c7f9cdd5a87af68b4) fix user messages not saving due to empty message check ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `server/models/welcomeMessages.js` (+1 -1) </details> ### 📄 Description ### Pull Request Type <!-- For change type, change [ ] to [x]. --> - [ ] ✨ feat - [x] 🐛 fix - [ ] ♻️ refactor - [ ] 💄 style - [ ] 🔨 chore - [ ] 📝 docs ### Relevant Issues <!-- Use "resolves #xxx" to auto resolve on merge. Otherwise, please use "connect #xxx" --> resolves #974 ### What is in this change? Describe the changes in this PR that are impactful to the repo. - Fix bug where user message would not save due to skipping message if message.response does not exist - Fixed to check if both message.response and message.user does not exist, then skip ### Additional Information Add any other context about the Pull Request here that was not captured above. ### Developer Validations <!-- All of the applicable items should be checked. --> - [x] I ran `yarn lint` from the root of the repo & committed changes - [x] Relevant documentation has been updated - [x] I have tested my code functionality - [x] Docker build succeeds locally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-22 18:34:00 -05:00
yindo closed this issue 2026-02-22 18:34:00 -05:00
yindo changed title from [PR #978] [FIX] User messages not saving due to empty message check to [PR #978] [MERGED] [FIX] User messages not saving due to empty message check 2026-06-05 15:13:58 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Desktop
Docker
Integration Request
Integration Request
OS: Linux
OS: Mobile
OS: Windows
UI/UX
blocked
bug
bug
core-team-only
documentation
duplicate
embed-widget
enhancement
feature request
github_actions
good first issue
investigating
needs info / can't replicate
possible bug
pull-request
Mirrored from GitHub Pull Request
 question
stage: specifications
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Mintplex-Labs/anything-llm#3542
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?